MailOptionsAbstractFactory::createServiceWithName()

Complexity

Conditions	8
Paths	16

Size

Total Lines	30
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	8

Importance

Changes	7
Bugs	2	Features	0

<?php
    public function createServiceWithName(ServiceLocatorInterface $serviceLocator, $name, $requestedName)
    {
        $specificServiceName = explode('.', $name)[2];
        $config = $this->getConfig($serviceLocator);
        $specificConfig = $config[$specificServiceName];
        if (! is_array($specificConfig)) {
            $specificConfig = [];
        }

        do {
            // Get extends
            $extendsConfigKey = isset($specificConfig['extends']) && is_string($specificConfig['extends'])
                ? trim($specificConfig['extends'])
                : null;

            // Always unset the extends, in case it had a value null, to prevent the MailOptions object to throw an
            // exception
            unset($specificConfig['extends']);

            // Try to extend from another configuration if defined and exists
            if (! is_null($extendsConfigKey)
                && array_key_exists($extendsConfigKey, $config)
                && is_array($config[$extendsConfigKey])
            ) {
                $specificConfig = ArrayUtils::merge($config[$extendsConfigKey], $specificConfig);
            }
        } while ($extendsConfigKey != null);

It seems like you are loosely comparing $extendsConfigKey of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

        return new MailOptions($specificConfig);
    }
}