academico-sis / academico

app/Traits/PeriodSelection.php

<?php

namespace App\Traits;

use App\Models\Period;
use Illuminate\Http\Request;

trait PeriodSelection
{
    public $currentPeriod;

    public function __construct()
    {
        if (Period::count() > 0) {
            $this->currentPeriod = Period::get_default_period()->id;
        }
    }

    protected function selectPeriod(Request $request)
    {
        $period_id = $request->query('period');
        if ($period_id == null) {

It seems like you are loosely comparing $period_id of type array|null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $period = Period::get_default_period();
        } else {
            $period = Period::find($period_id);
        }

        return $period;
    }
}