academico-sis / academico

app/Http/Middleware/SetLocale.php

<?php

namespace App\Http\Middleware;

use Carbon\Carbon;
use Closure;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\App;
use Illuminate\Support\Facades\Date;

class SetLocale
{
    /**
     * This function checks if language to set is an allowed lang of config.
     */
    private function setLocale(string $locale)
    {
        // Check if is allowed and set default locale if not
        if (! language()->allowed($locale)) {
            $locale = config('app.locale');
        }

        // Set app language
        App::setLocale($locale);

        // Set carbon language
        if (config('language.carbon')) {
            // Carbon uses only language code
            if (config('language.mode.code') == 'long') {
                $locale = explode('-', $locale)[0];
            }

            Carbon::setLocale($locale);
        }

        // Set date language
        if (config('language.date')) {
            // Date uses only language code
            if (config('language.mode.code') == 'long') {
                $locale = explode('-', $locale)[0];
            }

            Date::setLocale($locale);
        }
    }

    public function setDefaultLocale()
    {
        $this->setLocale(config('app.locale'));
    }

    public function setUserLocale()
    {
        $user = backpack_auth()->user();

        if ($user->locale) {

Accessing locale on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $this->setLocale($user->locale);
        } else {
            $this->setDefaultLocale();
        }
    }

    public function setSystemLocale($request)
    {
        if ($request->session()->has('locale')) {
            $this->setLocale(session('locale'));

It seems like session('locale') can also be of type Illuminate\Session\SessionManager and Illuminate\Session\Store; however, parameter $locale of App\Http\Middleware\SetLocale::setLocale() does only seem to accept string, maybe add an additional type check?

        } else {
            $this->setDefaultLocale();
        }
    }

    /**
     * Handle an incoming request.
     *
     * @param Request $request
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        if (backpack_auth()->check()) {
            $this->setUserLocale();
        } else {
            $this->setSystemLocale($request);
        }

        return $next($request);
    }
}