academico-sis / academico

app/Http/Controllers/HomeController.php

<?php

namespace App\Http\Controllers;

use App\Models\Event;
use App\Models\LeadType;
use App\Models\Period;
use App\Models\Student;
use App\Models\Teacher;
use App\Traits\PeriodSelection;
use Carbon\Carbon;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;

class HomeController extends Controller
{
    use PeriodSelection;

The trait App\Traits\PeriodSelection requires the property $id which is not provided by App\Http\Controllers\HomeController.

    public function __construct()
    {
        parent::__construct();

        $this->middleware(backpack_middleware());
    }

    /**
     * redirect the user according to their role.
     */
    public function index()
    {
        if (backpack_user()->hasRole(['admin', 'secretary'])) {

The method hasRole() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            return redirect()->route('admin');
        } elseif (backpack_user()->isTeacher()) {

The method isTeacher() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            return redirect()->route('teacherDashboard');
        } elseif (backpack_user()->isStudent()) {

The method isStudent() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            return redirect()->route('studentDashboard');
        } else {
            // this should never happen
            Log::warning(backpack_user()->id.' accessed the generic dashboard (no role identified)');

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            abort(403, 'User with no role');
        }
    }

    public function teacher(Request $request)
    {
        if (! backpack_user()->isTeacher()) {
            abort(403);
        }

        $period = $this->selectPeriod($request);

        $teacher = Teacher::where('id', backpack_user()->id)->first();

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        Log::info($teacher->name.' accessed the student dashboard');

        $remoteVolume = $teacher->courses()->whereNull('parent_course_id')->where('period_id', $period->id)->sum('remote_volume');
        $presentialVolume = $teacher->courses()->whereNull('parent_course_id')->where('period_id', $period->id)->sum('volume');

        return view('teacher.dashboard', [
            'teacher' => $teacher,
            'courses' => $teacher->period_courses($period),
            'pending_attendance' => $teacher->events_with_pending_attendance($period),
            'selected_period' => $period,
            'remoteVolume' => $remoteVolume,
            'volume' => $presentialVolume,
            'totalVolume' => $remoteVolume + $presentialVolume,
        ]);
    }

    public function student()
    {
        if (! backpack_user()->isStudent()) {
            abort(403);
        }

        $student = Student::where('id', backpack_user()->id)->first();

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        Log::info($student->name.' accessed the student dashboard');

        return view('student.dashboard', [
            'student' => $student,
            'enrollments' => $student->enrollments()->real(),
        ]);
    }

    public function admin()
    {
        $currentPeriod = Period::get_default_period();
        $enrollmentsPeriod = Period::get_enrollments_period();

        if (! backpack_user()->hasRole(['admin', 'secretary'])) {
            abort(403);
        }

        Log::info(backpack_user()->firstname.' '.backpack_user()->lastname.' accessed the admin dashboard');

Accessing lastname on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing firstname on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        // todo optimize this !!
        $events = Event::where('start', '>', Carbon::now()->subDays(15))->where('end', '<', Carbon::now()->addDays(15))->orderBy('id', 'desc')
            ->get()
            ->map(fn ($event) => [
                'title' => $event['name'],
                'resourceId' => $event['teacher_id'],
                'start' => $event['start'],
                'end' => $event['end'],
                'backgroundColor' => $event['color'],
                'borderColor' => $event['color'],
            ])
            ->toArray();

        $teachers = Teacher::with('user')->get()->toArray();

        $teachers = array_map(fn ($teacher) => [
            'id' => $teacher['id'],
            'title' => $teacher['user']['firstname'],
        ], $teachers);

        return view('admin.dashboard', [
            'pending_enrollment_count' => $currentPeriod->pending_enrollments_count,
            'paid_enrollment_count' => $currentPeriod->paid_enrollments_count,
            'students_count' => $currentPeriod->studentCount(),
            'currentPeriod' => $currentPeriod,
            'enrollmentsPeriod' => $enrollmentsPeriod,
            'total_enrollment_count' => $currentPeriod->internal_enrollments_count,
            'resources' => $teachers,
            'events' => $events,
            'pending_attendance' => $currentPeriod->courses_with_pending_attendance,
            // todo: optimize
            'unassigned_events' => Event::unassigned()->count(),
            'pending_leads' => LeadType::find(4)->students()->count(),
        ]);
    }
}