academico-sis / academico

app/Providers/AuthServiceProvider.php

Spacing +10 added lines, -10 removed lines

@@ -29,7 +29,7 @@ 
          * a user is allowed to view the course attendance sheet if they are the teacher for this course,
          * or if they have explicit permission to view all course attendance sheets
          */
-        Gate::define('view-course-attendance', function ($user, $course) {
+        Gate::define('view-course-attendance', function($user, $course) {
             return $user->teacher_id == $course->teacher_id || $user->can('attendance.view');
         });
 
@@ -38,7 +38,7 @@ 
          * if they are the teacher for this course,
          * or if they have explicit permission to view all event attendance sheets
          */
-        Gate::define('view-event-attendance', function ($user, $event) {
+        Gate::define('view-event-attendance', function($user, $event) {
             return ($event->teacher_id == $user->teacher_id) || ($event->course->teacher_id == $user->teacher_id) || $user->can('attendance.view');
         });
 
@@ -47,7 +47,7 @@ 
          * if they are the teacher for the course,
          * or if they have explicit permission to edit any attendance sheets
          */
-        Gate::define('edit-attendance', function ($user, $event) {
+        Gate::define('edit-attendance', function($user, $event) {
             return ($event->teacher_id == $user->teacher_id) || ($event->course->teacher_id == $user->teacher_id) || $user->can('attendance.edit');
         });
 
@@ -55,7 +55,7 @@ 
          * teachers are allowed to view their own calendar,
          * and users with explicit permission can view all calendars
          */
-        Gate::define('view-teacher-calendar', function ($user, $teacher) {
+        Gate::define('view-teacher-calendar', function($user, $teacher) {
             return ($user->teacher_id == $teacher->id) || $user->can('calendars.view');
         });
 
@@ -63,7 +63,7 @@ 
          * teachers are allowed to view their own courses,
          * and users with explicit permission can view all courses
          */
-        Gate::define('view-course', function ($user, $course) {
+        Gate::define('view-course', function($user, $course) {
             return ($user->teacher_id == $course->teacher_id) || $user->can('courses.view');
         });
 
@@ -72,7 +72,7 @@ 
          * if they are a teacher
          * of if they have explicit permission to view any result
          */
-        Gate::define('view-enrollment', function ($user, $enrollment) {
+        Gate::define('view-enrollment', function($user, $enrollment) {
             return ($user->student_id == $enrollment->student_id) || $user->isTeacher() || $user->can('evaluation.view');
         });
 
@@ -80,7 +80,7 @@ 
          * if the user is the teacher of the course
          * of if they have explicit permission to enroll students
          */
-        Gate::define('enroll-in-course', function ($user, $course) {
+        Gate::define('enroll-in-course', function($user, $course) {
             return $course->teacher_id == $user->teacher_id || $user->can('enrollments.edit');
         });
 
@@ -88,7 +88,7 @@ 
          * if the user is a teacher
          * of if they have explicit permission to enroll students
          */
-        Gate::define('enroll-students', function ($user) {
+        Gate::define('enroll-students', function($user) {
             return $user->isTeacher() || $user->can('enrollments.edit');
         });
 
@@ -96,7 +96,7 @@ 
          * teachers are allowed to view their own hours,
          * and users with explicit permission can view all hours
          */
-        Gate::define('view-teacher-hours', function ($user, $teacher) {
+        Gate::define('view-teacher-hours', function($user, $teacher) {
             return ($user->teacher_id == $teacher->id) || $user->can('hr.view');
         });
 
@@ -104,7 +104,7 @@ 
          * teachers are allowed to edit results for their own students
          * as well as users with explicit permission to edit any result
          */
-        Gate::define('edit-result', function ($user, $enrollment) {
+        Gate::define('edit-result', function($user, $enrollment) {
             return ($user->teacher_id == $enrollment->course->teacher_id) || $user->can('evaluation.edit');
         });
     }

app/Http/Controllers/Admin/CommentCrudController.php

Indentation +8 added lines, -8 removed lines

@@ -92,10 +92,10 @@ 
             'name' => 'action',
             'label'=> 'Action',
         ],
-              false,
-              function () { // if the filter is active
-                  CRUD::addClause('where', 'action', true);
-              });
+                false,
+                function () { // if the filter is active
+                    CRUD::addClause('where', 'action', true);
+                });
 
         CRUD::addFilter([ // dropdown filter
             'name' => 'type',
@@ -109,10 +109,10 @@ 
         ], function ($value) { // if the filter is active
             CRUD::addClause('where', 'commentable_type', '=', $value);
         },
-              function () { // if the filter is not active
-                  CRUD::addClause('where', 'commentable_type', '=', Student::class);
-                  $this->crud->getRequest()->request->add(['commentable_type' => Student::class]); // to make the filter look active
-              });
+                function () { // if the filter is not active
+                    CRUD::addClause('where', 'commentable_type', '=', Student::class);
+                    $this->crud->getRequest()->request->add(['commentable_type' => Student::class]); // to make the filter look active
+                });
     }
 
     public function setupUpdateOperation()

Spacing +5 added lines, -5 removed lines

@@ -87,17 +87,17 @@ 
             ],
         ]);
 
-        CRUD::addFilter([ // simple filter
+        CRUD::addFilter([// simple filter
             'type' => 'simple',
             'name' => 'action',
             'label'=> 'Action',
         ],
               false,
-              function () { // if the filter is active
+              function() { // if the filter is active
                   CRUD::addClause('where', 'action', true);
               });
 
-        CRUD::addFilter([ // dropdown filter
+        CRUD::addFilter([// dropdown filter
             'name' => 'type',
             'type' => 'dropdown',
             'label'=> 'Type',
@@ -106,10 +106,10 @@ 
             Enrollment::class => 'Enrollments',
             Result::class => 'Result',
 
-        ], function ($value) { // if the filter is active
+        ], function($value) { // if the filter is active
             CRUD::addClause('where', 'commentable_type', '=', $value);
         },
-              function () { // if the filter is not active
+              function() { // if the filter is not active
                   CRUD::addClause('where', 'commentable_type', '=', Student::class);
                   $this->crud->getRequest()->request->add(['commentable_type' => Student::class]); // to make the filter look active
               });

app/Http/Controllers/Admin/CourseCrudController.php

Indentation +11 added lines, -11 removed lines

@@ -181,8 +181,8 @@ 
         }, function ($value) { // if the filter is active
             CRUD::addClause('where', 'rhythm_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
-          });
+            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+            });
 
         CRUD::addFilter([ // select2 filter
             'name' => 'teacher_id',
@@ -193,8 +193,8 @@ 
         }, function ($value) { // if the filter is active
             CRUD::addClause('where', 'teacher_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
-          });
+            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+            });
 
         CRUD::addFilter([ // select2 filter
             'name' => 'level_id',
@@ -205,8 +205,8 @@ 
         }, function ($value) { // if the filter is active
             CRUD::addClause('where', 'level_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
-          });
+            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+            });
 
         CRUD::addFilter([ // select2 filter
             'name' => 'period_id',
@@ -217,11 +217,11 @@ 
         }, function ($value) { // if the filter is active
             CRUD::addClause('where', 'period_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
-              $period = Period::get_default_period()->id;
-              CRUD::addClause('where', 'period_id', $period);
-              $this->crud->getRequest()->request->add(['period_id' => $period]); // to make the filter look active
-          });
+            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+                $period = Period::get_default_period()->id;
+                CRUD::addClause('where', 'period_id', $period);
+                $this->crud->getRequest()->request->add(['period_id' => $period]); // to make the filter look active
+            });
     }
 
     protected function setupCreateOperation()

Spacing +19 added lines, -19 removed lines

@@ -57,11 +57,11 @@ 
 
         $permissions = backpack_user()->getAllPermissions();
 
-        if (! $permissions->contains('name', 'courses.edit')) {
+        if (!$permissions->contains('name', 'courses.edit')) {
             CRUD::denyAccess('update');
         }
 
-        if (! $permissions->contains('name', 'courses.edit')) {
+        if (!$permissions->contains('name', 'courses.edit')) {
             CRUD::denyAccess('create');
         }
 
@@ -75,7 +75,7 @@ 
 
         CRUD::addButtonFromView('line', 'children_badge', 'children_badge', 'beginning');
 
-        if (! $permissions->contains('name', 'courses.delete')) {
+        if (!$permissions->contains('name', 'courses.delete')) {
             CRUD::denyAccess('delete');
         }
 
@@ -172,52 +172,52 @@ 
 
         ]);
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'rhythm_id',
             'type' => 'select2',
             'label'=> __('Rhythm'),
-        ], function () {
+        ], function() {
             return Rhythm::all()->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'rhythm_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
           });
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'teacher_id',
             'type' => 'select2',
             'label'=> __('Teacher'),
-        ], function () {
+        ], function() {
             return Teacher::all()->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'teacher_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
           });
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'level_id',
             'type' => 'select2',
             'label'=> __('Level'),
-        ], function () {
+        ], function() {
             return Level::all()->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'level_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
           });
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'period_id',
             'type' => 'select2',
             'label'=> __('Period'),
-        ], function () {
+        ], function() {
             return Period::all()->sortByDesc('id')->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'period_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
               $period = Period::get_default_period()->id;
               CRUD::addClause('where', 'period_id', $period);
               $this->crud->getRequest()->request->add(['period_id' => $period]); // to make the filter look active

app/Http/Controllers/Admin/SkillCrudController.php

Spacing +10 added lines, -10 removed lines

@@ -35,7 +35,7 @@ 
     protected function setupListOperation()
     {
         CRUD::setColumns([
-            [ // skill type
+            [// skill type
                 'label'     => 'Type', // Table column heading
                 'type'      => 'select',
                 'name'      => 'skill_type', // the method that defines the relationship in your Model
@@ -48,7 +48,7 @@ 
                 'type' => 'text',
                 'name' => 'name',
             ],
-            [ // skill level
+            [// skill level
                 'label'     => 'Level', // Table column heading
                 'type'      => 'select',
                 'name'      => 'level', // the method that defines the relationship in your Model
@@ -60,23 +60,23 @@ 
 
         CRUD::enableBulkActions();
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'level_id',
             'type' => 'select2',
             'label'=> 'Level',
-        ], function () {
+        ], function() {
             return Level::all()->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'level_id', $value);
         });
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'skill_type_id',
             'type' => 'select2',
             'label'=> 'Type',
-        ], function () {
+        ], function() {
             return SkillType::all()->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'skill_type_id', $value);
         });
     }
@@ -85,7 +85,7 @@ 
     {
         CRUD::setValidation(StoreRequest::class);
         CRUD::addFields([
-            [ // skill type
+            [// skill type
                 'label'     => 'Type', // Table column heading
                 'type' => 'select',
                 'name' => 'skill_type_id', // the db column for the foreign key
@@ -98,7 +98,7 @@ 
                 'type' => 'text',
                 'name' => 'name',
             ],
-            [ // skill level
+            [// skill level
                 'label'     => 'Level', // Table column heading
                 'type' => 'select',
                 'name' => 'level_id', // the db column for the foreign key

app/Http/Controllers/Admin/CourseEvaluationCrudController.php

Indentation +11 added lines, -11 removed lines

@@ -95,8 +95,8 @@ 
         }, function ($value) { // if the filter is active
             CRUD::addClause('where', 'rhythm_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
-          });
+            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+            });
 
         CRUD::addFilter([ // select2 filter
             'name' => 'teacher_id',
@@ -107,8 +107,8 @@ 
         }, function ($value) { // if the filter is active
             CRUD::addClause('where', 'teacher_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
-          });
+            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+            });
 
         CRUD::addFilter([ // select2 filter
             'name' => 'level_id',
@@ -119,8 +119,8 @@ 
         }, function ($value) { // if the filter is active
             CRUD::addClause('where', 'level_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
-          });
+            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+            });
 
         CRUD::addFilter([ // select2 filter
             'name' => 'period_id',
@@ -131,11 +131,11 @@ 
         }, function ($value) { // if the filter is active
             CRUD::addClause('where', 'period_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
-              $period = Period::get_default_period()->id;
-              CRUD::addClause('where', 'period_id', $period);
-              $this->crud->getRequest()->request->add(['period_id' => $period]); // to make the filter look active
-          });
+            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+                $period = Period::get_default_period()->id;
+                CRUD::addClause('where', 'period_id', $period);
+                $this->crud->getRequest()->request->add(['period_id' => $period]); // to make the filter look active
+            });
     }
 
     protected function setupCreateOperation()

Spacing +16 added lines, -16 removed lines

@@ -86,52 +86,52 @@
 
         ]);
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'rhythm_id',
             'type' => 'select2',
             'label'=> __('Rhythm'),
-        ], function () {
+        ], function() {
             return Rhythm::all()->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'rhythm_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
           });
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'teacher_id',
             'type' => 'select2',
             'label'=> __('Teacher'),
-        ], function () {
+        ], function() {
             return Teacher::all()->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'teacher_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
           });
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'level_id',
             'type' => 'select2',
             'label'=> __('Level'),
-        ], function () {
+        ], function() {
             return Level::all()->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'level_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
           });
 
-        CRUD::addFilter([ // select2 filter
+        CRUD::addFilter([// select2 filter
             'name' => 'period_id',
             'type' => 'select2',
             'label'=> __('Period'),
-        ], function () {
+        ], function() {
             return Period::all()->sortByDesc('id')->pluck('name', 'id')->toArray();
-        }, function ($value) { // if the filter is active
+        }, function($value) { // if the filter is active
             CRUD::addClause('where', 'period_id', $value);
         },
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
               $period = Period::get_default_period()->id;
               CRUD::addClause('where', 'period_id', $period);
               $this->crud->getRequest()->request->add(['period_id' => $period]); // to make the filter look active

app/Http/Controllers/HomeController.php

Spacing +6 added lines, -6 removed lines

@@ -48,7 +48,7 @@ 
 
     public function teacher(Request $request)
     {
-        if (! backpack_user()->isTeacher()) {
+        if (!backpack_user()->isTeacher()) {
             abort(403);
         }
 
@@ -67,7 +67,7 @@ 
 
     public function student()
     {
-        if (! backpack_user()->isStudent()) {
+        if (!backpack_user()->isStudent()) {
             abort(403);
         }
 
@@ -85,7 +85,7 @@ 
         $currentPeriod = Period::get_default_period();
         $enrollmentsPeriod = Period::get_enrollments_period();
 
-        if (! backpack_user()->hasRole(['admin', 'secretary'])) {
+        if (!backpack_user()->hasRole(['admin', 'secretary'])) {
             abort(403);
         }
 
@@ -96,14 +96,14 @@ 
 
         $teachers = Teacher::with('user')->get()->toArray();
 
-        $teachers = array_map(function ($teacher) {
+        $teachers = array_map(function($teacher) {
             return [
                 'id' => $teacher['id'],
                 'title' => $teacher['user']['firstname'],
             ];
         }, $teachers);
 
-        $events = array_map(function ($event) {
+        $events = array_map(function($event) {
             return [
                 'title' => $event['name'],
                 'resourceId' => $event['teacher_id'],
@@ -121,7 +121,7 @@ 
             'currentPeriod' => $currentPeriod,
             'enrollmentsPeriod' => $enrollmentsPeriod,
             'total_enrollment_count' => $currentPeriod->internal_enrollments_count,
-            'pending_attendance' => $currentPeriod->courses_with_pending_attendance,  // optimize
+            'pending_attendance' => $currentPeriod->courses_with_pending_attendance, // optimize
             'unassigned_events' => (new Event())->unassigned_teacher->count(),
             'upcoming_leaves' => Leave::upcoming_leaves(),
             'resources' => $teachers,

app/Console/Kernel.php

Spacing +2 added lines, -2 removed lines

@@ -29,12 +29,12 @@
      */
     protected function schedule(Schedule $schedule)
     {
-        $schedule->call(function () {
+        $schedule->call(function() {
             Log::info('Sending attendance reminders');
             (new Attendance())->remindPendingAttendance();
         })->dailyAt('08:15');
 
-        $schedule->call(function () {
+        $schedule->call(function() {
             Log::info('Checking default periods');
 
             // when we finish the current period; remove the manual override to automatically fallbackto the next one

app/Models/Event.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
         parent::boot();
 
         // before adding an event, we check that the teacher is available
-        static::saving(function ($event) {
+        static::saving(function($event) {
             $teacher = Teacher::find($event->teacher_id);
             // if the teacher is on leave on the day of the event
             if (($event->teacher_id !== null) && $teacher->leaves->contains('date', Carbon::parse($event->start)->toDateString())) {

app/Models/Enrollment.php

Spacing +6 added lines, -6 removed lines

@@ -27,7 +27,7 @@ 
         parent::boot();
 
         // when creating a new enrollment, also add past attendance
-        static::created(function (self $enrollment) {
+        static::created(function(self $enrollment) {
             $events = $enrollment->course->events->where('start', '<', (new Carbon())->toDateString());
             foreach ($events as $event) {
                 $event->attendance()->create([
@@ -58,11 +58,11 @@ 
     public function scopeWithoutChildren($query)
     {
         return $query
-            ->where(function ($query) {
+            ->where(function($query) {
                 $query->whereDoesntHave('childrenEnrollments')
                 ->where('parent_id', null);
             })
-            ->orWhere(function ($query) {
+            ->orWhere(function($query) {
                 $query->where('parent_id', null);
             })
             ->get();
@@ -84,7 +84,7 @@ 
 
     public function scopePeriod(Builder $query, $period)
     {
-        return $query->whereHas('course', function ($q) use ($period) {
+        return $query->whereHas('course', function($q) use ($period) {
             $q->where('period_id', $period);
         });
     }
@@ -293,13 +293,13 @@ 
 
         // delete attendance records related to the enrollment
         $attendances = $this->course->attendance->where('student_id', $this->student->id);
-        Attendance::destroy($attendances->map(function ($item, $key) {
+        Attendance::destroy($attendances->map(function($item, $key) {
             return $item->id;
         }));
 
         foreach ($this->course->children as $child) {
             $attendances = $child->attendance->where('student_id', $this->student->id);
-            Attendance::destroy($attendances->map(function ($item, $key) {
+            Attendance::destroy($attendances->map(function($item, $key) {
                 return $item->id;
             }));
         }