Passed
Push — master ( 59f95b...dae6f7 )
by Thomas
12:11
created
app/Http/Controllers/Admin/LeaveCrudController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -72,25 +72,25 @@  discard block
 block discarded – undo
72 72
             ],
73 73
         ]);
74 74
 
75
-        CRUD::addFilter([ // select2 filter
75
+        CRUD::addFilter([// select2 filter
76 76
             'name' => 'teacher_id',
77 77
             'type' => 'select2',
78 78
             'label'=> __('Teacher'),
79
-        ], function () {
79
+        ], function() {
80 80
             return Teacher::all()->pluck('name', 'id')->toArray();
81
-        }, function ($value) { // if the filter is active
81
+        }, function($value) { // if the filter is active
82 82
             CRUD::addClause('where', 'teacher_id', $value);
83 83
         },
84
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
84
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
85 85
           });
86 86
 
87
-        CRUD::addFilter([ // daterange filter
87
+        CRUD::addFilter([// daterange filter
88 88
             'type' => 'date_range',
89 89
             'name' => 'from_to',
90 90
             'label'=> __('Date range'),
91 91
         ],
92 92
           false,
93
-          function ($value) { // if the filter is active, apply these constraints
93
+          function($value) { // if the filter is active, apply these constraints
94 94
               $dates = json_decode($value);
95 95
               CRUD::addClause('where', 'date', '>=', $dates->from);
96 96
               CRUD::addClause('where', 'date', '<=', $dates->to.' 23:59:59');
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
                 'model' => LeaveType::class, // foreign key model
123 123
             ],
124 124
 
125
-            [   // date_range
125
+            [// date_range
126 126
                 'name' => ['start_date', 'end_date'], // db columns for start_date & end_date
127 127
                 'label' => 'Event Date Range',
128 128
                 'type' => 'date_range',
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
                 'model' => LeaveType::class, // foreign key model
167 167
             ],
168 168
 
169
-            [   // datepicker
169
+            [// datepicker
170 170
                 'name' => 'date',
171 171
                 'label' => 'Event Date',
172 172
                 'type' => 'date',
Please login to merge, or discard this patch.
app/Http/Controllers/Admin/EventCrudController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -112,13 +112,13 @@  discard block
 block discarded – undo
112 112
 
113 113
         ]);
114 114
 
115
-        CRUD::addFilter([ // daterange filter
115
+        CRUD::addFilter([// daterange filter
116 116
             'type' => 'date_range',
117 117
             'name' => 'from_to',
118 118
             'label'=> __('Date range'),
119 119
         ],
120 120
           false,
121
-          function ($value) { // if the filter is active, apply these constraints
121
+          function($value) { // if the filter is active, apply these constraints
122 122
               $dates = json_decode($value);
123 123
 
124 124
               if ($dates->from) {
@@ -135,10 +135,10 @@  discard block
 block discarded – undo
135 135
             'label'=> __('Events with no course'),
136 136
         ],
137 137
           false,
138
-          function ($value) { // if the filter is active, apply these constraints
138
+          function($value) { // if the filter is active, apply these constraints
139 139
               $this->crud->query->where('course_id', null);
140 140
           },
141
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
141
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
142 142
           });
143 143
 
144 144
         CRUD::addFilter([
@@ -147,20 +147,20 @@  discard block
 block discarded – undo
147 147
             'label'=> __('Events with no teacher'),
148 148
         ],
149 149
           false,
150
-          function ($value) { // if the filter is active, apply these constraints
150
+          function($value) { // if the filter is active, apply these constraints
151 151
               $this->crud->query->where('teacher_id', null);
152 152
           });
153 153
 
154
-        CRUD::addFilter([ // select2 filter
154
+        CRUD::addFilter([// select2 filter
155 155
             'name' => 'teacher_id',
156 156
             'type' => 'select2',
157 157
             'label'=> __('Teacher'),
158
-        ], function () {
158
+        ], function() {
159 159
             return Teacher::all()->pluck('name', 'id')->toArray();
160
-        }, function ($value) { // if the filter is active
160
+        }, function($value) { // if the filter is active
161 161
             CRUD::addClause('where', 'teacher_id', $value);
162 162
         },
163
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
163
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
164 164
           });
165 165
     }
166 166
 
Please login to merge, or discard this patch.
app/Http/Controllers/HomeController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
     public function teacher(Request $request)
50 50
     {
51
-        if (! backpack_user()->isTeacher()) {
51
+        if (!backpack_user()->isTeacher()) {
52 52
             abort(403);
53 53
         }
54 54
 
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
     public function student()
69 69
     {
70
-        if (! backpack_user()->isStudent()) {
70
+        if (!backpack_user()->isStudent()) {
71 71
             abort(403);
72 72
         }
73 73
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         $currentPeriod = Period::get_default_period();
86 86
         $enrollmentsPeriod = Period::get_enrollments_period();
87 87
 
88
-        if (! backpack_user()->hasRole(['admin', 'secretary'])) {
88
+        if (!backpack_user()->hasRole(['admin', 'secretary'])) {
89 89
             abort(403);
90 90
         }
91 91
 
@@ -96,14 +96,14 @@  discard block
 block discarded – undo
96 96
 
97 97
         $teachers = Teacher::with('user')->get()->toArray();
98 98
 
99
-        $teachers = array_map(function ($teacher) {
99
+        $teachers = array_map(function($teacher) {
100 100
             return [
101 101
                 'id' => $teacher['id'],
102 102
                 'title' => $teacher['user']['firstname'],
103 103
             ];
104 104
         }, $teachers);
105 105
 
106
-        $events = array_map(function ($event) {
106
+        $events = array_map(function($event) {
107 107
             return [
108 108
                 'title' => $event['name'],
109 109
                 'resourceId' => $event['teacher_id'],
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
             'currentPeriod' => $currentPeriod,
122 122
             'enrollmentsPeriod' => $enrollmentsPeriod,
123 123
             'total_enrollment_count' => $currentPeriod->internal_enrollments_count,
124
-            'pending_attendance' => $currentPeriod->courses_with_pending_attendance,  // optimize
124
+            'pending_attendance' => $currentPeriod->courses_with_pending_attendance, // optimize
125 125
             'unassigned_events' => (new Event())->unassigned_teacher->count(),
126 126
             'upcoming_leaves' => Leave::upcoming_leaves(),
127 127
             'resources' => $teachers,
Please login to merge, or discard this patch.
app/Http/Controllers/Auth/RegisterController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
             'profession'                           => 'required',
54 54
             'institution'                          => 'required',
55 55
             'userPicture'                          => 'required',
56
-            function ($attribute, $value, $fail) {
56
+            function($attribute, $value, $fail) {
57 57
                 $size = strlen(base64_decode($value));
58 58
 
59 59
                 if ($size > 3145728) {
@@ -62,13 +62,13 @@  discard block
 block discarded – undo
62 62
 
63 63
                 $img = imagecreatefromstring($value);
64 64
 
65
-                if (! $img) {
65
+                if (!$img) {
66 66
                     $fail($attribute.'Invalid image');
67 67
                 }
68 68
 
69 69
                 $size = getimagesizefromstring($value);
70 70
 
71
-                if (! $size || ($size[0] == 0) || ($size[1] == 0) || ! $size['mime']) {
71
+                if (!$size || ($size[0] == 0) || ($size[1] == 0) || !$size['mime']) {
72 72
                     $fail($attribute.'is invalid');
73 73
                 }
74 74
             },
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
     {
122 122
 
123 123
         // if registration is closed, deny access
124
-        if (! config('backpack.base.registration_open')) {
124
+        if (!config('backpack.base.registration_open')) {
125 125
             abort(403, trans('backpack::base.registration_closed'));
126 126
         }
127 127
 
Please login to merge, or discard this patch.
app/Console/Kernel.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,12 +29,12 @@
 block discarded – undo
29 29
      */
30 30
     protected function schedule(Schedule $schedule)
31 31
     {
32
-        $schedule->call(function () {
32
+        $schedule->call(function() {
33 33
             Log::info('Sending attendance reminders');
34 34
             (new Attendance())->remindPendingAttendance();
35 35
         })->dailyAt('08:15');
36 36
 
37
-        $schedule->call(function () {
37
+        $schedule->call(function() {
38 38
             Log::info('Checking default periods');
39 39
 
40 40
             // when we finish the current period; remove the manual override to automatically fallbackto the next one
Please login to merge, or discard this patch.
app/Models/Event.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
         parent::boot();
19 19
 
20 20
         // before adding an event, we check that the teacher is available
21
-        static::saving(function ($event) {
21
+        static::saving(function($event) {
22 22
             $teacher = Teacher::find($event->teacher_id);
23 23
             // if the teacher is on leave on the day of the event
24 24
             if (($event->teacher_id !== null) && $teacher->leaves->contains('date', Carbon::parse($event->start)->toDateString())) {
Please login to merge, or discard this patch.
app/Models/Enrollment.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
         parent::boot();
28 28
 
29 29
         // when creating a new enrollment, also add past attendance
30
-        static::created(function (self $enrollment) {
30
+        static::created(function(self $enrollment) {
31 31
             $events = $enrollment->course->events->where('start', '<', (new Carbon())->toDateString());
32 32
             foreach ($events as $event) {
33 33
                 $event->attendance()->create([
@@ -58,11 +58,11 @@  discard block
 block discarded – undo
58 58
     public function scopeWithoutChildren($query)
59 59
     {
60 60
         return $query
61
-            ->where(function ($query) {
61
+            ->where(function($query) {
62 62
                 $query->whereDoesntHave('childrenEnrollments')
63 63
                 ->where('parent_id', null);
64 64
             })
65
-            ->orWhere(function ($query) {
65
+            ->orWhere(function($query) {
66 66
                 $query->where('parent_id', null);
67 67
             })
68 68
             ->get();
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
     public function scopePeriod(Builder $query, $period)
86 86
     {
87
-        return $query->whereHas('course', function ($q) use ($period) {
87
+        return $query->whereHas('course', function($q) use ($period) {
88 88
             $q->where('period_id', $period);
89 89
         });
90 90
     }
@@ -293,13 +293,13 @@  discard block
 block discarded – undo
293 293
 
294 294
         // delete attendance records related to the enrollment
295 295
         $attendances = $this->course->attendance->where('student_id', $this->student->id);
296
-        Attendance::destroy($attendances->map(function ($item, $key) {
296
+        Attendance::destroy($attendances->map(function($item, $key) {
297 297
             return $item->id;
298 298
         }));
299 299
 
300 300
         foreach ($this->course->children as $child) {
301 301
             $attendances = $child->attendance->where('student_id', $this->student->id);
302
-            Attendance::destroy($attendances->map(function ($item, $key) {
302
+            Attendance::destroy($attendances->map(function($item, $key) {
303 303
                 return $item->id;
304 304
             }));
305 305
         }
Please login to merge, or discard this patch.