academico-sis / academico

app/Models/Attendance.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
         parent::boot();
 
         // when an attendance record is added, we check if this is an absence
-        static::saved(function (self $attendance) {
+        static::saved(function(self $attendance) {
             if ($attendance->attendance_type_id == 4) { // todo move to configurable settings
                 // Log::info('Absence marked for student '.$attendance->student->name);
                 // will check the record again and send a notification if it hasn't changed

app/Models/Course.php

Spacing +9 added lines, -9 removed lines

@@ -309,7 +309,7 @@ 
      */
     public function skills()
     {
-        return $this->evaluationType?->skills()->orderBy('order');
+        return $this->evaluationType ? ->skills()->orderBy('order');
     }
 
     public function books()
@@ -334,7 +334,7 @@ 
      */
     public function getPendingAttendanceAttribute()
     {
-        $events = Event::where(function ($query) {
+        $events = Event::where(function($query) {
             $query->where('course_id', $this->id);
             $query->where('exempt_attendance', '!=', true);
             $query->where('exempt_attendance', '!=', 1);
@@ -471,7 +471,7 @@ 
             foreach ($courseTimes as $courseTime) {
                 $initial = $daysInitials[$courseTime->day];
 
-                if (! isset($parsedCourseTimes[$initial])) {
+                if (!isset($parsedCourseTimes[$initial])) {
                     $parsedCourseTimes[$initial] = [];
                 }
 
@@ -518,7 +518,7 @@ 
     public function getCourseTeacherNameAttribute()
     {
         if ($this->teacher_id) {
-            return $this->teacher?->name;
+            return $this->teacher ? ->name;
         } else {
             return '-';
         }
@@ -531,7 +531,7 @@ 
 
     public function getDescriptionAttribute()
     {
-        return '[' . $this->course_period_name . '] - ' . $this->name;
+        return '['.$this->course_period_name.'] - '.$this->name;
     }
 
     public function getChildrenCountAttribute()
@@ -552,7 +552,7 @@ 
 
     public function getAcceptsNewStudentsAttribute(): bool
     {
-        if (! $this->spots || $this->spots == 0) {
+        if (!$this->spots || $this->spots == 0) {
             return true;
         }
 
@@ -575,7 +575,7 @@ 
 
     public function eventsWithExpectedAttendance()
     {
-        return $this->events()->where(function ($query) {
+        return $this->events()->where(function($query) {
             $query->where('exempt_attendance', '!=', true);
             $query->where('exempt_attendance', '!=', 1);
             $query->orWhereNull('exempt_attendance');
@@ -604,10 +604,10 @@ 
     {
         if (config('app.currency_position') === 'before')
         {
-            return config('app.currency_symbol') . " ". $this->price;
+            return config('app.currency_symbol')." ".$this->price;
         }
 
-        return $this->price . " " . config('app.currency_symbol');
+        return $this->price." ".config('app.currency_symbol');
     }
 
 

app/Models/Skills/Skill.php

Spacing +1 added lines, -1 removed lines

@@ -74,6 +74,6 @@
 
     public function getCompleteNameAttribute() : string
     {
-        return '[' . ($this->level->name ?? '') . '] ' . ($this->skill_type->shortname ?? '') . ' - ' . $this->name ?? '';
+        return '['.($this->level->name ?? '').'] '.($this->skill_type->shortname ?? '').' - '.$this->name ?? '';
     }
 }

app/Models/Policies/StudentPolicy.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     {
         // if the student is enrolled in any class by the user
 
-        return $student->enrollments()->whereHas('course', function ($q) use ($user) {
+        return $student->enrollments()->whereHas('course', function($q) use ($user) {
             return $q->where('teacher_id', $user->id);
         })->count() > 0;
     }

app/Models/Book.php

Spacing +2 added lines, -2 removed lines

@@ -73,10 +73,10 @@
     {
         if (config('app.currency_position') === 'before')
         {
-            return config('app.currency_symbol') . " ". $this->price;
+            return config('app.currency_symbol')." ".$this->price;
         }
 
-        return $this->price . " " . config('app.currency_symbol');
+        return $this->price." ".config('app.currency_symbol');
     }
 
     public function getTypeAttribute()

app/Models/GradeType.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     public function getCompleteNameAttribute()
     {
         if ($this->category) {
-            return '[' . $this->category->name . '] ' . $this->name;
+            return '['.$this->category->name.'] '.$this->name;
         }
 
         return null;

app/Models/Enrollment.php

Spacing +8 added lines, -8 removed lines

@@ -121,11 +121,11 @@ 
     public function scopeWithoutChildren($query)
     {
         return $query
-            ->where(function ($query) {
+            ->where(function($query) {
                 $query->whereDoesntHave('childrenEnrollments')
                 ->where('parent_id', null);
             })
-            ->orWhere(function ($query) {
+            ->orWhere(function($query) {
                 $query->where('parent_id', null);
             })
             ->get();
@@ -147,7 +147,7 @@ 
 
     public function scopePeriod(Builder $query, $period)
     {
-        return $query->whereHas('course', function ($q) use ($period) {
+        return $query->whereHas('course', function($q) use ($period) {
             $q->where('period_id', $period);
         });
     }
@@ -294,7 +294,7 @@ 
 
     public function getNameAttribute()
     {
-        return __("Enrollment for") . ' ' . $this->student_name;
+        return __("Enrollment for").' '.$this->student_name;
     }
 
     public function getTypeAttribute()
@@ -380,10 +380,10 @@ 
     {
         if (config('app.currency_position') === 'before')
         {
-            return config('app.currency_symbol') . " ". $this->price;
+            return config('app.currency_symbol')." ".$this->price;
         }
 
-        return $this->price . " " . config('app.currency_symbol');
+        return $this->price." ".config('app.currency_symbol');
     }
 
     public function cancel()
@@ -397,13 +397,13 @@ 
 
         // delete attendance records related to the enrollment
         $attendances = $this->course->attendance->where('student_id', $this->student->id);
-        Attendance::destroy($attendances->map(function ($item, $key) {
+        Attendance::destroy($attendances->map(function($item, $key) {
             return $item->id;
         }));
 
         foreach ($this->course->children as $child) {
             $attendances = $child->attendance->where('student_id', $this->student->id);
-            Attendance::destroy($attendances->map(function ($item, $key) {
+            Attendance::destroy($attendances->map(function($item, $key) {
                 return $item->id;
             }));
         }

app/Models/Student.php

Spacing +14 added lines, -14 removed lines

@@ -144,9 +144,9 @@ 
 
     public function scopeComputedLeadType($query, $leadTypeId)
     {
-        return match ($leadTypeId) {
-            1 => $query->whereHas('enrollments', function ($query) {
-                return $query->whereHas('course', function ($q) {
+        return match($leadTypeId) {
+            1 => $query->whereHas('enrollments', function($query) {
+                return $query->whereHas('course', function($q) {
                     $q->where('period_id', Period::get_default_period()->id);
                 });
             }),
@@ -155,18 +155,18 @@ 
 
             4 => $query
                 ->where('lead_type_id', $leadTypeId)
-                ->orWhere(function ($query) {
+                ->orWhere(function($query) {
                     $query
                         ->whereNull('lead_type_id')
-                        ->whereHas('enrollments', function ($query) {
+                        ->whereHas('enrollments', function($query) {
                             return $query
-                                ->whereHas('course', function ($q) {
+                                ->whereHas('course', function($q) {
                                     $q->where('period_id', '!=', Period::get_default_period()->id);
                                 });
                         })
-                        ->whereDoesntHave('enrollments', function ($query) {
+                        ->whereDoesntHave('enrollments', function($query) {
                             return $query
-                                ->whereHas('course', function ($q) {
+                                ->whereHas('course', function($q) {
                                     $q->where('period_id', Period::get_default_period()->id);
                                 });
                         });
@@ -202,8 +202,8 @@ 
 
         return $this->hasMany(Attendance::class)
         ->where('attendance_type_id', 4) // absence
-        ->whereHas('event', function ($q) use ($period) {
-            return $q->whereHas('course', function ($c) use ($period) {
+        ->whereHas('event', function($q) use ($period) {
+            return $q->whereHas('course', function($c) use ($period) {
                 return $c->where('period_id', $period->id);
             });
         });
@@ -216,8 +216,8 @@ 
         }
 
         return $this->hasMany(Attendance::class)
-        ->whereHas('event', function ($q) use ($period) {
-            return $q->whereHas('course', function ($c) use ($period) {
+        ->whereHas('event', function($q) use ($period) {
+            return $q->whereHas('course', function($c) use ($period) {
                 return $c->where('period_id', $period->id);
             });
         });
@@ -300,7 +300,7 @@ 
     public function getNameAttribute(): string
     {
         if ($this->user) {
-            return ($this->title ? ($this->title->title . ' ') : '') . $this->firstname.' '.$this->lastname;
+            return ($this->title ? ($this->title->title.' ') : '').$this->firstname.' '.$this->lastname;
         }
         return '';
     }
@@ -318,7 +318,7 @@ 
     public function getIsEnrolledAttribute()
     {
         // if the student is currently enrolled
-        if ($this->enrollments()->whereHas('course', function ($q) {
+        if ($this->enrollments()->whereHas('course', function($q) {
             return $q->where('period_id', Period::get_default_period()->id);
         })->count() > 0) {
             return 1;

app/Models/Teacher.php

Spacing +7 added lines, -7 removed lines

@@ -70,22 +70,22 @@ 
     /** attributes */
     public function getFirstnameAttribute() : ?string
     {
-        return $this?->user?->firstname;
+        return $this ? ->user ? ->firstname;
     }
 
     public function getLastnameAttribute() : ?string
     {
-        return $this?->user?->lastname;
+        return $this ? ->user ? ->lastname;
     }
 
     public function getEmailAttribute() : ?string
     {
-        return $this?->user?->email ?? "";
+        return $this ? ->user ? ->email ?? "";
     }
 
     public function getNameAttribute() : ?string
     {
-        return $this?->user?->firstname.' '.$this?->user?->lastname;
+        return $this ? ->user ? ->firstname.' '.$this ? ->user ? ->lastname;
     }
 
     public function period_courses(Period $period)
@@ -212,15 +212,15 @@ 
         $eventsWithMissingAttendance = [];
 
         $eventsWithExpectedAttendance = $this->events()
-        ->where(function ($query) {
+        ->where(function($query) {
             $query->where('exempt_attendance', '!=', true);
             $query->where('exempt_attendance', '!=', 1);
             $query->orWhereNull('exempt_attendance');
         })
         ->where('course_id', '!=', null)
-        ->whereHas('course', function (Builder $query) use ($period) {
+        ->whereHas('course', function(Builder $query) use ($period) {
             return $query->where('period_id', $period->id)
-                ->where(function ($query) {
+                ->where(function($query) {
                     $query->where('exempt_attendance', '!=', true);
                     $query->where('exempt_attendance', '!=', 1);
                     $query->orWhereNull('exempt_attendance');