Passed
Push — master ( b783c0...b2f78d )
by Thomas
08:02
created
app/Console/Commands/genderizeStudents.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
     protected $description = 'Guess gender for existing students, based on their firstname';
14 14
 
15 15
     // wordpress implementation, from https://github.com/WordPress/WordPress/blob/a2693fd8602e3263b5925b9d799ddd577202167d/wp-includes/formatting.php#L1528
16
-    private function remove_accents( $string ) {
16
+    private function remove_accents($string) {
17 17
 
18 18
 		$chars = array(
19 19
 		// Decompositions for Latin-1 Supplement
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 		'À' => 'A', 'Á' => 'A',
22 22
 		'Â' => 'A', 'Ã' => 'A',
23 23
 		'Ä' => 'A', 'Å' => 'A',
24
-		'Æ' => 'AE','Ç' => 'C',
24
+		'Æ' => 'AE', 'Ç' => 'C',
25 25
 		'È' => 'E', 'É' => 'E',
26 26
 		'Ê' => 'E', 'Ë' => 'E',
27 27
 		'Ì' => 'I', 'Í' => 'I',
@@ -32,11 +32,11 @@  discard block
 block discarded – undo
32 32
 		'Ö' => 'O', 'Ù' => 'U',
33 33
 		'Ú' => 'U', 'Û' => 'U',
34 34
 		'Ü' => 'U', 'Ý' => 'Y',
35
-		'Þ' => 'TH','ß' => 's',
35
+		'Þ' => 'TH', 'ß' => 's',
36 36
 		'à' => 'a', 'á' => 'a',
37 37
 		'â' => 'a', 'ã' => 'a',
38 38
 		'ä' => 'a', 'å' => 'a',
39
-		'æ' => 'ae','ç' => 'c',
39
+		'æ' => 'ae', 'ç' => 'c',
40 40
 		'è' => 'e', 'é' => 'e',
41 41
 		'ê' => 'e', 'ë' => 'e',
42 42
 		'ì' => 'i', 'í' => 'i',
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 		'Ĭ' => 'I', 'ĭ' => 'i',
76 76
 		'Į' => 'I', 'į' => 'i',
77 77
 		'İ' => 'I', 'ı' => 'i',
78
-		'IJ' => 'IJ','ij' => 'ij',
78
+		'IJ' => 'IJ', 'ij' => 'ij',
79 79
 		'Ĵ' => 'J', 'ĵ' => 'j',
80 80
 		'Ķ' => 'K', 'ķ' => 'k',
81 81
 		'ĸ' => 'k', 'Ĺ' => 'L',
@@ -91,13 +91,13 @@  discard block
 block discarded – undo
91 91
 		'Ō' => 'O', 'ō' => 'o',
92 92
 		'Ŏ' => 'O', 'ŏ' => 'o',
93 93
 		'Ő' => 'O', 'ő' => 'o',
94
-		'Œ' => 'OE','œ' => 'oe',
95
-		'Ŕ' => 'R','ŕ' => 'r',
96
-		'Ŗ' => 'R','ŗ' => 'r',
97
-		'Ř' => 'R','ř' => 'r',
98
-		'Ś' => 'S','ś' => 's',
99
-		'Ŝ' => 'S','ŝ' => 's',
100
-		'Ş' => 'S','ş' => 's',
94
+		'Œ' => 'OE', 'œ' => 'oe',
95
+		'Ŕ' => 'R', 'ŕ' => 'r',
96
+		'Ŗ' => 'R', 'ŗ' => 'r',
97
+		'Ř' => 'R', 'ř' => 'r',
98
+		'Ś' => 'S', 'ś' => 's',
99
+		'Ŝ' => 'S', 'ŝ' => 's',
100
+		'Ş' => 'S', 'ş' => 's',
101 101
 		'Š' => 'S', 'š' => 's',
102 102
 		'Ţ' => 'T', 'ţ' => 't',
103 103
 		'Ť' => 'T', 'ť' => 't',
@@ -197,10 +197,10 @@  discard block
 block discarded – undo
197 197
 
198 198
     public function handle()
199 199
     {
200
-        Student::whereNull('gender_id')->chunkById(10, function ($students) {
200
+        Student::whereNull('gender_id')->chunkById(10, function($students) {
201 201
             $query = $students->map(fn($student) => ['id' => $student->id, 'name' => $this->remove_accents(strtok($student->firstname, " "))]);
202 202
 
203
-            $response = Http::get('https://api.genderize.io/?name[]=' . $query->pluck('name')->implode('&name[]='));
203
+            $response = Http::get('https://api.genderize.io/?name[]='.$query->pluck('name')->implode('&name[]='));
204 204
             foreach ($students as $student) {
205 205
                 $firstname = $query->firstWhere('id', $student->id)['name'];
206 206
 
Please login to merge, or discard this patch.
app/Models/Period.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     {
25 25
         parent::boot();
26 26
 
27
-        static::addGlobalScope('order', function (Builder $builder) {
27
+        static::addGlobalScope('order', function(Builder $builder) {
28 28
             $builder->orderBy('year_id')->orderBy('order')->orderBy('id');
29 29
         });
30 30
     }
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 
135 135
     public function studentCount($gender = null)
136 136
     {
137
-        if (in_array($gender, [1,2])) {
137
+        if (in_array($gender, [1, 2])) {
138 138
             return DB::table('enrollments')
139 139
                 ->join('courses', 'enrollments.course_id', 'courses.id')
140 140
                 ->join('students', 'enrollments.student_id', 'students.id')
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     {
202 202
         $period = self::where('id', '<', $this->id)->orderBy('id', 'desc')->first();
203 203
 
204
-        if (! $period == null) {
204
+        if (!$period == null) {
205 205
             return $period;
206 206
         } else {
207 207
             return self::first();
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
     public function getCoursesWithPendingAttendanceAttribute()
282 282
     {
283 283
         // get all courses for period and preload relations
284
-        $courses = $this->courses()->where(function ($query) {
284
+        $courses = $this->courses()->where(function($query) {
285 285
             $query->where('exempt_attendance', '!=', true);
286 286
             $query->where('exempt_attendance', '!=', 1);
287 287
             $query->orWhereNull('exempt_attendance');
Please login to merge, or discard this patch.
app/Models/Year.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
     public function studentCount($gender = null)
28 28
     {
29
-        if (in_array($gender, [1,2])) {
29
+        if (in_array($gender, [1, 2])) {
30 30
             return DB::table('enrollments')
31 31
                 ->join('courses', 'enrollments.course_id', 'courses.id')
32 32
                 ->join('periods', 'courses.period_id', 'periods.id')
Please login to merge, or discard this patch.
app/Http/Controllers/ReportController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
         $year_data = [];
64 64
         $years = []; // New array
65 65
 
66
-        if (! isset($request->period)) {
66
+        if (!isset($request->period)) {
67 67
             $startperiod = Period::find(Config::where('name', 'first_external_period')->first()->value ?? Period::first()->id);
68 68
         } else {
69 69
             $startperiod = Period::find($request->period);
Please login to merge, or discard this patch.
app/Http/Controllers/TeacherCalendarController.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $events = Event::with('course')
26 26
             ->where('start', '>', Carbon::now()->subDays(30))->where('end', '<', Carbon::now()->addDays(30))->orderBy('id', 'desc') // TODO optimize this.
27 27
             ->get()
28
-            ->map(fn ($event) => [
28
+            ->map(fn($event) => [
29 29
                 'title' => $event->name ?? '',
30 30
                 'resourceId' => $event->teacher_id,
31 31
                 'start' => $event->start,
@@ -37,14 +37,14 @@  discard block
 block discarded – undo
37 37
 
38 38
         $teachers = Teacher::all()->toArray();
39 39
 
40
-        $teachers = array_map(fn ($teacher) => [
40
+        $teachers = array_map(fn($teacher) => [
41 41
             'id' => $teacher['id'],
42 42
             'title' => $teacher['name'] ?? '',
43 43
         ], $teachers);
44 44
 
45 45
         array_push($teachers, ['id' => 'tbd', 'title' => 'Unassigned']);
46 46
 
47
-        $unassigned_events = Event::unassigned()->get()->map(fn ($event) => [
47
+        $unassigned_events = Event::unassigned()->get()->map(fn($event) => [
48 48
             'title' => $event->name ?? '',
49 49
             'resourceId' => 'tbd',
50 50
             'start' => $event->start,
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
             'borderColor' => $event->color,
55 55
         ]);
56 56
 
57
-        $leaves = Leave::orderBy('date', 'desc')->limit(10000)->get()->map(fn ($event) => [
57
+        $leaves = Leave::orderBy('date', 'desc')->limit(10000)->get()->map(fn($event) => [
58 58
             'title' => $event->leaveType->name ?? 'ABS', // todo fix
59 59
             'resourceId' => $event['teacher_id'],
60 60
             'start' => $event['date'],
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
             abort(403);
81 81
         }
82 82
 
83
-        $events = $teacher->events->map(fn ($event) => [
83
+        $events = $teacher->events->map(fn($event) => [
84 84
             'title' => $event['name'],
85 85
             'start' => $event['start'],
86 86
             'end' => $event['end'],
@@ -88,8 +88,8 @@  discard block
 block discarded – undo
88 88
             'borderColor' => $event['color'],
89 89
         ]);
90 90
 
91
-        $leaves = $teacher->leaves->map(fn ($event) => [
92
-            'title' => $event->leaveType->name ?? 'vacances',  // todo fix
91
+        $leaves = $teacher->leaves->map(fn($event) => [
92
+            'title' => $event->leaveType->name ?? 'vacances', // todo fix
93 93
             'start' => $event['date'],
94 94
             'allDay' => true,
95 95
         ]);
Please login to merge, or discard this patch.
app/Http/Controllers/RoomController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
             ->where('end', '<', Carbon::now()->addDays(90))
26 26
             ->orderBy('id', 'desc')
27 27
             ->get()
28
-            ->map(fn ($event) => [
28
+            ->map(fn($event) => [
29 29
                 'title' => $event->name,
30 30
                 'resourceId' => $event->room_id,
31 31
                 'start' => $event->start,
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
         $rooms = Room::all()->toArray();
39 39
 
40
-        $rooms = array_map(fn ($room) => [
40
+        $rooms = array_map(fn($room) => [
41 41
             'id' => $room['id'],
42 42
             'title' => $room['name'],
43 43
         ], $rooms);
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $unassigned_events = Event::with('course')
48 48
             ->whereNull('room_id')
49 49
             ->get()
50
-            ->map(fn ($event) => [
50
+            ->map(fn($event) => [
51 51
                 'title' => $event->name,
52 52
                 'resourceId' => 'tbd',
53 53
                 'start' => $event->start,
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
     public function show(Room $room)
71 71
     {
72 72
         $events = $room->events->toArray();
73
-        $events = array_map(fn ($event) => [
73
+        $events = array_map(fn($event) => [
74 74
             'title' => $event['name'],
75 75
             'start' => $event['start'],
76 76
             'end' => $event['end'],
Please login to merge, or discard this patch.