academico-sis / academico

app/Http/Controllers/HRController.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
         $report_end_date = $request->report_end_date ? Carbon::parse($request->report_end_date) : Carbon::parse($period->end);
 
         // if we are dealing with a complete period, add theoretical volumes
-        if (! $request->report_start_date && ! $request->report_end_date) {
+        if (!$request->report_start_date && !$request->report_end_date) {
             // ensure the report end date is not before the end date to avoid inconsistent results.
             $report_end_date = $report_start_date->max($report_end_date);
 

app/Mail/ExternalCourseReport.php

Spacing +1 added lines, -1 removed lines

@@ -24,6 +24,6 @@
 
     public function build()
     {
-        return $this->subject('Facturation ' . $this->data['partner_name'])->view('emails.external_courses_report');
+        return $this->subject('Facturation '.$this->data['partner_name'])->view('emails.external_courses_report');
     }
 }

app/Listeners/SendExternalCoursesReport.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
         // foreach partner with an alert set for this day of month
         foreach (Partner::where('send_report_on', Carbon::now()->day)->get() as $partner) {
             // get all courses
-            $courses = $partner->courses()->whereHas('events', function (Builder $query) use ($period_start, $period_end) {
+            $courses = $partner->courses()->whereHas('events', function(Builder $query) use ($period_start, $period_end) {
                 $query->where('start', '>=', $period_start->toDateString())->where('end', '<=', $period_end->toDateString());
             })
             ->with('events')->withCount('events')

app/Providers/TelescopeServiceProvider.php

Spacing +2 added lines, -2 removed lines

@@ -20,7 +20,7 @@ 
 
         $this->hideSensitiveRequestDetails();
 
-        Telescope::filter(function (IncomingEntry $entry) {
+        Telescope::filter(function(IncomingEntry $entry) {
             if ($this->app->isLocal()) {
                 return true;
             }
@@ -61,7 +61,7 @@ 
      */
     protected function gate()
     {
-        Gate::define('viewTelescope', function ($user = null) {
+        Gate::define('viewTelescope', function($user = null) {
             return backpack_user() && backpack_user()->email === config('app.admin_email');
         });
     }

app/Services/Ecuasolutions.php

Braces +2 added lines, -4 removed lines

@@ -46,8 +46,7 @@ 
                     'preciototal' => $product->final_price,
                     'valoriva' => 0,
                 ];
-            }
-            elseif ($product->product instanceof Fee)
+            } elseif ($product->product instanceof Fee)
             {
                 $ivkardex[] = [
                     'codinventario' => $product->product_code,
@@ -58,8 +57,7 @@ 
                     'preciototal' => $product->final_price,
                     'valoriva' => 0,
                 ];
-            }
-            elseif ($product->product instanceof Book)
+            } elseif ($product->product instanceof Book)
             {
                 $ivkardex[] = [
                     'codinventario' => $product->product_code,

app/Services/ApolearnService.php

Indentation +3 added lines, -3 removed lines

@@ -27,9 +27,9 @@
     {
         Log::info('launching API');
         $response = Http::post(config('lms.apolearn.url') . '/auth.gettoken', [
-              'api_key' => $this->apiKey,
-              'username' => config('lms.apolearn.username'),
-              'password' => config('lms.apolearn.password'),
+                'api_key' => $this->apiKey,
+                'username' => config('lms.apolearn.username'),
+                'password' => config('lms.apolearn.password'),
         ]);
 
         return $response['result'] ?? "";

Spacing +18 added lines, -18 removed lines

@@ -26,7 +26,7 @@ 
     public function authenticate() : string
     {
         Log::info('launching API');
-        $response = Http::post(config('lms.apolearn.url') . '/auth.gettoken', [
+        $response = Http::post(config('lms.apolearn.url').'/auth.gettoken', [
               'api_key' => $this->apiKey,
               'username' => config('lms.apolearn.username'),
               'password' => config('lms.apolearn.password'),
@@ -37,9 +37,9 @@ 
 
     public function createUser(User $user, ?string $password = null) : void
     {
-        Log::info('checking if user exists for local ID ' . $user->id);
+        Log::info('checking if user exists for local ID '.$user->id);
         // first check if the user already exists (email)
-        $response = Http::get(config('lms.apolearn.url') . "/users/getbyemail/$user->email", [
+        $response = Http::get(config('lms.apolearn.url')."/users/getbyemail/$user->email", [
             'auth_token' => $this->token,
             'api_key' => $this->apiKey,
         ]);
@@ -63,7 +63,7 @@ 
                 $data = Arr::add($data, 'password', $password);
             }
 
-            $response = Http::post(config('lms.apolearn.url') . '/users', $data);
+            $response = Http::post(config('lms.apolearn.url').'/users', $data);
 
             if ($this->actionSucceeded($response)) {
                 $user->update(['lms_id' => $response->json()['result']['id']]);
@@ -91,7 +91,7 @@ 
                 $data = Arr::add($data, 'password', $password);
             }
 
-            $response = Http::put(config('lms.apolearn.url') . '/users/' . $user->lms_id, $data);
+            $response = Http::put(config('lms.apolearn.url').'/users/'.$user->lms_id, $data);
         }
     }
 
@@ -102,8 +102,8 @@ 
             abort(422, 'This course already exists on the remote platform');
         }
 
-        Log::info('pushing local course ' . $course->id . ' to API');
-        $response = Http::post(config('lms.apolearn.url') . '/classrooms', [
+        Log::info('pushing local course '.$course->id.' to API');
+        $response = Http::post(config('lms.apolearn.url').'/classrooms', [
             "name" => $course->name,
             "shortname" => $course->shortname,
             "description" => $course->description,
@@ -121,7 +121,7 @@ 
         $course->update(['lms_id' => $courseId]);
 
         // assign an admin to the new class
-        $response = Http::post(config('lms.apolearn.url') . "/classrooms/addadmin/$courseId", [
+        $response = Http::post(config('lms.apolearn.url')."/classrooms/addadmin/$courseId", [
             'user_id' => config('lms.apolearn.admin_user_id'),
             'auth_token' => $this->token,
             'api_key' => $this->apiKey,
@@ -137,8 +137,8 @@ 
             $this->createCourse($course);
         }
 
-        Log::info('updating course with locale ID' . $course->id);
-        $response = Http::put(config('lms.apolearn.url') . "/classrooms/$course->lms_id", [
+        Log::info('updating course with locale ID'.$course->id);
+        $response = Http::put(config('lms.apolearn.url')."/classrooms/$course->lms_id", [
             "name" => $course->name,
             "shortname" => $course->shortname,
             "description" => $course->description,
@@ -153,14 +153,14 @@ 
 
         Log::info('updating the course teacher');
         // ensure the teacher is up to date
-        $response = Http::get(config('lms.apolearn.url') . "/classrooms/teachers/$course->lms_id", [
+        $response = Http::get(config('lms.apolearn.url')."/classrooms/teachers/$course->lms_id", [
             'auth_token' => $this->token,
             'api_key' => $this->apiKey,
         ]);
 
         if ($this->actionSucceeded($response)) {
             $teachers = collect($response->json()['result']['users']);
-            Log::info('found these teachers IDs on LMS:' . implode(', ', $teachers->pluck('id')->toArray()));
+            Log::info('found these teachers IDs on LMS:'.implode(', ', $teachers->pluck('id')->toArray()));
 
             // if the course has no teacher, stop
             if (!$course->teacher) {
@@ -171,9 +171,9 @@ 
             } else {
                 // check if remote course teachers are still valid
                 foreach ($teachers as $teacher) {
-                    Log::info('comparing ' . $teacher['id'] . ' and ' . $course->teacher->user->lms_id);
+                    Log::info('comparing '.$teacher['id'].' and '.$course->teacher->user->lms_id);
                     if ($teacher['id'] !== $course->teacher->user->lms_id) {
-                        Log::info('Removing teacher ' . $teacher['id'] . ' from course');
+                        Log::info('Removing teacher '.$teacher['id'].' from course');
                         $this->removeTeacher($course->lms_id, $teacher['id']);
                     }
                 }
@@ -199,7 +199,7 @@ 
             $this->createUser($student->user);
         }
 
-        $response = Http::post(config('lms.apolearn.url') . "/classrooms/addstudent/$courseId", [
+        $response = Http::post(config('lms.apolearn.url')."/classrooms/addstudent/$courseId", [
             'user_id' => $student->user->lms_id,
             'auth_token' => $this->token,
             'api_key' => $this->apiKey,
@@ -219,7 +219,7 @@ 
         if ($course->teacher_id)
         {
             // if the teacher doesn't exist on LMS, create them
-            if (! $course->teacher->user->lms_id) {
+            if (!$course->teacher->user->lms_id) {
                 Log::info('creating user now');
                 $this->createUser($course->teacher->user);
             }
@@ -236,7 +236,7 @@ 
 
     protected function removeTeacher($courseId, $teacherId): void
     {
-        Log::info('Removing teacher ' . $teacherId . ' from course ' . $courseId);
+        Log::info('Removing teacher '.$teacherId.' from course '.$courseId);
         $response = Http::put(config('lms.apolearn.url')."/classrooms/removeteacher/$courseId", [
             'user_id' => $teacherId,
             'auth_token' => $this->token,
@@ -249,7 +249,7 @@ 
 
     public function removeStudent($courseId, $userId): void
     {
-        Log::info('removing user id ' . $userId . ' from course ' . $courseId);
+        Log::info('removing user id '.$userId.' from course '.$courseId);
         $response = Http::put(config('lms.apolearn.url')."/classrooms/removestudent/$courseId", [
             'user_id' => $userId,
             'auth_token' => $this->token,

app/Services/MailerliteService.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
         $subscriberGroups = $this->subscribersApi->getGroups($email); // returns array of group objects subscriber belongs to
 
         foreach ($subscriberGroups as $group) {
-            $groupId = $array = json_decode(json_encode($group),true);
+            $groupId = $array = json_decode(json_encode($group), true);
             $this->groupsApi->removeSubscriber($groupId['id'], $email); // returns empty response
         }
 

app/Console/Kernel.php

Spacing +7 added lines, -7 removed lines

@@ -34,12 +34,12 @@ 
      */
     protected function schedule(Schedule $schedule)
     {
-        $schedule->call(function () {
+        $schedule->call(function() {
             Log::info('Sending attendance reminders');
             $this->remindPendingAttendance();
         })->dailyAt('08:15');
 
-        $schedule->call(function () {
+        $schedule->call(function() {
             Log::info('Checking default periods');
 
             // when we finish the current period; remove the manual override to automatically fallbackto the next one
@@ -57,14 +57,14 @@ 
         })->dailyAt('00:00');
 
         if (config('settings.partnership_alerts')) {
-            $schedule->call(function () {
+            $schedule->call(function() {
                 Log::info('Checking expired partnerships');
 
                 // if one of the partnerships is expiring soon, send an email
-                $partners = Partner::where(function ($query) {
+                $partners = Partner::where(function($query) {
                     $query->whereNotNull('expired_on')->where('expired_on', '<', Carbon::now()->addDays(28));
                 })
-                    ->where(function ($query) {
+                    ->where(function($query) {
                         $query->whereNull('last_alert_sent_at')->orWhere('last_alert_sent_at', '>', Carbon::now()->subDays(28))->get();
                     });
 
@@ -75,14 +75,14 @@ 
         }
 
         if (config('settings.external_courses_report')) {
-            $schedule->call(function () {
+            $schedule->call(function() {
                 Log::info('Sending external courses reports');
                 event(new ExternalCoursesReportEvent());
             })->dailyAt('02:10');
         }
 
         if (config('settings.monthly_report')) {
-            $schedule->call(function () {
+            $schedule->call(function() {
                 Log::info('Sending monthly hours report');
                 event(new MonthlyReportEvent());
             })->monthlyOn(20);

app/Console/Commands/migrateGrades.php

Spacing +5 added lines, -5 removed lines

@@ -45,14 +45,14 @@ 
             $course = Course::find($entry->course_id);
             $matchFound = false;
 
-            echo "\nMigrating grades from course " . $course->id;
+            echo "\nMigrating grades from course ".$course->id;
 
             // collect all grade types associated to this course.
             $courseGradeTypes = DB::table('course_grade_type')->where('course_id', $entry->course_id)->pluck('grade_type_id');
             // if this configuration matches an evaluation type, use it, otherwise create it
             foreach (EvaluationType::has('gradeTypes')->get() as $evaluationType) {
                 if ($courseGradeTypes->diff($evaluationType->gradeTypes->pluck('id'))->count() == 0) {
-                    echo "match with eval type " . $evaluationType->id;
+                    echo "match with eval type ".$evaluationType->id;
                     $course->update(['evaluation_type_id' => $evaluationType->id]);
                     $matchFound = true;
                 }
@@ -61,7 +61,7 @@ 
             // if no match has been found
             if (!$matchFound) {
                 echo "no match; creating new eval type";
-                $evalType = EvaluationType::create(['name' => 'cours ' . $entry->course_id]);
+                $evalType = EvaluationType::create(['name' => 'cours '.$entry->course_id]);
                 $evalType->gradeTypes()->sync($courseGradeTypes);
             }
 
@@ -74,7 +74,7 @@ 
             $course = Course::find($entry->course_id);
             $matchFound = false;
 
-            echo "\nMigrating skills from course " . $course->id;
+            echo "\nMigrating skills from course ".$course->id;
 
             // collect all grade types associated to this course.
             $courseSkills = DB::table('course_skill')->where('course_id', $entry->course_id)->pluck('skill_id');
@@ -90,7 +90,7 @@ 
             // if no match has been found
             if (!$matchFound) {
                 $levelName = isset($course->level) ? $course->level->name : $course->id; 
-                $evalType = EvaluationType::create(['name' => 'Niveau ' . $levelName]);
+                $evalType = EvaluationType::create(['name' => 'Niveau '.$levelName]);
                 $evalType->skills()->sync($courseSkills);
             }
         }