App\Models\Student

Complexity

Total Complexity

47

Size/Duplication

Total Lines	295
Duplicated Lines	0 %

Importance

Changes	8
Bugs	3	Features	0

31 Methods

Rating	Name	Duplication	Size	Complexity
A	enrollments()	0	4	1
A	scopeNewInPeriod()	0	3	1
A	attendance()	0	3	1
A	comments()	0	3	1
A	scopeComputedLeadType()	0	26	1
A	periodAbsences()	0	9	2
A	registerMediaConversions()	0	5	1
A	contacts()	0	3	1
A	user()	0	3	1
A	periodAttendance()	0	8	2
A	phone()	0	3	1
A	leadType()	0	3	1
A	scopeEnrolled()	0	5	1
A	institution()	0	3	1
A	getLastnameAttribute()	0	7	2
A	setEmailAttribute()	0	3	1
A	getFirstnameAttribute()	0	3	2
A	getEmailAttribute()	0	3	1
A	getNameAttribute()	0	3	2
A	profession()	0	3	1
A	getIsEnrolledAttribute()	0	8	2
A	getLeadStatusNameAttribute()	0	3	1
A	setFirstnameAttribute()	0	3	1
A	getStudentAgeAttribute()	0	3	2
A	lead_status()	0	19	4
A	setLastnameAttribute()	0	3	1
A	getStudentBirthdateAttribute()	0	3	2
A	enroll()	0	36	4
A	books()	0	3	1
A	setImageAttribute()	0	13	3
A	getImageAttribute()	0	3	1

<?php

namespace App\Models;

use App\Events\LeadStatusUpdatedEvent;
use App\Events\StudentDeleting;
use App\Events\StudentUpdated;
use Backpack\CRUD\app\Models\Traits\CrudTrait;
use Carbon\Carbon;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\App;
use Illuminate\Support\Str;
use Spatie\Activitylog\Traits\LogsActivity;
use Spatie\Image\Manipulations;
use Spatie\MediaLibrary\HasMedia;
use Spatie\MediaLibrary\InteractsWithMedia;
use Spatie\MediaLibrary\MediaCollections\Models\Media;

class Student extends Model implements HasMedia
{
    use CrudTrait;

The trait Backpack\CRUD\app\Models\Traits\CrudTrait requires some properties which are not provided by App\Models\Student: $fakeColumns, $identifiableAttribute, $Type

    use InteractsWithMedia;

The trait Spatie\MediaLibrary\InteractsWithMedia requires some properties which are not provided by App\Models\Student: $fallbackPath, $mediaConversionRegistrations, $forceDeleting, $fallbackUrl, $media, $collection_name

    use LogsActivity;

    protected $dispatchesEvents = [
        'deleting' => StudentDeleting::class,
        'updated' => StudentUpdated::class,
    ];

    public $timestamps = true;

    protected $guarded = [];

    public $incrementing = false;

    protected $with = ['user', 'phone', 'institution', 'profession'];

    protected $appends = ['email', 'name', 'firstname', 'lastname', 'student_age', 'student_birthdate', 'is_enrolled'];

    protected static bool $logUnguarded = true;

    public function scopeEnrolled($query)
    {
        return $query->whereHas('enrollments', function ($q) {
            return $q->whereHas('course', function ($q) {
                return $q->where('period_id', Period::get_default_period()->id);
            });
        });
    }

    public function scopeComputedLeadType($query, $leadTypeId)
    {
        return match ($leadTypeId) {
            1 => $query->whereHas('enrollments', fn ($query) => $query->whereHas('course', function ($q) {
                $q->where('period_id', Period::get_default_period()->id);
            })),

            2, 3 => $query->where('lead_type_id', $leadTypeId),

            4 => $query
                ->where('lead_type_id', $leadTypeId)
                ->orWhere(function ($query) {
                    $query
                        ->whereNull('lead_type_id')
                        ->whereHas('enrollments', fn ($query) => $query
                            ->whereHas('course', function ($q) {
                                $q->where('period_id', '!=', Period::get_default_period()->id);
                            }))
                        ->whereDoesntHave('enrollments', fn ($query) => $query
                            ->whereHas('course', function ($q) {
                                $q->where('period_id', Period::get_default_period()->id);
                            }));
                }
            ),

            default => $query,
        };
    }

    public function scopeNewInPeriod(Builder $query, int $periodId)
    {
        return $query->whereIn('id', Period::find($periodId)->newStudents()->pluck(['student_id'])->toArray());

array('student_id') of type array<integer,string> is incompatible with the type string expected by parameter $column of Illuminate\Database\Query\Builder::pluck().

array('student_id') of type array<integer,string> is incompatible with the type Illuminate\Database\Query\Expression|string expected by parameter $column of Illuminate\Database\Eloquent\Builder::pluck().

    }

    public function registerMediaConversions(Media $media = null): void
    {
        $this->addMediaConversion('thumb')
            ->fit(Manipulations::FIT_MAX, 1200, 1200)
            ->optimize();
    }

    /** relations */
    public function user()
    {
        return $this->belongsTo(User::class, 'id', 'id');
    }

    public function attendance()
    {
        return $this->hasMany(Attendance::class);
    }

    public function periodAbsences(Period $period = null)
    {
        if ($period == null) {
            $period = Period::get_default_period();
        }

        return $this->hasMany(Attendance::class)
        ->where('attendance_type_id', 4) // absence
        ->whereHas('event', fn ($q) => $q->whereHas('course', fn ($c) => $c->where('period_id', $period->id)));
    }

    public function periodAttendance(Period $period = null)
    {
        if ($period == null) {
            $period = Period::get_default_period();
        }

        return $this->hasMany(Attendance::class)
        ->whereHas('event', fn ($q) => $q->whereHas('course', fn ($c) => $c->where('period_id', $period->id)));
    }

    public function contacts()
    {
        return $this->hasMany(Contact::class, 'student_id');
    }

    public function comments()
    {
        return $this->morphMany(Comment::class, 'commentable');
    }

    public function phone()
    {
        return $this->morphMany(PhoneNumber::class, 'phoneable');
    }

    public function enrollments()
    {
        return $this->hasMany(Enrollment::class)
            ->with('course');
    }

    public function leadType()
    {
        return $this->belongsTo(LeadType::class);
    }

    public function institution()
    {
        return $this->belongsTo(Institution::class);
    }

    public function profession()
    {
        return $this->belongsTo(Profession::class);
    }

    public function books()
    {
        return $this->belongsToMany(Book::class)->withPivot('id', 'code', 'status_id', 'expiry_date');
    }

    /** attributes */
    public function getFirstnameAttribute(): string
    {
        return $this->user ? Str::title($this->user->firstname) : '';
    }

    public function getLastnameAttribute(): string
    {
        if ($this->user) {
            return Str::upper($this->user->lastname);
        }

        return '';
    }

    public function getEmailAttribute(): ?string
    {
        return $this?->user?->email;
    }

    public function getNameAttribute(): string
    {
        return $this->user ? "{$this->firstname} {$this->lastname}" : '';
    }

    public function getStudentAgeAttribute()
    {
        return $this->birthdate ? Carbon::parse($this->birthdate)->age . ' ' . __('years old') : '';

Are you sure __('years old') of type array|string can be used in concatenation?

    }

    public function getStudentBirthdateAttribute()
    {
        return $this->birthdate ? Carbon::parse($this->birthdate)->locale(App::getLocale())->isoFormat('LL') : '';
    }

    public function getIsEnrolledAttribute()
    {
        // if the student is currently enrolled
        if ($this->enrollments()->whereHas('course', fn ($q) => $q->where('period_id', Period::get_default_period()->id))->count() > 0) {
            return 1;
        }

        return false;
    }

    public function getLeadStatusNameAttribute()
    {
        return LeadType::find($this->lead_type_id)->name ?? null;
    }

    public function lead_status()
    {
        // if the student is currently enrolled, they are CONVERTED
        if ($this->is_enrolled) {

The expression $this->is_enrolled of type false|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== false instead.

            return 1;
        }

        // if the student has a special status, return it
        if ($this->leadType != null) {
            return $this->leadType->id;
        }

        // if the student was previously enrolled, they must be potential students
        if ($this->has('enrollments')) {
            return 4;
        }

        // otherwise, their status cannot be determined and should be left blank
        return null;
    }

    /** functions */

    /**
     * enroll the student in a course.
     * If the course has any children, we also enroll the student in the children courses.
     */
    public function enroll(Course $course): int
    {
        // avoid duplicates by retrieving an potential existing enrollment for the same course
        $enrollment = Enrollment::firstOrCreate([
            'student_id' =>  $this->id,
            'course_id' => $course->id,
        ],
        [
            'responsible_id' => backpack_user()->id ?? 1,

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        ]);

        // if the course has children, enroll in children as well.
        if ($course->children_count > 0) {
            foreach ($course->children as $children_course) {
                Enrollment::firstOrCreate([
                    'student_id' =>  $this->id,
                    'course_id' => $children_course->id,
                    'parent_id' => $enrollment->id,
                ],
                [
                    'responsible_id' => backpack_user()->id ?? 1,
                ]);
            }
        }

        $this->update(['lead_type_id' => null]); // fallback to default (converted)

        // to subscribe the student to mailing lists and so on
        $listId = config('mailing-system.mailerlite.activeStudentsListId');
        LeadStatusUpdatedEvent::dispatch($this, $listId);

        foreach ($this->contacts as $contact) {
            LeadStatusUpdatedEvent::dispatch($contact, $listId);
        }

        return $enrollment->id;
    }

    /** SETTERS */
    public function setFirstnameAttribute($value)
    {
        $this->user->update(['firstname' => $value]);
    }

    public function setLastnameAttribute($value)
    {
        $this->user->update(['lastname' => $value]);
    }

    public function setEmailAttribute($value)
    {
        $this->user->update(['email' => $value]);
    }

    public function getImageAttribute(): ?string
    {
        return $this->getMedia('profile-picture')->last()?->getUrl('thumb');
    }

    public function setImageAttribute($value)
    {
        // if the image was erased
        if ($value==null) {
            $this->clearMediaCollection('profile-picture');
        }

        // if a base64 was sent, store it in the db
        if (Str::startsWith($value, 'data:image'))
        {
            $this->addMediaFromBase64($value)
                ->usingFileName('profilePicture.jpg')
                ->toMediaCollection('profile-picture');
        }
    }
}