academico-sis / academico

app/Http/Controllers/HomeController.php

Spacing +5 added lines, -5 removed lines

@@ -44,7 +44,7 @@ 
 
     public function teacher(Request $request)
     {
-        if (! backpack_user()->isTeacher()) {
+        if (!backpack_user()->isTeacher()) {
             abort(403);
         }
 
@@ -69,7 +69,7 @@ 
 
     public function student()
     {
-        if (! backpack_user()->isStudent()) {
+        if (!backpack_user()->isStudent()) {
             abort(403);
         }
 
@@ -87,7 +87,7 @@ 
         $currentPeriod = Period::get_default_period();
         $enrollmentsPeriod = Period::get_enrollments_period();
 
-        if (! backpack_user()->hasRole(['admin', 'secretary'])) {
+        if (!backpack_user()->hasRole(['admin', 'secretary'])) {
             abort(403);
         }
 
@@ -96,7 +96,7 @@ 
         // todo optimize this !!
         $events = Event::where('start', '>', Carbon::now()->subDays(15))->where('end', '<', Carbon::now()->addDays(15))->orderBy('id', 'desc')
             ->get()
-            ->map(fn ($event) => [
+            ->map(fn($event) => [
                 'title' => $event['name'],
                 'resourceId' => $event['teacher_id'],
                 'start' => $event['start'],
@@ -108,7 +108,7 @@ 
 
         $teachers = Teacher::with('user')->get()->toArray();
 
-        $teachers = array_map(fn ($teacher) => [
+        $teachers = array_map(fn($teacher) => [
             'id' => $teacher['id'],
             'title' => $teacher['user']['firstname'],
         ], $teachers);

app/Services/ApolearnService.php

Spacing +6 added lines, -6 removed lines

@@ -133,7 +133,7 @@ 
 
     public function updateCourse(Course $course): void
     {
-        if (! $course->lms_id) {
+        if (!$course->lms_id) {
             $this->createCourse($course);
         }
 
@@ -162,7 +162,7 @@ 
             Log::info('found these teachers IDs on LMS:'.implode(', ', $teachers->pluck('id')->toArray()));
 
             // if the course has no teacher, stop
-            if (! $course->teacher) {
+            if (!$course->teacher) {
                 Log::alert('The course has no teacher on local system, removing all teachers from remote');
                 foreach ($teachers as $teacher) {
                     $this->removeTeacher($course->lms_id, $teacher['id']);
@@ -177,7 +177,7 @@ 
                     }
                 }
 
-                if (! $course->teacher->user->lms_id || ! $teachers->contains('id', $course->teacher->user->lms_id)) {
+                if (!$course->teacher->user->lms_id || !$teachers->contains('id', $course->teacher->user->lms_id)) {
                     Log::info('the course teacher has changed, need to update it');
                     $this->addTeacher($course);
                 }
@@ -187,14 +187,14 @@ 
 
     public function enrollStudent(Course $course, Student $student): void
     {
-        if (! $course->lms_id) {
+        if (!$course->lms_id) {
             abort(404, 'This course is not synced with external LMS');
         }
 
         $courseId = $course->lms_id;
 
         // if the student is not synced with the LMS, create them
-        if (! $student->user->lms_id) {
+        if (!$student->user->lms_id) {
             $this->createUser($student->user);
         }
 
@@ -217,7 +217,7 @@ 
         // only process if the course has a teacher
         if ($course->teacher_id) {
             // if the teacher doesn't exist on LMS, create them
-            if (! $course->teacher->user->lms_id) {
+            if (!$course->teacher->user->lms_id) {
                 Log::info('creating user now');
                 $this->createUser($course->teacher->user);
             }

app/Models/Teacher.php

Spacing +7 added lines, -7 removed lines

@@ -39,22 +39,22 @@ 
     /** attributes */
     public function getFirstnameAttribute(): ?string
     {
-        return $this?->user?->firstname;
+        return $this ? ->user ? ->firstname;
     }
 
     public function getLastnameAttribute(): ?string
     {
-        return $this?->user?->lastname;
+        return $this ? ->user ? ->lastname;
     }
 
     public function getEmailAttribute(): ?string
     {
-        return $this?->user?->email;
+        return $this ? ->user ? ->email;
     }
 
     public function getNameAttribute(): ?string
     {
-        return $this?->user?->firstname.' '.$this?->user?->lastname;
+        return $this ? ->user ? ->firstname.' '.$this ? ->user ? ->lastname;
     }
 
     public function period_courses(Period $period)
@@ -178,14 +178,14 @@ 
         $eventsWithMissingAttendance = [];
 
         $eventsWithExpectedAttendance = $this->events()
-        ->where(function ($query) {
+        ->where(function($query) {
             $query->where('exempt_attendance', '!=', true);
             $query->where('exempt_attendance', '!=', 1);
             $query->orWhereNull('exempt_attendance');
         })
         ->where('course_id', '!=', null)
-        ->whereHas('course', fn (Builder $query) => $query->where('period_id', $period->id)
-            ->where(function ($query) {
+        ->whereHas('course', fn(Builder $query) => $query->where('period_id', $period->id)
+            ->where(function($query) {
                 $query->where('exempt_attendance', '!=', true);
                 $query->where('exempt_attendance', '!=', 1);
                 $query->orWhereNull('exempt_attendance');

app/Models/ScheduledPayment.php

Spacing +3 added lines, -3 removed lines

@@ -31,7 +31,7 @@ 
 
     public function scopeStatus(Builder $query, $status)
     {
-        return match ($status) {
+        return match($status) {
             '2' => $query->where('status', 2),
             '1' => $query->where('status', 1),
             default => $query,
@@ -67,7 +67,7 @@ 
 
     public function invoices()
     {
-        return $this->invoiceDetails->map(fn (InvoiceDetail $invoiceDetail) => $invoiceDetail->invoice)->filter();
+        return $this->invoiceDetails->map(fn(InvoiceDetail $invoiceDetail) => $invoiceDetail->invoice)->filter();
     }
     /*
     |--------------------------------------------------------------------------
@@ -123,7 +123,7 @@ 
 
     public function getStatusTypeNameAttribute()
     {
-        return match ($this->status) {
+        return match($this->status) {
             2 => __('Paid'),
             1 => __('Pending'),
             default => '-',

app/Models/Enrollment.php

Spacing +10 added lines, -10 removed lines

@@ -60,11 +60,11 @@ 
     public function scopeWithoutChildren($query)
     {
         return $query
-            ->where(function ($query) {
+            ->where(function($query) {
                 $query->whereDoesntHave('childrenEnrollments')
                 ->where('parent_id', null);
             })
-            ->orWhere(function ($query) {
+            ->orWhere(function($query) {
                 $query->where('parent_id', null);
             })
             ->get();
@@ -86,7 +86,7 @@ 
 
     public function scopePeriod(Builder $query, int $periodId)
     {
-        return $query->whereHas('course', function ($q) use ($periodId) {
+        return $query->whereHas('course', function($q) use ($periodId) {
             $q->where('period_id', $periodId);
         });
     }
@@ -174,13 +174,13 @@ 
 
     public function invoices()
     {
-        return $this->invoiceDetails->map(fn (InvoiceDetail $invoiceDetail) => $invoiceDetail->invoice)->filter();
+        return $this->invoiceDetails->map(fn(InvoiceDetail $invoiceDetail) => $invoiceDetail->invoice)->filter();
     }
 
     // also includes invoices for this enrollment's scheduled payments.
     public function relatedInvoices()
     {
-        $scheduledPaymentsInvoices = $this->scheduledPayments->map(fn (ScheduledPayment $scheduledPayment) => $scheduledPayment->invoices());
+        $scheduledPaymentsInvoices = $this->scheduledPayments->map(fn(ScheduledPayment $scheduledPayment) => $scheduledPayment->invoices());
 
         return $this->invoices()->concat($scheduledPaymentsInvoices)->flatten(1);
     }
@@ -336,7 +336,7 @@ 
         }
 
         // if enabled, retrieve the default price category for the student
-        if (config('invoicing.price_categories_enabled') && $this->student?->price_category) {
+        if (config('invoicing.price_categories_enabled') && $this->student ? ->price_category) {
             $price_category = $this->student->price_category;
 
             return $this->course->$price_category ?? 0;
@@ -366,11 +366,11 @@ 
 
         // delete attendance records related to the enrollment
         $attendances = $this->course->attendance->where('student_id', $this->student->id);
-        Attendance::destroy($attendances->map(fn ($item, $key) => $item->id));
+        Attendance::destroy($attendances->map(fn($item, $key) => $item->id));
 
         foreach ($this->course->children as $child) {
             $attendances = $child->attendance->where('student_id', $this->student->id);
-            Attendance::destroy($attendances->map(fn ($item, $key) => $item->id));
+            Attendance::destroy($attendances->map(fn($item, $key) => $item->id));
         }
 
         $this->delete();
@@ -401,7 +401,7 @@ 
                 }
 
                 // if one book is expired
-                if ($this->student && $this->student->books->where('id', $book->id)->filter(fn ($book) => $book->pivot->expiry_date == null || $book->pivot->expiry_date > Carbon::now())->count() == 0) {
+                if ($this->student && $this->student->books->where('id', $book->id)->filter(fn($book) => $book->pivot->expiry_date == null || $book->pivot->expiry_date > Carbon::now())->count() == 0) {
                     return 'EXP';
                 }
             }
@@ -412,7 +412,7 @@ 
 
     public function getBalanceAttribute()
     {
-        if (! config('invoicing.invoices_contain_enrollments_only')) {
+        if (!config('invoicing.invoices_contain_enrollments_only')) {
             abort(422, 'Configuration options forbid to access this value');
         }
 

app/Console/Commands/genderizeStudents.php

Spacing +3 added lines, -3 removed lines

@@ -349,8 +349,8 @@ 
 
     public function handle()
     {
-        Student::whereNull('gender_id')->chunkById(10, function ($students) {
-            $query = $students->map(fn ($student) => ['id' => $student->id,
+        Student::whereNull('gender_id')->chunkById(10, function($students) {
+            $query = $students->map(fn($student) => ['id' => $student->id,
                 'name' => $this->remove_accents(strtok($student->firstname, ' ')), ]);
 
             $response = Http::get('https://api.genderize.io/?name[]='.$query->pluck('name')->implode('&name[]='));
@@ -358,7 +358,7 @@ 
                 $firstname = $query->firstWhere('id', $student->id)['name'];
 
                 $student->update([
-                    'gender_id' => match ($response->collect()->where('name', $firstname)->where('probability', '>', 0.9)->where('count', '>', 10)->first()['gender'] ?? '-') {
+                    'gender_id' => match($response->collect()->where('name', $firstname)->where('probability', '>', 0.9)->where('count', '>', 10)->first()['gender'] ?? '-') {
                         'male' => 2,
                         'female' => 1,
                         default => null,

app/Http/Controllers/Admin/EventCrudController.php

Spacing +9 added lines, -9 removed lines

@@ -116,13 +116,13 @@ 
         ]);
 
         CRUD::addFilter(
-            [ // daterange filter
+            [// daterange filter
                 'type' => 'date_range',
                 'name' => 'from_to',
                 'label' => __('Date range'),
             ],
             false,
-            function ($value) { // if the filter is active, apply these constraints
+            function($value) { // if the filter is active, apply these constraints
                 $dates = json_decode($value, null, 512, JSON_THROW_ON_ERROR);
 
                 if ($dates->from) {
@@ -141,10 +141,10 @@ 
                 'label' => __('Events with no course'),
             ],
             false,
-            function () { // if the filter is active, apply these constraints
+            function() { // if the filter is active, apply these constraints
                 $this->crud->query->where('course_id', null);
             },
-            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+            function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
             }
         );
 
@@ -155,22 +155,22 @@ 
                 'label' => __('Events with no teacher'),
             ],
             false,
-            function () { // if the filter is active, apply these constraints
+            function() { // if the filter is active, apply these constraints
                 CRUD::addClause('unassigned');
             }
         );
 
         CRUD::addFilter(
-            [ // select2 filter
+            [// select2 filter
                 'name' => 'teacher_id',
                 'type' => 'select2',
                 'label' => __('Teacher'),
             ],
-            fn () => Teacher::all()->pluck('name', 'id')->toArray(),
-            function ($value) {
+            fn() => Teacher::all()->pluck('name', 'id')->toArray(),
+            function($value) {
                 CRUD::addClause('where', 'teacher_id', $value);
             },
-            function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
+            function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
             }
         );
     }

app/Http/Controllers/Admin/TeacherCrudController.php

Spacing +11 added lines, -11 removed lines

@@ -46,10 +46,10 @@ 
                 'attribute' => 'lastname',
                 'model' => User::class,
                 'orderable' => true,
-                'orderLogic' => fn ($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
+                'orderLogic' => fn($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
                     ->orderBy('users.lastname', $columnDirection)->select('students.*'),
-                'searchLogic' => function ($query, $column, $searchTerm) {
-                    $query->orWhereHas('user', function ($q) use ($searchTerm) {
+                'searchLogic' => function($query, $column, $searchTerm) {
+                    $query->orWhereHas('user', function($q) use ($searchTerm) {
                         $q->where('lastname', 'like', '%'.$searchTerm.'%');
                     });
                 },
@@ -64,10 +64,10 @@ 
                 'attribute' => 'firstname',
                 'model' => User::class,
                 'orderable' => true,
-                'orderLogic' => fn ($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'teachers.id')
+                'orderLogic' => fn($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'teachers.id')
                     ->orderBy('users.firstname', $columnDirection)->select('teachers.*'),
-                'searchLogic' => function ($query, $column, $searchTerm) {
-                    $query->orWhereHas('user', function ($q) use ($searchTerm) {
+                'searchLogic' => function($query, $column, $searchTerm) {
+                    $query->orWhereHas('user', function($q) use ($searchTerm) {
                         $q->where('firstname', 'like', '%'.$searchTerm.'%');
                     });
                 },
@@ -81,10 +81,10 @@ 
                 'attribute' => 'email',
                 'model' => User::class,
                 'orderable' => true,
-                'orderLogic' => fn ($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'teachers.id')
+                'orderLogic' => fn($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'teachers.id')
                     ->orderBy('users.email', $columnDirection)->select('teachers.*'),
-                'searchLogic' => function ($query, $column, $searchTerm) {
-                    $query->orWhereHas('user', function ($q) use ($searchTerm) {
+                'searchLogic' => function($query, $column, $searchTerm) {
+                    $query->orWhereHas('user', function($q) use ($searchTerm) {
                         $q->where('email', 'like', '%'.$searchTerm.'%');
                     });
                 },
@@ -181,8 +181,8 @@ 
         $username_parts = array_filter(explode(' ', strtolower($fullName)));
         $username_parts = array_slice($username_parts, -2);
 
-        $part1 = (! empty($username_parts[0])) ? substr($username_parts[0], 0, 3) : '';
-        $part2 = (! empty($username_parts[1])) ? substr($username_parts[1], 0, 8) : '';
+        $part1 = (!empty($username_parts[0])) ? substr($username_parts[0], 0, 3) : '';
+        $part2 = (!empty($username_parts[1])) ? substr($username_parts[1], 0, 8) : '';
         $part3 = random_int(999, 9999);
 
         //str_shuffle to randomly shuffle all characters

app/Http/Controllers/Auth/RegisterController.php

Spacing +3 added lines, -3 removed lines

@@ -31,8 +31,8 @@ 
         $username_parts = array_filter(explode(' ', strtolower($fullName)));
         $username_parts = array_slice($username_parts, -2);
 
-        $part1 = (! empty($username_parts[0])) ? substr($username_parts[0], 0, 3) : '';
-        $part2 = (! empty($username_parts[1])) ? substr($username_parts[1], 0, 8) : '';
+        $part1 = (!empty($username_parts[0])) ? substr($username_parts[0], 0, 3) : '';
+        $part2 = (!empty($username_parts[1])) ? substr($username_parts[1], 0, 8) : '';
         $part3 = random_int(999, 9999);
 
         //str_shuffle to randomly shuffle all characters
@@ -124,7 +124,7 @@ 
     {
 
         // if registration is closed, deny access
-        if (! config('backpack.base.registration_open')) {
+        if (!config('backpack.base.registration_open')) {
             abort(403, trans('backpack::base.registration_closed'));
         }