academico-sis / academico

app/Http/Controllers/InvoiceController.php

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
 
         // persist the products
         foreach ($request->products as $f => $product) {
-            $productType = match ($product['type']) {
+            $productType = match($product['type']) {
                 'enrollment' => Enrollment::class,
                 'scheduledPayment' => Enrollment::class,
                 'fee' => Fee::class,

app/Http/Controllers/TeacherCalendarController.php

Spacing +7 added lines, -7 removed lines

@@ -25,7 +25,7 @@ 
         $events = Event::with('course')
             ->where('start', '>', Carbon::now()->subDays(30))->where('end', '<', Carbon::now()->addDays(30))->orderBy('id', 'desc') // TODO optimize this.
             ->get()
-            ->map(fn ($event) => [
+            ->map(fn($event) => [
                 'title' => $event['name'] ?? '',
                 'resourceId' => $event['teacher_id'],
                 'start' => $event['start'],
@@ -37,14 +37,14 @@ 
 
         $teachers = Teacher::all()->toArray();
 
-        $teachers = array_map(fn ($teacher) => [
+        $teachers = array_map(fn($teacher) => [
             'id' => $teacher['id'],
             'title' => $teacher['name'] ?? '',
         ], $teachers);
 
         array_push($teachers, ['id' => 'tbd', 'title' => 'Unassigned']);
 
-        $unassigned_events = Event::unassigned()->get()->map(fn ($event) => [
+        $unassigned_events = Event::unassigned()->get()->map(fn($event) => [
             'title' => $event['name'] ?? '',
             'resourceId' => 'tbd',
             'start' => $event['start'],
@@ -54,7 +54,7 @@ 
             'borderColor' => $event['color'],
         ]);
 
-        $leaves = Leave::orderBy('date', 'desc')->limit(10000)->get()->map(fn ($event) => [
+        $leaves = Leave::orderBy('date', 'desc')->limit(10000)->get()->map(fn($event) => [
             'title' => $event->leaveType->name ?? 'ABS', // todo fix
             'resourceId' => $event['teacher_id'],
             'start' => $event['date'],
@@ -80,7 +80,7 @@ 
             abort(403);
         }
 
-        $events = $teacher->events->map(fn ($event) => [
+        $events = $teacher->events->map(fn($event) => [
             'title' => $event['name'],
             'start' => $event['start'],
             'end' => $event['end'],
@@ -88,8 +88,8 @@ 
             'borderColor' => $event['color'],
         ]);
 
-        $leaves = $teacher->leaves->map(fn ($event) => [
-            'title' => $event->leaveType->name ?? 'vacances',  // todo fix
+        $leaves = $teacher->leaves->map(fn($event) => [
+            'title' => $event->leaveType->name ?? 'vacances', // todo fix
             'start' => $event['date'],
             'allDay' => true,
         ]);

app/Http/Controllers/HomeController.php

Spacing +6 added lines, -6 removed lines

@@ -44,7 +44,7 @@ 
 
     public function teacher(Request $request)
     {
-        if (! backpack_user()->isTeacher()) {
+        if (!backpack_user()->isTeacher()) {
             abort(403);
         }
 
@@ -69,7 +69,7 @@ 
 
     public function student()
     {
-        if (! backpack_user()->isStudent()) {
+        if (!backpack_user()->isStudent()) {
             abort(403);
         }
 
@@ -87,7 +87,7 @@ 
         $currentPeriod = Period::get_default_period();
         $enrollmentsPeriod = Period::get_enrollments_period();
 
-        if (! backpack_user()->hasRole(['admin', 'secretary'])) {
+        if (!backpack_user()->hasRole(['admin', 'secretary'])) {
             abort(403);
         }
 
@@ -96,7 +96,7 @@ 
         // todo optimize this !!
         $events = Event::where('start', '>', Carbon::now()->subDays(15))->where('end', '<', Carbon::now()->addDays(15))->orderBy('id', 'desc')
             ->get()
-            ->map(fn ($event) => [
+            ->map(fn($event) => [
                 'title' => $event['name'],
                 'resourceId' => $event['teacher_id'],
                 'start' => $event['start'],
@@ -108,7 +108,7 @@ 
 
         $teachers = Teacher::with('user')->get()->toArray();
 
-        $teachers = array_map(fn ($teacher) => [
+        $teachers = array_map(fn($teacher) => [
             'id' => $teacher['id'],
             'title' => $teacher['user']['firstname'],
         ], $teachers);
@@ -122,7 +122,7 @@ 
             'total_enrollment_count' => $currentPeriod->internal_enrollments_count,
             'resources' => $teachers,
             'events' => $events,
-            'pending_attendance' => $currentPeriod->courses_with_pending_attendance,  // todo: optimize
+            'pending_attendance' => $currentPeriod->courses_with_pending_attendance, // todo: optimize
             'unassigned_events' => Event::unassigned()->count(),
             'pending_leads' => LeadType::find(4)->students()->count(),
         ]);

app/Http/Controllers/CourseSkillEvaluationController.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 
         $course = Course::with('evaluationType')->find($enrollment->course_id);
 
-        $skills = $course->skills->map(function ($skill, $key) use ($student_skills) {
+        $skills = $course->skills->map(function($skill, $key) use ($student_skills) {
             $skill['status'] = $student_skills->where('skill_id', $skill->id)->first()->skill_scale_id ?? null;
 
             return $skill;

app/Models/Event.php

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
         parent::boot();
 
         // before adding an event, we check that the teacher is available
-        static::saving(function ($event) {
+        static::saving(function($event) {
             $teacher = Teacher::find($event->teacher_id);
             // if the teacher is on leave on the day of the event
             if ($event->teacher_id !== null && $teacher) {
@@ -148,7 +148,7 @@ 
 
     public function getColorAttribute()
     {
-        return $this?->course->color ?? ('#'.substr(md5($this->course_id ?? '0'), 0, 6));
+        return $this ? ->course->color ?? ('#'.substr(md5($this->course_id ?? '0'), 0, 6));
     }
 
     /*

app/Models/Course.php

Spacing +6 added lines, -6 removed lines

@@ -203,7 +203,7 @@ 
      */
     public function skills()
     {
-        return $this->evaluationType?->skills()->orderBy('order');
+        return $this->evaluationType ? ->skills()->orderBy('order');
     }
 
     public function books()
@@ -228,7 +228,7 @@ 
      */
     public function getPendingAttendanceAttribute()
     {
-        $events = Event::where(function ($query) {
+        $events = Event::where(function($query) {
             $query->where('course_id', $this->id);
             $query->where('exempt_attendance', '!=', true);
             $query->where('exempt_attendance', '!=', 1);
@@ -361,7 +361,7 @@ 
             foreach ($courseTimes as $courseTime) {
                 $initial = $daysInitials[$courseTime->day];
 
-                if (! isset($parsedCourseTimes[$initial])) {
+                if (!isset($parsedCourseTimes[$initial])) {
                     $parsedCourseTimes[$initial] = [];
                 }
 
@@ -408,7 +408,7 @@ 
     public function getCourseTeacherNameAttribute()
     {
         if ($this->teacher_id) {
-            return $this->teacher?->name;
+            return $this->teacher ? ->name;
         } else {
             return '-';
         }
@@ -441,7 +441,7 @@ 
 
     public function getAcceptsNewStudentsAttribute(): bool
     {
-        if (! $this->spots || $this->spots == 0) {
+        if (!$this->spots || $this->spots == 0) {
             return true;
         }
 
@@ -464,7 +464,7 @@ 
 
     public function eventsWithExpectedAttendance()
     {
-        return $this->events()->where(function ($query) {
+        return $this->events()->where(function($query) {
             $query->where('exempt_attendance', '!=', true);
             $query->where('exempt_attendance', '!=', 1);
             $query->orWhereNull('exempt_attendance');

app/Models/Payment.php

Spacing +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
 
     public function getDisplayStatusAttribute()
     {
-        return match ($this->status) {
+        return match($this->status) {
             null, 1 => __('Pending'),
             2 => __('Paid'),
         };

app/Models/Teacher.php

Spacing +7 added lines, -7 removed lines

@@ -39,22 +39,22 @@ 
     /** attributes */
     public function getFirstnameAttribute() : ?string
     {
-        return $this?->user?->firstname;
+        return $this ? ->user ? ->firstname;
     }
 
     public function getLastnameAttribute() : ?string
     {
-        return $this?->user?->lastname;
+        return $this ? ->user ? ->lastname;
     }
 
     public function getEmailAttribute() : ?string
     {
-        return $this?->user?->email ?? '';
+        return $this ? ->user ? ->email ?? '';
     }
 
     public function getNameAttribute() : ?string
     {
-        return $this?->user?->firstname.' '.$this?->user?->lastname;
+        return $this ? ->user ? ->firstname.' '.$this ? ->user ? ->lastname;
     }
 
     public function period_courses(Period $period)
@@ -178,14 +178,14 @@ 
         $eventsWithMissingAttendance = [];
 
         $eventsWithExpectedAttendance = $this->events()
-        ->where(function ($query) {
+        ->where(function($query) {
             $query->where('exempt_attendance', '!=', true);
             $query->where('exempt_attendance', '!=', 1);
             $query->orWhereNull('exempt_attendance');
         })
         ->where('course_id', '!=', null)
-        ->whereHas('course', fn (Builder $query) => $query->where('period_id', $period->id)
-            ->where(function ($query) {
+        ->whereHas('course', fn(Builder $query) => $query->where('period_id', $period->id)
+            ->where(function($query) {
                 $query->where('exempt_attendance', '!=', true);
                 $query->where('exempt_attendance', '!=', 1);
                 $query->orWhereNull('exempt_attendance');

app/Models/Policies/StudentPolicy.php

Spacing +1 added lines, -1 removed lines

@@ -27,6 +27,6 @@
     {
         // if the student is enrolled in any class by the user
 
-        return $student->enrollments()->whereHas('course', fn ($q) => $q->where('teacher_id', $user->id))->count() > 0;
+        return $student->enrollments()->whereHas('course', fn($q) => $q->where('teacher_id', $user->id))->count() > 0;
     }
 }