Passed
Push — master ( 99d751...45eca1 )
by Thomas
07:06
created
app/Http/Controllers/Admin/UserCrudController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
                 'label' => trans('backpack::permissionmanager.email'),
49 49
                 'type'  => 'email',
50 50
             ],
51
-            [ // n-n relationship (with pivot table)
51
+            [// n-n relationship (with pivot table)
52 52
                 'label'     => trans('backpack::permissionmanager.roles'),
53 53
                 'type'      => 'select_multiple',
54 54
                 'name'      => 'roles',
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
                 'label' => trans('backpack::permissionmanager.role'),
68 68
             ],
69 69
             config('permission.models.role')::all()->pluck(['name', 'id'])->toArray(),
70
-            function ($value) {
70
+            function($value) {
71 71
                 // if the filter is active
72
-                $this->crud->addClause('whereHas', 'roles', function ($query) use ($value) {
72
+                $this->crud->addClause('whereHas', 'roles', function($query) use ($value) {
73 73
                     $query->where('role_id', '=', $value);
74 74
                 });
75 75
             }
@@ -120,12 +120,12 @@  discard block
 block discarded – undo
120 120
     protected function addFields()
121 121
     {
122 122
         $this->crud->addFields([
123
-            [  // Select2
123
+            [// Select2
124 124
                 'label' => trans('firstname'),
125 125
                 'type' => 'text',
126 126
                 'name' => 'firstname',
127 127
             ],
128
-            [  // Select2
128
+            [// Select2
129 129
                 'label' => trans('lastname'),
130 130
                 'type' => 'text',
131 131
                 'name' => 'lastname',
Please login to merge, or discard this patch.
app/Http/Controllers/Admin/SkillCrudController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
     protected function setupListOperation()
32 32
     {
33 33
         CRUD::setColumns([
34
-            [ // skill type
34
+            [// skill type
35 35
                 'label'     => 'Type',
36 36
                 'type'      => 'select',
37 37
                 'name'      => 'skill_type',
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
                 'type' => 'text',
45 45
                 'name' => 'name',
46 46
             ],
47
-            [ // skill level
47
+            [// skill level
48 48
                 'label'     => 'Level',
49 49
                 'type'      => 'select',
50 50
                 'name'      => 'level',
@@ -56,19 +56,19 @@  discard block
 block discarded – undo
56 56
 
57 57
         CRUD::enableExportButtons();
58 58
 
59
-        CRUD::addFilter([ // select2 filter
59
+        CRUD::addFilter([// select2 filter
60 60
             'name' => 'level_id',
61 61
             'type' => 'select2',
62 62
             'label'=> 'Level',
63
-        ], fn () => Level::all()->pluck('name', 'id')->toArray(), function ($value) { // if the filter is active
63
+        ], fn() => Level::all()->pluck('name', 'id')->toArray(), function($value) { // if the filter is active
64 64
             CRUD::addClause('where', 'level_id', $value);
65 65
         });
66 66
 
67
-        CRUD::addFilter([ // select2 filter
67
+        CRUD::addFilter([// select2 filter
68 68
             'name' => 'skill_type_id',
69 69
             'type' => 'select2',
70 70
             'label'=> 'Type',
71
-        ], fn () => SkillType::all()->pluck('name', 'id')->toArray(), function ($value) { // if the filter is active
71
+        ], fn() => SkillType::all()->pluck('name', 'id')->toArray(), function($value) { // if the filter is active
72 72
             CRUD::addClause('where', 'skill_type_id', $value);
73 73
         });
74 74
     }
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
     {
78 78
         CRUD::setValidation(StoreRequest::class);
79 79
         CRUD::addFields([
80
-            [ // skill type
80
+            [// skill type
81 81
                 'label'     => 'Type',
82 82
                 'type' => 'select',
83 83
                 'name' => 'skill_type_id', // the db column for the foreign key
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
                 'type' => 'text',
91 91
                 'name' => 'name',
92 92
             ],
93
-            [ // skill level
93
+            [// skill level
94 94
                 'label'     => 'Level',
95 95
                 'type' => 'select',
96 96
                 'name' => 'level_id', // the db column for the foreign key
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
                 'type' => 'relationship',
104 104
                 'name' => 'skill_type', // the method on your model that defines the relationship
105 105
                 'ajax' => true,
106
-                'inline_create' => [ // specify the entity in singular
106
+                'inline_create' => [// specify the entity in singular
107 107
                     'entity' => 'skilltype', // the entity in singular
108 108
                     // OPTIONALS
109 109
                     'force_select' => true, // should the inline-created entry be immediately selected?
Please login to merge, or discard this patch.
app/Http/Controllers/Admin/TeacherCrudController.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
                 'attribute' => 'lastname',
47 47
                 'model'     => \App\Models\User::class,
48 48
                 'orderable' => true,
49
-                'orderLogic' => fn ($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
49
+                'orderLogic' => fn($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
50 50
                     ->orderBy('users.lastname', $columnDirection)->select('students.*'),
51
-                'searchLogic' => function ($query, $column, $searchTerm) {
52
-                    $query->orWhereHas('user', function ($q) use ($searchTerm) {
51
+                'searchLogic' => function($query, $column, $searchTerm) {
52
+                    $query->orWhereHas('user', function($q) use ($searchTerm) {
53 53
                         $q->where('lastname', 'like', '%'.$searchTerm.'%');
54 54
                     });
55 55
                 },
@@ -64,10 +64,10 @@  discard block
 block discarded – undo
64 64
                 'attribute' => 'firstname',
65 65
                 'model'     => \App\Models\User::class,
66 66
                 'orderable' => true,
67
-                'orderLogic' => fn ($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'teachers.id')
67
+                'orderLogic' => fn($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'teachers.id')
68 68
                     ->orderBy('users.firstname', $columnDirection)->select('teachers.*'),
69
-                'searchLogic' => function ($query, $column, $searchTerm) {
70
-                    $query->orWhereHas('user', function ($q) use ($searchTerm) {
69
+                'searchLogic' => function($query, $column, $searchTerm) {
70
+                    $query->orWhereHas('user', function($q) use ($searchTerm) {
71 71
                         $q->where('firstname', 'like', '%'.$searchTerm.'%');
72 72
                     });
73 73
                 },
@@ -81,10 +81,10 @@  discard block
 block discarded – undo
81 81
                 'attribute' => 'email',
82 82
                 'model'     => \App\Models\User::class,
83 83
                 'orderable' => true,
84
-                'orderLogic' => fn ($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'teachers.id')
84
+                'orderLogic' => fn($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'teachers.id')
85 85
                     ->orderBy('users.email', $columnDirection)->select('teachers.*'),
86
-                'searchLogic' => function ($query, $column, $searchTerm) {
87
-                    $query->orWhereHas('user', function ($q) use ($searchTerm) {
86
+                'searchLogic' => function($query, $column, $searchTerm) {
87
+                    $query->orWhereHas('user', function($q) use ($searchTerm) {
88 88
                         $q->where('email', 'like', '%'.$searchTerm.'%');
89 89
                     });
90 90
                 },
@@ -181,8 +181,8 @@  discard block
 block discarded – undo
181 181
         $username_parts = array_filter(explode(' ', strtolower($fullName)));
182 182
         $username_parts = array_slice($username_parts, -2);
183 183
 
184
-        $part1 = (! empty($username_parts[0])) ? substr($username_parts[0], 0, 3) : '';
185
-        $part2 = (! empty($username_parts[1])) ? substr($username_parts[1], 0, 8) : '';
184
+        $part1 = (!empty($username_parts[0])) ? substr($username_parts[0], 0, 3) : '';
185
+        $part2 = (!empty($username_parts[1])) ? substr($username_parts[1], 0, 8) : '';
186 186
         $part3 = random_int(999, 9999);
187 187
 
188 188
         $username = $part1.$part2.$part3; //str_shuffle to randomly shuffle all characters
Please login to merge, or discard this patch.
app/Http/Controllers/Admin/EvaluationTypeCrudController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
     {
35 35
         CRUD::addField(['name' => 'name', 'label' => 'Name', 'type' => 'text']);
36 36
 
37
-        CRUD::addField([    // Select2Multiple = n-n relationship (with pivot table)
37
+        CRUD::addField([// Select2Multiple = n-n relationship (with pivot table)
38 38
             'label'     => __('Grade Types'),
39 39
             'type'      => 'select2_multiple',
40 40
             'name'      => 'gradeTypes',
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
             'select_all' => true, // show Select All and Clear buttons?
48 48
         ]);
49 49
 
50
-        CRUD::addField([    // Select2Multiple = n-n relationship (with pivot table)
50
+        CRUD::addField([// Select2Multiple = n-n relationship (with pivot table)
51 51
             'label'     => __('Skills'),
52 52
             'type'      => 'select2_multiple',
53 53
             'name'      => 'skills',
Please login to merge, or discard this patch.
app/Console/Commands/genderizeStudents.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -196,15 +196,15 @@
 block discarded – undo
196 196
 
197 197
     public function handle()
198 198
     {
199
-        Student::whereNull('gender_id')->chunkById(10, function ($students) {
200
-            $query = $students->map(fn ($student) => ['id' => $student->id, 'name' => $this->remove_accents(strtok($student->firstname, ' '))]);
199
+        Student::whereNull('gender_id')->chunkById(10, function($students) {
200
+            $query = $students->map(fn($student) => ['id' => $student->id, 'name' => $this->remove_accents(strtok($student->firstname, ' '))]);
201 201
 
202 202
             $response = Http::get('https://api.genderize.io/?name[]='.$query->pluck('name')->implode('&name[]='));
203 203
             foreach ($students as $student) {
204 204
                 $firstname = $query->firstWhere('id', $student->id)['name'];
205 205
 
206 206
                 $student->update([
207
-                    'gender_id' => match ($response->collect()->where('name', $firstname)->where('probability', '>', 0.9)->where('count', '>', 10)->first()['gender'] ?? '-') {
207
+                    'gender_id' => match($response->collect()->where('name', $firstname)->where('probability', '>', 0.9)->where('count', '>', 10)->first()['gender'] ?? '-') {
208 208
                         'male' => 2,
209 209
                         'female' => 1,
210 210
                         default => null,
Please login to merge, or discard this patch.
app/Models/EnrollmentStatusType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
 
16 16
     public function styling()
17 17
     {
18
-        return match ($this->id) {
18
+        return match($this->id) {
19 19
             1 => 'warning',
20 20
             2 => 'info',
21 21
             default => 'danger',
Please login to merge, or discard this patch.
app/Models/Student.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -42,8 +42,8 @@  discard block
 block discarded – undo
42 42
 
43 43
     public function scopeEnrolled($query)
44 44
     {
45
-        return $query->whereHas('enrollments', function ($q) {
46
-            return $q->whereHas('course', function ($q) {
45
+        return $query->whereHas('enrollments', function($q) {
46
+            return $q->whereHas('course', function($q) {
47 47
                 return $q->where('period_id', Period::get_default_period()->id);
48 48
             });
49 49
         });
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
 
52 52
     public function scopeComputedLeadType($query, $leadTypeId)
53 53
     {
54
-        return match ($leadTypeId) {
55
-            1 => $query->whereHas('enrollments', fn ($query) => $query->whereHas('course', function ($q) {
54
+        return match($leadTypeId) {
55
+            1 => $query->whereHas('enrollments', fn($query) => $query->whereHas('course', function($q) {
56 56
                 $q->where('period_id', Period::get_default_period()->id);
57 57
             })),
58 58
 
@@ -61,15 +61,15 @@  discard block
 block discarded – undo
61 61
             4 => $query
62 62
                 ->where('lead_type_id', $leadTypeId)
63 63
                 ->orWhere(
64
-                    function ($query) {
64
+                    function($query) {
65 65
                     $query
66 66
                         ->whereNull('lead_type_id')
67
-                        ->whereHas('enrollments', fn ($query) => $query
68
-                            ->whereHas('course', function ($q) {
67
+                        ->whereHas('enrollments', fn($query) => $query
68
+                            ->whereHas('course', function($q) {
69 69
                                 $q->where('period_id', '!=', Period::get_default_period()->id);
70 70
                             }))
71
-                        ->whereDoesntHave('enrollments', fn ($query) => $query
72
-                            ->whereHas('course', function ($q) {
71
+                        ->whereDoesntHave('enrollments', fn($query) => $query
72
+                            ->whereHas('course', function($q) {
73 73
                                 $q->where('period_id', Period::get_default_period()->id);
74 74
                             }));
75 75
                 }
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         return $this->hasMany(Attendance::class)
112 112
         ->where('attendance_type_id', 4) // absence
113
-        ->whereHas('event', fn ($q) => $q->whereHas('course', fn ($c) => $c->where('period_id', $period->id)));
113
+        ->whereHas('event', fn($q) => $q->whereHas('course', fn($c) => $c->where('period_id', $period->id)));
114 114
     }
115 115
 
116 116
     public function periodAttendance(Period $period = null)
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
         }
121 121
 
122 122
         return $this->hasMany(Attendance::class)
123
-        ->whereHas('event', fn ($q) => $q->whereHas('course', fn ($c) => $c->where('period_id', $period->id)));
123
+        ->whereHas('event', fn($q) => $q->whereHas('course', fn($c) => $c->where('period_id', $period->id)));
124 124
     }
125 125
 
126 126
     public function contacts()
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 
182 182
     public function getEmailAttribute(): ?string
183 183
     {
184
-        return $this?->user?->email;
184
+        return $this ? ->user ? ->email;
185 185
     }
186 186
 
187 187
     public function getNameAttribute(): string
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
     public function getIsEnrolledAttribute()
203 203
     {
204 204
         // if the student is currently enrolled
205
-        if ($this->enrollments()->whereHas('course', fn ($q) => $q->where('period_id', Period::get_default_period()->id))->count() > 0) {
205
+        if ($this->enrollments()->whereHas('course', fn($q) => $q->where('period_id', Period::get_default_period()->id))->count() > 0) {
206 206
             return 1;
207 207
         }
208 208
 
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
 
302 302
     public function getImageAttribute(): ?string
303 303
     {
304
-        return $this->getMedia('profile-picture')->last()?->getUrl('thumb');
304
+        return $this->getMedia('profile-picture')->last() ? ->getUrl('thumb');
305 305
     }
306 306
 
307 307
     public function setImageAttribute($value)
Please login to merge, or discard this patch.
app/Models/Year.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
                 ->where('periods.year_id', $this->id)
47 47
                 ->whereIn('enrollments.status_id', ['1', '2']) // filter out cancelled enrollments, todo make this configurable.
48 48
                 ->where('enrollments.parent_id', null)->where('enrollments.deleted_at', null)
49
-                ->where(function ($query) {
49
+                ->where(function($query) {
50 50
                     return $query->where('students.gender_id', 0)->orWhereNull('students.gender_id');
51 51
                 })
52 52
                 ->distinct('student_id')->count('enrollments.student_id');
Please login to merge, or discard this patch.
app/Providers/AppServiceProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,12 +53,12 @@
 block discarded – undo
53 53
 
54 54
         View::composer(
55 55
             ['partials.create_new_contact', 'students.edit-contact'],
56
-            function ($view) {
56
+            function($view) {
57 57
                 $view->with('contact_types', ContactRelationship::all());
58 58
             }
59 59
         );
60 60
 
61
-        View::composer('partials.add_book_to_student', function ($view) {
61
+        View::composer('partials.add_book_to_student', function($view) {
62 62
             $view->with('books', Book::all());
63 63
             $view->with('statuses', EnrollmentStatusType::all());
64 64
         });
Please login to merge, or discard this patch.