academico-sis / academico

app/Http/Controllers/InvoiceController.php

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
 
         // persist the products
         foreach ($request->products as $f => $product) {
-            $productType = match ($product['type']) {
+            $productType = match($product['type']) {
                 'enrollment' => Enrollment::class,
                 'scheduledPayment' => Enrollment::class,
                 'fee' => Fee::class,

app/Http/Controllers/HomeController.php

Spacing +6 added lines, -6 removed lines

@@ -44,7 +44,7 @@ 
 
     public function teacher(Request $request)
     {
-        if (! backpack_user()->isTeacher()) {
+        if (!backpack_user()->isTeacher()) {
             abort(403);
         }
 
@@ -69,7 +69,7 @@ 
 
     public function student()
     {
-        if (! backpack_user()->isStudent()) {
+        if (!backpack_user()->isStudent()) {
             abort(403);
         }
 
@@ -87,7 +87,7 @@ 
         $currentPeriod = Period::get_default_period();
         $enrollmentsPeriod = Period::get_enrollments_period();
 
-        if (! backpack_user()->hasRole(['admin', 'secretary'])) {
+        if (!backpack_user()->hasRole(['admin', 'secretary'])) {
             abort(403);
         }
 
@@ -96,7 +96,7 @@ 
         // todo optimize this !!
         $events = Event::where('start', '>', Carbon::now()->subDays(15))->where('end', '<', Carbon::now()->addDays(15))->orderBy('id', 'desc')
             ->get()
-            ->map(fn ($event) => [
+            ->map(fn($event) => [
                 'title' => $event['name'],
                 'resourceId' => $event['teacher_id'],
                 'start' => $event['start'],
@@ -108,7 +108,7 @@ 
 
         $teachers = Teacher::with('user')->get()->toArray();
 
-        $teachers = array_map(fn ($teacher) => [
+        $teachers = array_map(fn($teacher) => [
             'id' => $teacher['id'],
             'title' => $teacher['user']['firstname'],
         ], $teachers);
@@ -122,7 +122,7 @@ 
             'total_enrollment_count' => $currentPeriod->internal_enrollments_count,
             'resources' => $teachers,
             'events' => $events,
-            'pending_attendance' => $currentPeriod->courses_with_pending_attendance,  // todo: optimize
+            'pending_attendance' => $currentPeriod->courses_with_pending_attendance, // todo: optimize
             'unassigned_events' => Event::unassigned()->count(),
             'pending_leads' => LeadType::find(4)->students()->count(),
         ]);

app/Http/Controllers/CourseSkillEvaluationController.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 
         $course = Course::with('evaluationType')->find($enrollment->course_id);
 
-        $skills = $course->skills->map(function ($skill, $key) use ($student_skills) {
+        $skills = $course->skills->map(function($skill, $key) use ($student_skills) {
             $skill['status'] = $student_skills->where('skill_id', $skill->id)->first()->skill_scale_id ?? null;
 
             return $skill;

app/Models/Event.php

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
         parent::boot();
 
         // before adding an event, we check that the teacher is available
-        static::saving(function ($event) {
+        static::saving(function($event) {
             $teacher = Teacher::find($event->teacher_id);
             // if the teacher is on leave on the day of the event
             if ($event->teacher_id !== null && $teacher) {
@@ -148,7 +148,7 @@ 
 
     public function getColorAttribute()
     {
-        return $this?->course->color ?? ('#'.substr(md5($this->course_id ?? '0'), 0, 6));
+        return $this ? ->course->color ?? ('#'.substr(md5($this->course_id ?? '0'), 0, 6));
     }
 
     /*

app/Models/Course.php

Spacing +6 added lines, -6 removed lines

@@ -203,7 +203,7 @@ 
      */
     public function skills()
     {
-        return $this->evaluationType?->skills()->orderBy('order');
+        return $this->evaluationType ? ->skills()->orderBy('order');
     }
 
     public function books()
@@ -228,7 +228,7 @@ 
      */
     public function getPendingAttendanceAttribute()
     {
-        $events = Event::where(function ($query) {
+        $events = Event::where(function($query) {
             $query->where('course_id', $this->id);
             $query->where('exempt_attendance', '!=', true);
             $query->where('exempt_attendance', '!=', 1);
@@ -361,7 +361,7 @@ 
             foreach ($courseTimes as $courseTime) {
                 $initial = $daysInitials[$courseTime->day];
 
-                if (! isset($parsedCourseTimes[$initial])) {
+                if (!isset($parsedCourseTimes[$initial])) {
                     $parsedCourseTimes[$initial] = [];
                 }
 
@@ -408,7 +408,7 @@ 
     public function getCourseTeacherNameAttribute()
     {
         if ($this->teacher_id) {
-            return $this->teacher?->name;
+            return $this->teacher ? ->name;
         } else {
             return '-';
         }
@@ -441,7 +441,7 @@ 
 
     public function getAcceptsNewStudentsAttribute(): bool
     {
-        if (! $this->spots || $this->spots == 0) {
+        if (!$this->spots || $this->spots == 0) {
             return true;
         }
 
@@ -464,7 +464,7 @@ 
 
     public function eventsWithExpectedAttendance()
     {
-        return $this->events()->where(function ($query) {
+        return $this->events()->where(function($query) {
             $query->where('exempt_attendance', '!=', true);
             $query->where('exempt_attendance', '!=', 1);
             $query->orWhereNull('exempt_attendance');

app/Models/Payment.php

Spacing +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
 
     public function getDisplayStatusAttribute()
     {
-        return match ($this->status) {
+        return match($this->status) {
             null, 1 => __('Pending'),
             2 => __('Paid'),
         };

app/Models/Policies/StudentPolicy.php

Spacing +1 added lines, -1 removed lines

@@ -27,6 +27,6 @@
     {
         // if the student is enrolled in any class by the user
 
-        return $student->enrollments()->whereHas('course', fn ($q) => $q->where('teacher_id', $user->id))->count() > 0;
+        return $student->enrollments()->whereHas('course', fn($q) => $q->where('teacher_id', $user->id))->count() > 0;
     }
 }

app/Models/Enrollment.php

Spacing +8 added lines, -8 removed lines

@@ -59,11 +59,11 @@ 
     public function scopeWithoutChildren($query)
     {
         return $query
-            ->where(function ($query) {
+            ->where(function($query) {
                 $query->whereDoesntHave('childrenEnrollments')
                 ->where('parent_id', null);
             })
-            ->orWhere(function ($query) {
+            ->orWhere(function($query) {
                 $query->where('parent_id', null);
             })
             ->get();
@@ -85,7 +85,7 @@ 
 
     public function scopePeriod(Builder $query, int $periodId)
     {
-        return $query->whereHas('course', function ($q) use ($periodId) {
+        return $query->whereHas('course', function($q) use ($periodId) {
             $q->where('period_id', $periodId);
         });
     }
@@ -318,7 +318,7 @@ 
         }
 
         // if enabled, retrieve the default price category for the student
-        if (config('invoicing.price_categories_enabled') && $this->student?->price_category) {
+        if (config('invoicing.price_categories_enabled') && $this->student ? ->price_category) {
             $price_category = $this->student->price_category;
 
             return $this->course->$price_category ?? 0;
@@ -343,7 +343,7 @@ 
         $paidAmount = 0;
 
         foreach ($this->invoices as $invoice) {
-            $paidAmount += $invoice->payments?->sum('value') ?? 0;
+            $paidAmount += $invoice->payments ? ->sum('value') ?? 0;
         }
 
         $balance -= $paidAmount;
@@ -362,11 +362,11 @@ 
 
         // delete attendance records related to the enrollment
         $attendances = $this->course->attendance->where('student_id', $this->student->id);
-        Attendance::destroy($attendances->map(fn ($item, $key) => $item->id));
+        Attendance::destroy($attendances->map(fn($item, $key) => $item->id));
 
         foreach ($this->course->children as $child) {
             $attendances = $child->attendance->where('student_id', $this->student->id);
-            Attendance::destroy($attendances->map(fn ($item, $key) => $item->id));
+            Attendance::destroy($attendances->map(fn($item, $key) => $item->id));
         }
 
         $this->delete();
@@ -397,7 +397,7 @@ 
                 }
 
                 // if one book is expired
-                if ($this->student && $this->student->books->where('id', $book->id)->filter(fn ($book) => $book->pivot->expiry_date == null || $book->pivot->expiry_date > Carbon::now())->count() == 0) {
+                if ($this->student && $this->student->books->where('id', $book->id)->filter(fn($book) => $book->pivot->expiry_date == null || $book->pivot->expiry_date > Carbon::now())->count() == 0) {
                     return 'EXP';
                 }
             }

app/Models/ScheduledPayment.php

Spacing +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
 
     public function scopeStatus(Builder $query, $status)
     {
-        return match ($status) {
+        return match($status) {
             '2' => $query->where('status', 2)->orWhereHas('invoices'),
             '1' => $query->where('status', 1)->orWhereDoesntHave('invoices'),
             default => $query,
@@ -110,7 +110,7 @@ 
 
     public function getStatusTypeNameAttribute()
     {
-        return match ($this->computed_status) {
+        return match($this->computed_status) {
             2 => __('Paid'),
             1 => __('Pending'),
             default => '-',