App\Traits\HandlesAttendance::remindPendingAttendance()

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function remindPendingAttendance()
    {
        $period = Period::get_default_period();
        foreach (Teacher::all() as $teacher) {
            $events = $teacher->events_with_pending_attendance($period)

It seems like $period can also be of type null; however, parameter $period of App\Models\Teacher::events_with_pending_attendance() does only seem to accept App\Models\Period, maybe add an additional type check?

                ->where('start', '<', (Carbon::parse('24 hours ago'))->toDateTimeString());

            if ($events->count() > 0) {
                Mail::to($teacher->email)
                    ->locale('fr')
                    ->queue(new PendingAttendanceReminder($teacher, $events));
            }