academico-sis /
academico
| Conditions | 23 |
| Paths | 1 |
| Total Lines | 81 |
| Code Lines | 17 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function boot() |
||
| 26 | { |
||
| 27 | $this->registerPolicies(); |
||
| 28 | |||
| 29 | /* |
||
| 30 | * a user is allowed to edit the course grades if they are the teacher for this course, |
||
| 31 | * or if they have explicit permission to do so |
||
| 32 | */ |
||
| 33 | Gate::define('edit-course-grades', fn ($user, $course) => $user->isTeacher() && $user->id == $course->teacher_id || $user->can('evaluation.edit')); |
||
| 34 | |||
| 35 | /* |
||
| 36 | * a user is allowed to view the course attendance sheet if they are the teacher for this course, |
||
| 37 | * or if they have explicit permission to view all course attendance sheets |
||
| 38 | */ |
||
| 39 | Gate::define('view-course-attendance', fn ($user, $course) => $user->isTeacher() && $user->id == $course->teacher_id || $user->can('attendance.view')); |
||
| 40 | |||
| 41 | /* |
||
| 42 | * a user is allowed to view the event attendance sheet if they are the teacher for this event, |
||
| 43 | * if they are the teacher for this course, |
||
| 44 | * or if they have explicit permission to view all event attendance sheets |
||
| 45 | */ |
||
| 46 | Gate::define('view-event-attendance', fn ($user, $event) => ($event->teacher_id == $user->id) || ($event->course->teacher_id == $user->id) || $user->can('attendance.view')); |
||
| 47 | |||
| 48 | /* |
||
| 49 | * a user is allowed to edit an attendance sheet if they are the teacher for the event, |
||
| 50 | * if they are the teacher for the course, |
||
| 51 | * or if they have explicit permission to edit any attendance sheets |
||
| 52 | */ |
||
| 53 | Gate::define('edit-attendance', fn ($user, $event) => ($event->teacher_id == $user->id) || ($event->course->teacher_id == $user->id) || $user->can('attendance.edit')); |
||
| 54 | |||
| 55 | /* |
||
| 56 | * teachers are allowed to view their own calendar, |
||
| 57 | * and users with explicit permission can view all calendars |
||
| 58 | */ |
||
| 59 | Gate::define('view-teacher-calendar', fn ($user, $teacher) => ($user->isTeacher() && $user->id == $teacher->id) || $user->can('calendars.view')); |
||
| 60 | |||
| 61 | /* |
||
| 62 | * teachers are allowed to view their own courses, |
||
| 63 | * and users with explicit permission can view all courses |
||
| 64 | */ |
||
| 65 | Gate::define('view-course', fn ($user, Course $course) => ($user->isTeacher() && $user->id === $course->teacher_id) || $user->can('courses.view')); |
||
| 66 | |||
| 67 | /* |
||
| 68 | * the user is allowed to view the result if they are the student, |
||
| 69 | * if they are a teacher |
||
| 70 | * of if they have explicit permission to view any result |
||
| 71 | */ |
||
| 72 | Gate::define('view-enrollment', fn ($user, $enrollment) => ($user->isStudent() && $user->id == $enrollment->student_id) || $user->isTeacher() || $user->can('evaluation.view')); |
||
| 73 | |||
| 74 | /* |
||
| 75 | * if the user is the teacher of the course |
||
| 76 | * of if they have explicit permission to enroll students |
||
| 77 | */ |
||
| 78 | Gate::define('enroll-in-course', fn ($user, $course) => $course->teacher_id == $user->id || $user->can('enrollments.edit')); |
||
| 79 | |||
| 80 | /* |
||
| 81 | * if the user is a teacher |
||
| 82 | * of if they have explicit permission to enroll students |
||
| 83 | */ |
||
| 84 | Gate::define('enroll-students', fn ($user) => $user->isTeacher() || $user->can('enrollments.edit')); |
||
| 85 | |||
| 86 | /* |
||
| 87 | * teachers are allowed to view their own hours, |
||
| 88 | * and users with explicit permission can view all hours |
||
| 89 | */ |
||
| 90 | Gate::define('view-teacher-hours', fn ($user, $teacher) => ($user->isTeacher() && $user->id == $teacher->id) || $user->can('hr.view')); |
||
| 91 | |||
| 92 | /* |
||
| 93 | * teachers are allowed to edit results for their own students |
||
| 94 | * as well as users with explicit permission to edit any result |
||
| 95 | */ |
||
| 96 | Gate::define('edit-result', function ($user, $enrollment) { |
||
| 97 | if ($user->can('evaluation.edit')) { |
||
| 98 | return true; |
||
| 99 | } |
||
| 100 | |||
| 101 | if (config('settings.teachers_can_edit_result')) { |
||
| 102 | return ($user->isTeacher() && $user->id === $enrollment->course->teacher_id); |
||
| 103 | } |
||
| 104 | |||
| 105 | return false; |
||
| 106 | }); |
||
| 109 |
