ScheduledPaymentController::bill() - Code Metrics - academico-sis/academico - Measure and Improve Code Quality continuously with Scrutinizer

ScheduledPaymentController::bill() A
last analyzed 2022-02-16 19:55 UTC

↳ Parent: ScheduledPaymentController

Complexity

Conditions	3
Paths	4

Size

Total Lines	60
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	3
eloc	38
c	1
b	0
f	1
nc	4
nop	1
dl	0
loc	60
rs	9.312

How to fix Long Method

<?php

namespace App\Http\Controllers;

use App\Models\Book;
use App\Models\Discount;
use App\Models\Enrollment;
use App\Models\Fee;
use App\Models\InvoiceType;
use App\Models\Paymentmethod;
use App\Models\ScheduledPayment;
use App\Models\Tax;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;

class ScheduledPaymentController extends Controller
{
    public function create(Enrollment $enrollment)
    {
        return view('invoices.create_scheduled_payments', [
            'enrollment' => $enrollment,
        ]);
    }

    public function store(Enrollment $enrollment, Request $request)
    {
        // Should only be used to create payments, not to edit them.
        foreach ($request->payments as $p => $payment) {
            $enrollment->scheduledPayments()->create([
                'responsable_id' => backpack_user()->id,

                'value' => $payment['value'],
                'date' => $payment['date'],
                'status' => 1,
            ]);
        }
    }

    /**
     * Create a new cart with the specified payment
     * and display the cart.
     */
    public function bill(ScheduledPayment $scheduledPayment)
    {
        // otherwise create a new one.
        Log::info('User # '.backpack_user()->id.' is generating a invoice for a scheduled payment');


        // build an array with products to include
        $products = [];

        $enrollment = $scheduledPayment->enrollment;

        array_push($products, [
            'name' => $enrollment->name,
            'product_code' => $enrollment->product_code,
            'type' => 'scheduledPayment',
            'price' => $scheduledPayment->value,
            'quantity' => 1,
            'id' => $scheduledPayment->id,
        ]);

        // build an array with all contact data
        $clients = [];

        array_push($clients, [
            'name' => $enrollment->student_name,
            'email' => $enrollment->student_email,
            'idnumber' => $enrollment->student->idnumber,
            'address' => $enrollment->student->address,
            'phone' => $enrollment->student->phone,
        ]);

        foreach ($enrollment->student->contacts as $client) {
            array_push($clients, $client);
        }

        $data = [
            'enrollment' => $enrollment,
            'products' => $products,
            'invoicetypes' => InvoiceType::all(),
            'clients' => $clients,
            'availableBooks' => Book::all(),
            'availableFees' => Fee::all(),
            'availableDiscounts' => Discount::all(),
            'availablePaymentMethods' => Paymentmethod::all(),
            'availableTaxes' => Tax::all(),
        ];
        if (config('invoicing.price_categories_enabled')) {
            $data = array_merge(
                $data,
                [
                    'priceCategories' => collect([
                        'price_a' => $enrollment->course->price,
                        'price_b' => $enrollment->course->price_b,
                        'price_c' => $enrollment->course->price_c,
                    ]),
                    'studentPriceCategory' => $enrollment->student?->price_category,
                ]
            );
        }

        return view('carts.show', $data);
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Models\Book;
6			use App\Models\Discount;
7			use App\Models\Enrollment;
8			use App\Models\Fee;
9			use App\Models\InvoiceType;
10			use App\Models\Paymentmethod;
11			use App\Models\ScheduledPayment;
12			use App\Models\Tax;
13			use Illuminate\Http\Request;
14			use Illuminate\Support\Facades\Log;
15
16			class ScheduledPaymentController extends Controller
17			{
18			public function create(Enrollment $enrollment)
19			{
20			return view('invoices.create_scheduled_payments', [
21			'enrollment' => $enrollment,
22			]);
23			}
24
25			public function store(Enrollment $enrollment, Request $request)
26			{
27			// Should only be used to create payments, not to edit them.
28			foreach ($request->payments as $p => $payment) {
29			$enrollment->scheduledPayments()->create([
30			'responsable_id' => backpack_user()->id,
			0 ignored issues – show Bug introduced 2021-09-06 09:46 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
31			'value' => $payment['value'],
32			'date' => $payment['date'],
33			'status' => 1,
34			]);
35			}
36			}
37
38			/**
39			* Create a new cart with the specified payment
40			* and display the cart.
41			*/
42			public function bill(ScheduledPayment $scheduledPayment)
43			{
44			// otherwise create a new one.
45			Log::info('User # '.backpack_user()->id.' is generating a invoice for a scheduled payment');
			0 ignored issues – show Bug introduced 2021-09-06 09:46 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
46
47			// build an array with products to include
48			$products = [];
49
50			$enrollment = $scheduledPayment->enrollment;
51
52			array_push($products, [
53			'name' => $enrollment->name,
54			'product_code' => $enrollment->product_code,
55			'type' => 'scheduledPayment',
56			'price' => $scheduledPayment->value,
57			'quantity' => 1,
58			'id' => $scheduledPayment->id,
59			]);
60
61			// build an array with all contact data
62			$clients = [];
63
64			array_push($clients, [
65			'name' => $enrollment->student_name,
66			'email' => $enrollment->student_email,
67			'idnumber' => $enrollment->student->idnumber,
68			'address' => $enrollment->student->address,
69			'phone' => $enrollment->student->phone,
70			]);
71
72			foreach ($enrollment->student->contacts as $client) {
73			array_push($clients, $client);
74			}
75
76			$data = [
77			'enrollment' => $enrollment,
78			'products' => $products,
79			'invoicetypes' => InvoiceType::all(),
80			'clients' => $clients,
81			'availableBooks' => Book::all(),
82			'availableFees' => Fee::all(),
83			'availableDiscounts' => Discount::all(),
84			'availablePaymentMethods' => Paymentmethod::all(),
85			'availableTaxes' => Tax::all(),
86			];
87			if (config('invoicing.price_categories_enabled')) {
88			$data = array_merge(
89			$data,
90			[
91			'priceCategories' => collect([
92			'price_a' => $enrollment->course->price,
93			'price_b' => $enrollment->course->price_b,
94			'price_c' => $enrollment->course->price_c,
95			]),
96			'studentPriceCategory' => $enrollment->student?->price_category,
97			]
98			);
99			}
100
101			return view('carts.show', $data);
102			}
103			}
104

academico-sis / academico

ScheduledPaymentController::bill() A last analyzed 2022-02-16 19:55 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

ScheduledPaymentController::bill() A
last analyzed 2022-02-16 19:55 UTC