App\Services\Ecuasolutions

Complexity

Total Complexity

8

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	status()	0	4	1
B	saveInvoice()	0	93	7

<?php

namespace App\Services;

use App\Interfaces\InvoicingInterface;
use App\Models\Book;
use App\Models\Enrollment;
use App\Models\Fee;
use App\Models\Invoice;
use GuzzleHttp\Client;
use Illuminate\Support\Facades\Log;

class Ecuasolutions implements InvoicingInterface
{
    public function status(): bool
    {
        // TODO : need to find another solution to ping the server before making the request
        return true;
    }

    public function saveInvoice(Invoice $invoice): ?string
    {
        $ivkardex = [];
        $pckardex = [];

        foreach ($invoice->payments as $p => $payment) {
            $pckardex[$p] = [
                'codforma' => $payment->payment_method,
                'valor' => $payment->value,
                'fechaemision' => $invoice->created_at,
                'fechavenci' => $invoice->created_at,
                'observacion' => $payment->comment,
                'codprovcli' => $invoice->client_idnumber,
            ];
        }

        foreach ($invoice->invoiceDetails as $po => $product) {
            if ($product->product instanceof Enrollment) {
                $ivkardex[] = [
                    'codinventario' => $product->product_code,
                    'codbodega' => 'MAT',
                    'cantidad' => 1,
                    'descuento' => 0,
                    'iva' => 0,
                    'preciototal' => $product->final_price,
                    'valoriva' => 0,
                ];
            } elseif ($product->product instanceof Fee) {
                $ivkardex[] = [
                    'codinventario' => $product->product_code,
                    'codbodega' => 'MAT',
                    'cantidad' => 1,
                    'descuento' => 0,
                    'iva' => 0,
                    'preciototal' => $product->final_price,
                    'valoriva' => 0,
                ];
            } elseif ($product->product instanceof Book) {
                $ivkardex[] = [
                    'codinventario' => $product->product_code,
                    'codbodega' => 'MAT',
                    'cantidad' => 1,
                    'descuento' => 0,
                    'iva' => 0,
                    'preciototal' => $product->final_price,
                    'valoriva' => 0,
                ];
            }
        }

        $body = [
            'codtrans' => 'FE',
            // was 'OP'
            'numtrans' => $invoice->id,
            'fechatrans' => $invoice->created_at,
            'horatrans' => $invoice->created_at,
            'descripcion' => 'Facturado desde el academico por '.backpack_user()->firstname.' '.backpack_user()->lastname,

Accessing firstname on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing lastname on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            'codusuario' => 'web',
            'codprovcli' => $invoice->client_idnumber,
            // si existe, se busca el cliente. Si no lo creamos.
            'nombre' => $invoice->client_name,
            'direccion' => $invoice->client_address,
            'telefono' => $invoice->client_phone,
            'email' => $invoice->client_email,
            'codvendedor' => '',
            'ivkardex' => $ivkardex,
            'pckardex' => $pckardex,
        ];

        $client = new Client(['debug' => true,
            'connect_timeout' => 20, ]);

        $serverurl = config('invoicing.ecuasolutions.url');

        Log::info($body);

        $response = $client->post($serverurl, [
            'headers' => [
                'authorization' => config('invoicing.ecuasolutions.key'),
                'Content-Type' => 'application/json',
            ],
            'json' => $body,
        ]);

        Log::info('Sending data to accounting');

        if ($response->getBody()) {
            $code = json_decode(preg_replace('/[\\x00-\\x1F\\x80-\\xFF]/', '', $response->getBody()), true, 512, JSON_THROW_ON_ERROR);
        }

        Log::info($response->getBody());

        return $code['mensaje'] ?? null;
    }
}