App\Http\Controllers\HRController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	27	6
A	teacher()	0	13	2

<?php

namespace App\Http\Controllers;

use App\Models\Teacher;
use App\Traits\PeriodSelection;
use Carbon\Carbon;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Gate;
use Illuminate\Support\Facades\Log;

class HRController extends Controller
{
    use PeriodSelection;

The trait App\Traits\PeriodSelection requires the property $id which is not provided by App\Http\Controllers\HRController.

    public function __construct()
    {
        parent::__construct();
        $this->middleware('permission:hr.view', ['except' => 'teacher']);
    }

    /**
     * Display a listing of the resource.
     */
    public function index(Request $request)
    {
        $period = $this->selectPeriod($request);

        $teachers = Teacher::with('remote_events')->with('events')->with('courses')->get();

        $report_start_date = $request->report_start_date ? Carbon::parse($request->report_start_date) : Carbon::parse($period->start);
        $report_end_date = $request->report_end_date ? Carbon::parse($request->report_end_date) : Carbon::parse($period->end);

        // if we are dealing with a complete period, add theoretical volumes
        if (! $request->report_start_date && ! $request->report_end_date) {
            // ensure the report end date is not before the end date to avoid inconsistent results.
            $report_end_date = $report_start_date->max($report_end_date);

            foreach ($teachers as $teacher) {
                $teacher->remoteVolume = $teacher->courses()->realcourses()->where('period_id', $period->id)->sum('remote_volume');

The property remoteVolume does not seem to exist on App\Models\Teacher. Are you sure there is no database migration missing?

                $teacher->volume = $teacher->courses()->realcourses()->where('period_id', $period->id)->sum('volume');

The property volume does not seem to exist on App\Models\Teacher. Are you sure there is no database migration missing?

            }
        }

        Log::info('HR Dahsboard viewed by '.backpack_user()->firstname);

Accessing firstname on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return view('hr.dashboard', [
            'selected_period' => $period,
            'teachers' => $teachers,
            'start' => $report_start_date->format('Y-m-d'),
            'end' => $report_end_date->format('Y-m-d'),
        ]);
    }

    public function teacher(Request $request, Teacher $teacher)
    {
        // If the user is not allowed to perform this action
        if (Gate::forUser(backpack_user())->denies('view-teacher-hours', $teacher)) {
            abort(403);
        }

        $period = $this->selectPeriod($request);

        return view('teacher.hours', [
            'selected_period' => $period,
            'teacher' => $teacher,
            'events' => $teacher->period_events($period),
        ]);
    }
}