Issues in APIFullUsersController.php (master) - Issues in master - acacha/users - Measure and Improve Code Quality continuously with Scrutinizer

Issues (64)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Http/Controllers/APIFullUsersController.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Acacha\Users\Http\Controllers;

use Acacha\Users\Events\UserCreated;
use Acacha\Users\Events\UserRemoved;
use Acacha\Users\Http\Requests\CreateUserRequest;
use Acacha\Users\Http\Requests\MassiveDestroyRequest;
use Acacha\Users\Http\Requests\UpdateUserRequest;
use App\User;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Password;
use Response;

/**
 * Class APIFullUsersController
 *
 * @package Acacha\Users\Http\Controllers
 */
class APIFullUsersController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $this->authorize('list-users');
        return User::paginate();
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param CreateUserRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(CreateUserRequest $request)
    {
        $user = User::create([
            'name' => $request->input('name'),
            'email' => $request->input('email'),
            'password' => bcrypt($request->input('password')),

        ]);

        event(new UserCreated($user));

        return Response::json(['created' => true ]);
    }

    /**
     * Massive destroy.
     *
     * @param MassiveDestroyRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function massiveDestroy(MassiveDestroyRequest $request)
    {
        $this->authorize('massive-delete-users');
        return $this->executeDestroy($request->input('ids'));
    }

    /**
     * Execute destroy.
     *
     * @param $ids
     * @return \Illuminate\Http\JsonResponse
     */
    private function executeDestroy($ids){


        $models = User::find($ids);

        User::destroy($ids);

        event(new UserRemoved($models->toJson()));

        return Response::json(['deleted' => true ]);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int|array  $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy($id)
    {
        $this->authorize('delete-users');

        return $this->executeDestroy($id);
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $this->authorize('view-users');
        return User::find($id);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param UpdateUserRequest $request
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function update(UpdateUserRequest $request, $id)
    {
        $user = User::find($id);
        $user->update($request->intersect(['email','name','password']));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return Response::json(['updated' => true ]);
    }

    /**
     * Register user by email
     *
     * @param Request $request
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function registerByEmail(Request $request)

    {
        $data = [];
        return view('acacha_users::register-by-email',$data);
    }

}

1		<?php
2
3		namespace Acacha\Users\Http\Controllers;
4
5		use Acacha\Users\Events\UserCreated;
6		use Acacha\Users\Events\UserRemoved;
7		use Acacha\Users\Http\Requests\CreateUserRequest;
8		use Acacha\Users\Http\Requests\MassiveDestroyRequest;
9		use Acacha\Users\Http\Requests\UpdateUserRequest;
10		use App\User;
11		use Illuminate\Http\JsonResponse;
12		use Illuminate\Http\Request;
13		use Password;
14		use Response;
15
16		/**
17		* Class APIFullUsersController
18		*
19		* @package Acacha\Users\Http\Controllers
20		*/
21		class APIFullUsersController extends Controller
22		{
23		/**
24		* Display a listing of the resource.
25		*
26		* @return \Illuminate\Http\Response
27		*/
28		public function index()
29		{
30		$this->authorize('list-users');
31		return User::paginate();
32		}
33
34		/**
35		* Store a newly created resource in storage.
36		*
37		* @param CreateUserRequest $request
38		* @return \Illuminate\Http\JsonResponse
39		*/
40		public function store(CreateUserRequest $request)
41		{
42		$user = User::create([
43		'name' => $request->input('name'),
44		'email' => $request->input('email'),
45		'password' => bcrypt($request->input('password')),
		0 ignored issues – show Bug introduced 2017-06-07 13:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$request->input('password')` targeting `Illuminate\Http\Concerns...ractsWithInput::input()` can also be of type `array`; however, `bcrypt()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
46		]);
47
48		event(new UserCreated($user));
49
50		return Response::json(['created' => true ]);
51		}
52
53		/**
54		* Massive destroy.
55		*
56		* @param MassiveDestroyRequest $request
57		* @return \Illuminate\Http\JsonResponse
58		*/
59		public function massiveDestroy(MassiveDestroyRequest $request)
60		{
61		$this->authorize('massive-delete-users');
62		return $this->executeDestroy($request->input('ids'));
63		}
64
65		/**
66		* Execute destroy.
67		*
68		* @param $ids
69		* @return \Illuminate\Http\JsonResponse
70		*/
71	View Code Duplication	private function executeDestroy($ids){
		0 ignored issues – show Duplication introduced 2017-12-02 17:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72
73		$models = User::find($ids);
74
75		User::destroy($ids);
76
77		event(new UserRemoved($models->toJson()));
78
79		return Response::json(['deleted' => true ]);
80		}
81
82		/**
83		* Remove the specified resource from storage.
84		*
85		* @param int\|array $id
86		* @return \Illuminate\Http\JsonResponse
87		*/
88		public function destroy($id)
89		{
90		$this->authorize('delete-users');
91
92		return $this->executeDestroy($id);
93		}
94
95		/**
96		* Display the specified resource.
97		*
98		* @param int $id
99		* @return \Illuminate\Http\Response
100		*/
101		public function show($id)
102		{
103		$this->authorize('view-users');
104		return User::find($id);
105		}
106
107		/**
108		* Update the specified resource in storage.
109		*
110		* @param UpdateUserRequest $request
111		* @param $id
112		* @return \Illuminate\Http\JsonResponse
113		*/
114		public function update(UpdateUserRequest $request, $id)
115		{
116		$user = User::find($id);
117		$user->update($request->intersect(['email','name','password']));
		0 ignored issues – show Documentation Bug introduced 2017-09-03 18:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `intersect` does not exist on `object<Acacha\Users\Http...ests\UpdateUserRequest>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
118		return Response::json(['updated' => true ]);
119		}
120
121		/**
122		* Register user by email
123		*
124		* @param Request $request
125		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
126		*/
127		public function registerByEmail(Request $request)
		0 ignored issues – show Unused Code introduced 2017-09-03 18:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
128		{
129		$data = [];
130		return view('acacha_users::register-by-email',$data);
131		}
132
133		}

acacha / users

Issues (64)

Security Analysis not enabled

src/Http/Controllers/APIFullUsersController.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like