HasUserMigrations::scopeMigrated() - Code Metrics - Inspection of "Sync" - acacha/users - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 58043b...413e7c )

by Sergi Tur

created 2017-06-27 08:36 UTC

HasUserMigrations::scopeMigrated() A

↳ Parent: HasUserMigrations

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	1
b	0
f	0

<?php

namespace Acacha\Users\Traits;

use Acacha\Users\Models\UserMigration;

/**
 * Class HasUserMigrations.
 *
 * @package Acacha\Users\Traits
 */
trait HasUserMigrations
{
    /**
     * Scope a query to only include migrated users.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeMigrated($query)
    {
        return $query->has('migration');
    }

    /**
     * Get the user migration record associated with the user.
     */
    public function migration()
    {
        return $this->hasOne(UserMigration::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}

1			<?php
2
3			namespace Acacha\Users\Traits;
4
5			use Acacha\Users\Models\UserMigration;
6
7			/**
8			* Class HasUserMigrations.
9			*
10			* @package Acacha\Users\Traits
11			*/
12			trait HasUserMigrations
13			{
14			/**
15			* Scope a query to only include migrated users.
16			*
17			* @param \Illuminate\Database\Eloquent\Builder $query
18			* @return \Illuminate\Database\Eloquent\Builder
19			*/
20			public function scopeMigrated($query)
21			{
22			return $query->has('migration');
23			}
24
25			/**
26			* Get the user migration record associated with the user.
27			*/
28			public function migration()
29			{
30			return $this->hasOne(UserMigration::class);
			0 ignored issues – show Bug introduced 2017-06-07 13:37 UTC by Report Bug Copy Issue Report It seems like `hasOne()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			}
32			}

acacha / users

Push — master ( 58043b...413e7c )

HasUserMigrations::scopeMigrated() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like