ProgressBatch - Code Metrics - Inspection of "Sync" - acacha/users - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 58043b...413e7c )

by Sergi Tur

created 2017-06-27 08:36 UTC

ProgressBatch A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	60
rs	10
c	1
b	0
f	0
wmc	4
lcom	0
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	validateFinish()	0	5	3
A	progressable()	0	4	1

<?php

namespace Acacha\Users\Models;

use Acacha\Stateful\Contracts\Stateful;
use Acacha\Stateful\Traits\StatefulTrait;
use Illuminate\Database\Eloquent\Model;

/**
 * Class ProgressBatch.
 *
 * @package Acacha\Users\Models
 */
class ProgressBatch extends Model implements Stateful
{
    use StatefulTrait;

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = ['state', 'accomplished','incidences'];

    /**
     * Progress States
     *
     * @var array
     */
    protected $states = [
        'pending'  => ['initial' => true],
        'stopped' ,
        'finished' => ['final' => true]
    ];

    /**
     * Transaction State Transitions
     *
     * @var array
     */
    protected $transitions = [
        'stop' => [
            'from' => ['pending'],
            'to' => 'stopped'
        ],
        'resume' => [
            'from' => ['stopped'],
            'to' => 'pending'
        ],
        'finish' => [
            'from' => ['pending'],
            'to' => 'finished'
        ]
    ];

    /**
     * @return bool
     */
    protected function validateFinish()
    {
        if ( ( $this->accomplished != 0 ) || ( $this->incidences !=0 ) ) return true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        return false;
    }

    /**
     * Get the progressable associated to this batch.
     */
    public function progressable()
    {
        return $this->hasMany(UserMigration::class);
    }

}



1			<?php
2
3			namespace Acacha\Users\Models;
4
5			use Acacha\Stateful\Contracts\Stateful;
6			use Acacha\Stateful\Traits\StatefulTrait;
7			use Illuminate\Database\Eloquent\Model;
8
9			/**
10			* Class ProgressBatch.
11			*
12			* @package Acacha\Users\Models
13			*/
14			class ProgressBatch extends Model implements Stateful
15			{
16			use StatefulTrait;
17
18			/**
19			* The attributes that are mass assignable.
20			*
21			* @var array
22			*/
23			protected $fillable = ['state', 'accomplished','incidences'];
24
25			/**
26			* Progress States
27			*
28			* @var array
29			*/
30			protected $states = [
31			'pending' => ['initial' => true],
32			'stopped' ,
33			'finished' => ['final' => true]
34			];
35
36			/**
37			* Transaction State Transitions
38			*
39			* @var array
40			*/
41			protected $transitions = [
42			'stop' => [
43			'from' => ['pending'],
44			'to' => 'stopped'
45			],
46			'resume' => [
47			'from' => ['stopped'],
48			'to' => 'pending'
49			],
50			'finish' => [
51			'from' => ['pending'],
52			'to' => 'finished'
53			]
54			];
55
56			/**
57			* @return bool
58			*/
59			protected function validateFinish()
60			{
61			if ( ( $this->accomplished != 0 ) \|\| ( $this->incidences !=0 ) ) return true;
			0 ignored issues – show Documentation introduced 2017-06-27 08:43 UTC by Report Bug Copy Issue Report The property `accomplished` does not exist on `object<Acacha\Users\Models\ProgressBatch>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-06-27 08:43 UTC by Report Bug Copy Issue Report The property `incidences` does not exist on `object<Acacha\Users\Models\ProgressBatch>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
62			return false;
63			}
64
65			/**
66			* Get the progressable associated to this batch.
67			*/
68			public function progressable()
69			{
70			return $this->hasMany(UserMigration::class);
71			}
72
73			}
74
75

acacha / users

Push — master ( 58043b...413e7c )

ProgressBatch A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like