Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | View Code Duplication | class UserHasBeenMigrated implements ShouldBroadcast |
|
|
|||
17 | { |
||
18 | use Dispatchable, InteractsWithSockets, SerializesModels; |
||
19 | |||
20 | /** |
||
21 | * Source user id. |
||
22 | * |
||
23 | * @var |
||
24 | */ |
||
25 | public $sourceUserId; |
||
26 | |||
27 | /** |
||
28 | * Source user. |
||
29 | * |
||
30 | * @var |
||
31 | */ |
||
32 | public $sourceUser; |
||
33 | |||
34 | /** |
||
35 | * New user. |
||
36 | * |
||
37 | * @var |
||
38 | */ |
||
39 | public $newUser; |
||
40 | |||
41 | /** |
||
42 | * User migration batch id. |
||
43 | * |
||
44 | * @var |
||
45 | */ |
||
46 | public $user_migration_batch_id; |
||
47 | |||
48 | /** |
||
49 | * Broadcast channel name. |
||
50 | * |
||
51 | * @var string |
||
52 | */ |
||
53 | protected $channelName = 'users-migration'; |
||
54 | |||
55 | /** |
||
56 | * @return string |
||
57 | */ |
||
58 | public function getChannelName() |
||
62 | |||
63 | /** |
||
64 | * @param string $channelName |
||
65 | */ |
||
66 | public function setChannelName($channelName) |
||
70 | |||
71 | /** |
||
72 | * UserHasBeenMigrated constructor. |
||
73 | * |
||
74 | * @param $sourceUserId |
||
75 | * @param $sourceUser |
||
76 | * @param $newUser |
||
77 | * @param $user_migration_batch_id |
||
78 | */ |
||
79 | public function __construct($sourceUserId, $sourceUser, $newUser, $user_migration_batch_id) |
||
86 | |||
87 | /** |
||
88 | * Get the channels the event should broadcast on. |
||
89 | * |
||
90 | * @return Channel|array |
||
91 | */ |
||
92 | public function broadcastOn() |
||
96 | } |
||
97 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.