Acacha\Users\Http\Controllers\UsersMigrationController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	6	1
A	totalNumberOfUsers()	0	5	1
A	migrate()	0	13	2
A	usersToMigrateByRequest()	0	6	3
A	usersToMigrate()	0	4	1
A	usersToMigrateByFilter()	0	4	1
A	allUsers()	0	4	1

<?php

namespace Acacha\Users\Http\Controllers;

use Acacha\Users\Events\UserMigrationStatusUpdated;
use Acacha\Users\Http\Requests\UsersMigrationRequest;

/**
 * Class UsersMigrationController.
 *
 * @package App\Http\Controllers
 */
class UsersMigrationController extends Controller
{
    /**
     * Show users migration.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index()
    {
        $this->authorize('migrate-users');
        $data = [];
        return view('acacha_users::users-migration',$data);
    }

    /**
     * Get total number of users in source migration database.
     */
    public function totalNumberOfUsers()
    {
        $this->authorize('migrate-users');
        return [ 'data' => 68 ];
    }

    /**
     * Migrate multiple users.
     *
     */
    public function migrate(UsersMigrationRequest $request)
    {
        $usersToMigrate = $this->usersToMigrateByRequest($request);
        dd($usersToMigrate);
        $progress= 0;
        foreach ($usersToMigrate as $user ) {

The expression $usersToMigrate of type null|object<Illuminate\Database\Eloquent\Collection>|array<integer,object<Acacha\Users\Http\Controllers\UsersMigrationController>> is not guaranteed to be traversable. How about adding an additional type check?

            event(new UserMigrationStatusUpdated($user, $progress));
            sleep(1);
            dump ('User ' . $user . ' migrated!');
            $progress = $progress + 50;
        }
        event(new UserMigrationStatusUpdated('Finish!', $progress));
    }


    /**
     * Get users to migrate.
     *
     * @param $request
     */
    protected function usersToMigrateByRequest($request)
    {
        if ($users = $request->has('users')) return $this->usersToMigrate($users, $request);
        if ($filter = $request->has('filter')) return $this->usersToMigrateByFilter($filter, $request);
        return $this->allUsers($request);
    }

    /**
     * Users to migrate by user id list.
     *
     * @param $users
     */
    protected function usersToMigrate($users, $request)

The parameter $users is not used and could be removed.

The parameter $request is not used and could be removed.

    {

    }

    /**
     * Users to migrate by filter.
     *
     * @param $filter
     */
    protected function usersToMigrateByFilter($filter, $request)

The parameter $filter is not used and could be removed.

The parameter $request is not used and could be removed.

    {

    }

    /**
     * Get all valid users.
     *
     * @param $request
     * @return \Illuminate\Database\Eloquent\Collection|static[]
     */
    protected function allUsers($request)

The parameter $request is not used and could be removed.

    {
        return \Scool\EbreEscoolModel\User::all();
    }
}