APIUsersController::update() - Code Metrics - acacha/users - Measure and Improve Code Quality continuously with Scrutinizer

APIUsersController::update() A
last analyzed 2017-12-18 15:48 UTC

↳ Parent: APIUsersController

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	4
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	6
rs	9.4285

<?php

namespace Acacha\Users\Http\Controllers;

use Acacha\Users\Events\UserCreated;
use Acacha\Users\Events\UserRemoved;
use Acacha\Users\Http\Requests\CreateUserRequest;
use Acacha\Users\Http\Requests\MassiveDestroyRequest;
use Acacha\Users\Http\Requests\UpdateUserRequest;
use App\User;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Password;
use Response;

/**
 * Class APIUsersController
 *
 * @package Acacha\Users\Http\Controllers
 */
class APIUsersController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $this->authorize('list-users');
        return User::all();
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param CreateUserRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(CreateUserRequest $request)
    {
        $user = User::create([
            'name' => $request->input('name'),
            'email' => $request->input('email'),
            'password' => bcrypt($request->input('password')),

        ]);

        event(new UserCreated($user));

        return $user;
    }

    /**
     * Massive destroy.
     *
     * @param MassiveDestroyRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function massiveDestroy(MassiveDestroyRequest $request)
    {
        $this->authorize('massive-delete-users');
        return $this->executeDestroy($request->input('ids'));
    }

    /**
     * Execute destroy.
     *
     * @param $ids
     * @return \Illuminate\Http\JsonResponse
     */
    private function executeDestroy($ids){


        $models = User::find($ids);

        User::destroy($ids);

        event(new UserRemoved($models->toJson()));

        return Response::json(['deleted' => true ]);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int|array  $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy($id)
    {
        $this->authorize('delete-users');

        return $this->executeDestroy($id);
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $this->authorize('view-users');
        return User::find($id);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param UpdateUserRequest $request
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function update(UpdateUserRequest $request, $id)
    {
        $user = User::find($id);
        $user->update($request->intersect(['email','name','password']));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return Response::json(['updated' => true ]);
    }

    /**
     * Register user by email
     *
     * @param Request $request
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function registerByEmail(Request $request)

    {
        $data = [];
        return view('acacha_users::register-by-email',$data);
    }

    /**
     * Send a reset link to the given user.
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function sendResetLinkEmail(Request $request)

    {
        $this->validate($request, ['email' => 'required|email']);

        $response = Password::broker()->sendResetLink(
            $request->only('email')
        );

        if (Password::RESET_LINK_SENT) {
            return new JsonResponse(['status' => trans($response) ], 200);
        }

        return new JsonResponse(['email' => trans($response) ], 422);

    }

    /**
     * Send a reset link to the given users.
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function massiveSendResetLinkEmail(Request $request)

    {
        $this->validate($request, ['ids' => 'required']);

        $errors = [];
        foreach ($request->input('ids') as $id) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $user = User::find($id);
            $response = Password::broker()->sendResetLink([ 'email' => $user->email ]);
            if (! Password::RESET_LINK_SENT) {
                dd('ERROR!');
                $errors[] = $response;
            }
        }

        if ( count($errors) > 0 ) return new JsonResponse(['status' => 'Error', 'errors' => $errors ], 422);

        return new JsonResponse(['status' => 'Done' ], 200);
    }

}

1		<?php
2
3		namespace Acacha\Users\Http\Controllers;
4
5		use Acacha\Users\Events\UserCreated;
6		use Acacha\Users\Events\UserRemoved;
7		use Acacha\Users\Http\Requests\CreateUserRequest;
8		use Acacha\Users\Http\Requests\MassiveDestroyRequest;
9		use Acacha\Users\Http\Requests\UpdateUserRequest;
10		use App\User;
11		use Illuminate\Http\JsonResponse;
12		use Illuminate\Http\Request;
13		use Password;
14		use Response;
15
16		/**
17		* Class APIUsersController
18		*
19		* @package Acacha\Users\Http\Controllers
20		*/
21		class APIUsersController extends Controller
22		{
23		/**
24		* Display a listing of the resource.
25		*
26		* @return \Illuminate\Http\Response
27		*/
28		public function index()
29		{
30		$this->authorize('list-users');
31		return User::all();
32		}
33
34		/**
35		* Store a newly created resource in storage.
36		*
37		* @param CreateUserRequest $request
38		* @return \Illuminate\Http\JsonResponse
39		*/
40		public function store(CreateUserRequest $request)
41		{
42		$user = User::create([
43		'name' => $request->input('name'),
44		'email' => $request->input('email'),
45		'password' => bcrypt($request->input('password')),
		0 ignored issues – show Bug introduced 2017-12-02 17:12 UTC by Report Bug Copy Issue Report It seems like `$request->input('password')` targeting `Illuminate\Http\Concerns...ractsWithInput::input()` can also be of type `array`; however, `bcrypt()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
46		]);
47
48		event(new UserCreated($user));
49
50		return $user;
51		}
52
53		/**
54		* Massive destroy.
55		*
56		* @param MassiveDestroyRequest $request
57		* @return \Illuminate\Http\JsonResponse
58		*/
59		public function massiveDestroy(MassiveDestroyRequest $request)
60		{
61		$this->authorize('massive-delete-users');
62		return $this->executeDestroy($request->input('ids'));
63		}
64
65		/**
66		* Execute destroy.
67		*
68		* @param $ids
69		* @return \Illuminate\Http\JsonResponse
70		*/
71	View Code Duplication	private function executeDestroy($ids){
		0 ignored issues – show Duplication introduced 2017-12-02 17:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72
73		$models = User::find($ids);
74
75		User::destroy($ids);
76
77		event(new UserRemoved($models->toJson()));
78
79		return Response::json(['deleted' => true ]);
80		}
81
82		/**
83		* Remove the specified resource from storage.
84		*
85		* @param int\|array $id
86		* @return \Illuminate\Http\JsonResponse
87		*/
88		public function destroy($id)
89		{
90		$this->authorize('delete-users');
91
92		return $this->executeDestroy($id);
93		}
94
95		/**
96		* Display the specified resource.
97		*
98		* @param int $id
99		* @return \Illuminate\Http\Response
100		*/
101		public function show($id)
102		{
103		$this->authorize('view-users');
104		return User::find($id);
105		}
106
107		/**
108		* Update the specified resource in storage.
109		*
110		* @param UpdateUserRequest $request
111		* @param $id
112		* @return \Illuminate\Http\JsonResponse
113		*/
114		public function update(UpdateUserRequest $request, $id)
115		{
116		$user = User::find($id);
117		$user->update($request->intersect(['email','name','password']));
		0 ignored issues – show Documentation Bug introduced 2017-12-02 17:12 UTC by Report Bug Copy Issue Report The method `intersect` does not exist on `object<Acacha\Users\Http...ests\UpdateUserRequest>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
118		return Response::json(['updated' => true ]);
119		}
120
121		/**
122		* Register user by email
123		*
124		* @param Request $request
125		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
126		*/
127		public function registerByEmail(Request $request)
		0 ignored issues – show Unused Code introduced 2017-12-02 17:12 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
128		{
129		$data = [];
130		return view('acacha_users::register-by-email',$data);
131		}
132
133		/**
134		* Send a reset link to the given user.
135		*
136		* @param Request $request
137		* @return JsonResponse
138		*/
139	View Code Duplication	public function sendResetLinkEmail(Request $request)
		0 ignored issues – show Duplication introduced 2017-12-02 17:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
140		{
141		$this->validate($request, ['email' => 'required\|email']);
142
143		$response = Password::broker()->sendResetLink(
144		$request->only('email')
145		);
146
147		if (Password::RESET_LINK_SENT) {
148		return new JsonResponse(['status' => trans($response) ], 200);
149		}
150
151		return new JsonResponse(['email' => trans($response) ], 422);
152
153		}
154
155		/**
156		* Send a reset link to the given users.
157		*
158		* @param Request $request
159		* @return JsonResponse
160		*/
161	View Code Duplication	public function massiveSendResetLinkEmail(Request $request)
		0 ignored issues – show Duplication introduced 2017-12-02 17:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
162		{
163		$this->validate($request, ['ids' => 'required']);
164
165		$errors = [];
166		foreach ($request->input('ids') as $id) {
		0 ignored issues – show Bug introduced 2017-12-02 17:12 UTC by Report Bug Copy Issue Report The expression `$request->input('ids')` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
167		$user = User::find($id);
168		$response = Password::broker()->sendResetLink([ 'email' => $user->email ]);
169		if (! Password::RESET_LINK_SENT) {
170		dd('ERROR!');
171		$errors[] = $response;
172		}
173		}
174
175		if ( count($errors) > 0 ) return new JsonResponse(['status' => 'Error', 'errors' => $errors ], 422);
176
177		return new JsonResponse(['status' => 'Done' ], 200);
178		}
179
180		}

acacha / users

APIUsersController::update() A last analyzed 2017-12-18 15:48 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

APIUsersController::update() A
last analyzed 2017-12-18 15:48 UTC