Serve::serve() - Code Metrics - Inspection of "Multiple refactorings" - acacha/llum - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b3b6a4...b2f402 )

by Sergi Tur

created 2016-03-15 18:56 UTC

Serve::serve() A

↳ Parent: Serve

Complexity

Conditions	4
Paths	3

Size

Total Lines	17
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
rs	9.2
cc	4
eloc	13
nc	3
nop	1

<?php

namespace Acacha\Llum\Traits;

trait Serve
{
    /**
     * Serve command.
     *
     * @param int $port
     */
    protected function serve($port = 8000)
    {
        $continue = true;
        do {
            if ($this->check_port($port)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $this->output->writeln('<info>Running php artisan serve --port='.$port.'</info>');
class MyClass { }

$x = new MyClass();
$x->foo = true;
                exec('php artisan serve --port='.$port.' > /dev/null 2>&1 &');
                sleep(1);
                if (file_exists('/usr/bin/sensible-browser')) {
                    $this->output->writeln('<info>Opening http://localhost:'.$port.' with default browser</info>');
                    passthru('/usr/bin/sensible-browser http://localhost:'.$port);
                }
                $continue = false;
            }
            ++$port;
        } while ($continue);
    }
}


1			<?php
2
3			namespace Acacha\Llum\Traits;
4
5			trait Serve
6			{
7			/**
8			* Serve command.
9			*
10			* @param int $port
11			*/
12			protected function serve($port = 8000)
13			{
14			$continue = true;
15			do {
16			if ($this->check_port($port)) {
			0 ignored issues – show Bug introduced 2016-03-15 18:59 UTC by Report Bug Copy Issue Report It seems like `check_port()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			$this->output->writeln('<info>Running php artisan serve --port='.$port.'</info>');
			0 ignored issues – show Bug introduced 2016-03-15 18:59 UTC by Report Bug Copy Issue Report The property `output` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18			exec('php artisan serve --port='.$port.' > /dev/null 2>&1 &');
19			sleep(1);
20			if (file_exists('/usr/bin/sensible-browser')) {
21			$this->output->writeln('<info>Opening http://localhost:'.$port.' with default browser</info>');
22			passthru('/usr/bin/sensible-browser http://localhost:'.$port);
23			}
24			$continue = false;
25			}
26			++$port;
27			} while ($continue);
28			}
29			}
30

acacha / llum

Push — master ( b3b6a4...b2f402 )

Serve::serve() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like