Acacha\Llum\Traits\Serve

Complexity

Total Complexity

9

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	serve()	0	18	4
A	check_port()	0	11	2
A	configure()	0	9	1
A	port()	0	4	2

<?php

namespace Acacha\Llum\Traits;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class Serve.
 *
 * @property OutputInterface $output
 */
trait Serve
{
    /**
     * Serve command.
     *
     * @param int $port

There is no parameter named $port. Was it maybe removed?

     */
    protected function serve(InputInterface $input, OutputInterface $output)

The parameter $output is not used and could be removed.

    {
        $port = $this->port($input);
        $continue = true;
        do {
            if ($this->check_port($port)) {
                $this->output->writeln('<info>Running php artisan serve --port='.$port.'</info>');
                exec('php artisan serve --port='.$port.' > /dev/null 2>&1 &');
                sleep(1);
                if (file_exists('/usr/bin/sensible-browser')) {
                    $this->output->writeln('<info>Opening http://localhost:'.$port.' with default browser</info>');
                    passthru('/usr/bin/sensible-browser http://localhost:'.$port);
                }
                $continue = false;
            }
            ++$port;
        } while ($continue);
    }

    /**
     * Check if port is in use.
     *
     * @param int    $port
     * @param string $host
     * @param int    $timeout
     *
     * @return bool
     */
    protected function check_port($port = 8000, $host = '127.0.0.1', $timeout = 3)
    {
        $fp = @fsockopen($host, $port, $errno, $errstr, $timeout);
        if (!$fp) {
            return true;
        } else {
            fclose($fp);

            return false;
        }
    }

    /**
     * Configure command.
     */
    public function configure()
    {
        parent::configure();

        $this

It seems like addArgument() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            // configure an argument
            ->addArgument('port', InputArgument::OPTIONAL, 'Port number')
        ;
    }

    /**
     * Obtain port.
     *
     * @param InputInterface $input
     * @return mixed|string
     */
    protected function port(InputInterface $input) {
        $name = $input->getArgument('port');
        return isset($name) ? $name : 8080;
    }

}