ChecksEnv::checkEnv() - Code Metrics - acacha/forge-publish - Measure and Improve Code Quality continuously with Scrutinizer

ChecksEnv::checkEnv() A
last analyzed 2018-03-14 17:57 UTC

↳ Parent: ChecksEnv

Complexity

Conditions	3
Paths	4

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	4
nop	3
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

namespace Acacha\ForgePublish\Commands\Traits;

/**
 * Trait ChecksEnv.
 *
 * @package Acacha\ForgePublish\Commands\Traits
 */
trait ChecksEnv
{
    /**
     * Check if a argument/option exists or check for his corresponding ENV VALUE.
     *
     * @param $option
     * @param $env_var
     * @param string $type
     * @return mixed
     */
    protected function checkEnv($option, $env_var, $type = 'option')
    {
        $value = $this->$type($option) ? $this->$type($option) : fp_env($env_var);
        if (!$value) {
            $this->error("No env var $env_var found. Please run php artisan publish:init");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            die();

        }
        return $value;
    }
}


1			<?php
2
3			namespace Acacha\ForgePublish\Commands\Traits;
4
5			/**
6			* Trait ChecksEnv.
7			*
8			* @package Acacha\ForgePublish\Commands\Traits
9			*/
10			trait ChecksEnv
11			{
12			/**
13			* Check if a argument/option exists or check for his corresponding ENV VALUE.
14			*
15			* @param $option
16			* @param $env_var
17			* @param string $type
18			* @return mixed
19			*/
20			protected function checkEnv($option, $env_var, $type = 'option')
21			{
22			$value = $this->$type($option) ? $this->$type($option) : fp_env($env_var);
23			if (!$value) {
24			$this->error("No env var $env_var found. Please run php artisan publish:init");
			0 ignored issues – show Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report It seems like `error()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			die();
			0 ignored issues – show Coding Style Compatibility introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report The method `checkEnv()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
26			}
27			return $value;
28			}
29			}
30

acacha / forge-publish

ChecksEnv::checkEnv() A last analyzed 2018-03-14 17:57 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ChecksEnv::checkEnv() A
last analyzed 2018-03-14 17:57 UTC