RunsSSHCommands - Code Metrics - acacha/forge-publish - Measure and Improve Code Quality continuously with Scrutinizer

RunsSSHCommands A
last analyzed 2018-03-14 17:57 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	28.81 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	17
loc	59
rs	10
c	0
b	0
f	0
wmc	8
lcom	1
cbo	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	runScp()	0	15	4
A	runSSH()	8	8	2
A	execSSH()	9	9	2

How to fix Duplicated Code

<?php

namespace Acacha\ForgePublish\Commands\Traits;

/**
 * Trait RunsSSHCommands.
 *
 * @package Acacha\ForgePublish\Commands\Traits
 */
trait RunsSSHCommands
{
    use ChecksSSHConnection;

    /**
     * Runs scp.
     *
     * @param $file
     * @param null $server
     * @param bool $verbose
     */
    protected function runScp($file, $destination_path, $server = null, $verbose = false)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $recursive_option = '';
        if (is_dir($file)) {
            $recursive_option = ' -r';
        }
        $server = $server ? $server : $this->hostNameForConfigFile();
        $ssh_config_file = $_SERVER['HOME'] . '/.ssh/config';
        $full_command = "scp -F ${ssh_config_file}$recursive_option $file $server:$destination_path";

        if ($verbose) {
            $this->info($full_command);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
        passthru($full_command);
    }

    /**
     * Runs ssh command on server.
     *
     * @param $command
     * @param $server
     */
    protected function runSSH($command, $server = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $server = $server ? $server : $this->hostNameForConfigFile();
        $ssh_config_file = $_SERVER['HOME'] . '/.ssh/config';
        $full_command = "ssh -F $ssh_config_file -t $server '$command'";
        $this->info($full_command);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        passthru($full_command);
    }

    /**
     * Exec ssh command on server.
     *
     * @param $command
     * @param $server
     * @return string
     */
    protected function execSSH($command, $server = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $server = $server ? $server : $this->hostNameForConfigFile();

        $ssh_config_file = $_SERVER['HOME'] . '/.ssh/config';
        $full_command = "ssh -F $ssh_config_file -t $server '$command'";
        $this->info($full_command);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        return shell_exec($full_command);
    }
}


1		<?php
2
3		namespace Acacha\ForgePublish\Commands\Traits;
4
5		/**
6		* Trait RunsSSHCommands.
7		*
8		* @package Acacha\ForgePublish\Commands\Traits
9		*/
10		trait RunsSSHCommands
11		{
12		use ChecksSSHConnection;
13
14		/**
15		* Runs scp.
16		*
17		* @param $file
18		* @param null $server
19		* @param bool $verbose
20		*/
21		protected function runScp($file, $destination_path, $server = null, $verbose = false)
		0 ignored issues – show Coding Style introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report `runScp` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
22		{
23		$recursive_option = '';
24		if (is_dir($file)) {
25		$recursive_option = ' -r';
26		}
27		$server = $server ? $server : $this->hostNameForConfigFile();
28		$ssh_config_file = $_SERVER['HOME'] . '/.ssh/config';
29		$full_command = "scp -F ${ssh_config_file}$recursive_option $file $server:$destination_path";
30
31		if ($verbose) {
32		$this->info($full_command);
		0 ignored issues – show Bug introduced 2017-11-29 08:00 UTC by Report Bug Copy Issue Report It seems like `info()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
33		}
34		passthru($full_command);
35		}
36
37		/**
38		* Runs ssh command on server.
39		*
40		* @param $command
41		* @param $server
42		*/
43	View Code Duplication	protected function runSSH($command, $server = null)
		0 ignored issues – show Duplication introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report `runSSH` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
44		{
45		$server = $server ? $server : $this->hostNameForConfigFile();
46		$ssh_config_file = $_SERVER['HOME'] . '/.ssh/config';
47		$full_command = "ssh -F $ssh_config_file -t $server '$command'";
48		$this->info($full_command);
		0 ignored issues – show Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report It seems like `info()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
49		passthru($full_command);
50		}
51
52		/**
53		* Exec ssh command on server.
54		*
55		* @param $command
56		* @param $server
57		* @return string
58		*/
59	View Code Duplication	protected function execSSH($command, $server = null)
		0 ignored issues – show Duplication introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report `execSSH` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
60		{
61		$server = $server ? $server : $this->hostNameForConfigFile();
62
63		$ssh_config_file = $_SERVER['HOME'] . '/.ssh/config';
64		$full_command = "ssh -F $ssh_config_file -t $server '$command'";
65		$this->info($full_command);
		0 ignored issues – show Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report It seems like `info()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
66		return shell_exec($full_command);
67		}
68		}
69

acacha / forge-publish

RunsSSHCommands A last analyzed 2018-03-14 17:57 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

RunsSSHCommands A
last analyzed 2018-03-14 17:57 UTC