Acacha\ForgePublish\Commands\Traits\ItFetchesSites

Complexity

Total Complexity

10

Size/Duplication

Total Lines	91
Duplicated Lines	19.78 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getSiteByName()	9	11	2
A	getSite()	9	11	2
A	getSiteName()	0	7	2
A	getSiteId()	0	7	2
A	fetchSites()	0	17	2

<?php

namespace Acacha\ForgePublish\Commands\Traits;

/**
 * Trait ItFetchesSites
 *
 * @package Acacha\ForgePublish\Commands
 */
trait ItFetchesSites
{
    /**
     * Fetch sites
     */
    protected function fetchSites($server_id)
    {
        $url = config('forge-publish.url') . config('forge-publish.user_sites_uri') . '/' . $server_id;
        try {
            $response = $this->http->get($url, [

The property http does not exist. Did you maybe forget to declare it?

                'headers' => [
                    'X-Requested-With' => 'XMLHttpRequest',
                    'Authorization' => 'Bearer ' . fp_env('ACACHA_FORGE_ACCESS_TOKEN')
                ]
            ]);
        } catch (\Exception $e) {
            $this->error('And error occurs connecting to the api url: ' . $url);

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->error('Status code: ' . $e->getResponse()->getStatusCode() . ' | Reason : ' . $e->getResponse()->getReasonPhrase());

It seems like you code against a specific sub-type and not the parent class Exception as the method getResponse() does only exist in the following sub-classes of Exception: GuzzleHttp\Exception\BadResponseException, GuzzleHttp\Exception\ClientException, GuzzleHttp\Exception\ConnectException, GuzzleHttp\Exception\RequestException, GuzzleHttp\Exception\ServerException, GuzzleHttp\Exception\TooManyRedirectsException. Maybe you want to instanceof check for one of these explicitly?

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return [];
        }
        return json_decode((string) $response->getBody());
    }

    /**
     * Get forge site from sites by name.
     *
     * @param $sites
     * @param $site_id
     * @return mixed
     */
    protected function getSiteByName($sites, $site_name)

This method seems to be duplicated in your project.

    {
        $site_found = collect($sites)->filter(function ($site) use ($site_name) {
            return $site->name === $site_name;
        })->first();

        if ($site_found) {
            return $site_found;
        }
        return null;
    }

    /**
     * Get forge site from sites.
     *
     * @param $sites
     * @param $site_id
     * @return mixed
     */
    protected function getSite($sites, $site_id)

This method seems to be duplicated in your project.

    {
        $site_found = collect($sites)->filter(function ($site) use ($site_id) {
            return $site->id === $site_id;
        })->first();

        if ($site_found) {
            return $site_found;
        }
        return null;
    }

    /**
     * Get forge site name from site id.
     *
     * @param $sites
     * @param $site_id
     * @return mixed
     */
    protected function getSiteName($sites, $site_id)
    {
        if ($site = $this->getSite($sites, $site_id)) {
            return $site->name;
        }
        return null;
    }

    /**
     * Get forge site id from site name.
     *
     * @param $sites
     * @param $site_name
     * @return mixed
     */
    protected function getSiteId($sites, $site_name)
    {
        if ($site = $this->getSiteByName($sites, $site_name)) {
            return $site->id;
        }
        return null;
    }
}