ItFetchesServers - Code Metrics - acacha/forge-publish - Measure and Improve Code Quality continuously with Scrutinizer

ItFetchesServers A
last analyzed 2018-03-14 17:57 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	23.08 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

Metric	Value
dl	18
loc	78
rs	10
c	0
b	0
f	0
wmc	9
lcom	2
cbo	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	fetchServers()	18	18	2
A	getForgeIdServer()	0	5	2
A	getForgeName()	0	5	2
A	serverIpAddress()	0	5	2
A	searchServer()	0	6	1

How to fix Duplicated Code

<?php

namespace Acacha\ForgePublish\Commands\Traits;

/**
 * Trait ItFetchesServers
 *
 * @package Acacha\ForgePublish\Commands
 */
trait ItFetchesServers
{
    /**
     * Fetch servers
     */
    protected function fetchServers()

    {
        $url = config('forge-publish.url') . config('forge-publish.user_servers_uri');
        try {
            $response = $this->http->get($url, [
class MyClass { }

$x = new MyClass();
$x->foo = true;
                'headers' => [
                    'X-Requested-With' => 'XMLHttpRequest',
                    'Authorization' => 'Bearer ' . fp_env('ACACHA_FORGE_ACCESS_TOKEN')
                ]
            ]);
        } catch (\Exception $e) {
            $this->error('And error occurs connecting to the api url: ' . $url);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            dd($e);
            $this->error('Status code: ' . $e->getResponse()->getStatusCode() . ' | Reason : ' . $e->getResponse()->getReasonPhrase());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return [];
        }
        return json_decode((string) $response->getBody());
    }

    /**
     * Get forge id server from server name.
     *
     * @param $servers
     * @param $server_name
     * @return mixed
     */
    protected function getForgeIdServer($servers, $server_name)
    {
        $found_server = $this->searchServer($servers, 'name', $server_name);
        return $found_server->first() ? $found_server->first()->forge_id : null;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get forge name from forge id.
     *
     * @param $servers
     * @param $server_id
     * @return mixed
     */
    protected function getForgeName($servers, $server_id)
    {
        $found_server = $this->searchServer($servers, 'forge_id', $server_id);
        return $found_server->first() ? $found_server->first()->name : null;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get server ip addres by forge server id.
     *
     * @param $servers
     * @param $server_id
     * @return mixed
     */
    protected function serverIpAddress($servers, $server_id)
    {
        $found_server = $this->searchServer($servers, 'forge_id', $server_id);
        return $found_server->first() ? $found_server->first()->ipAddress : null;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Search server by property with a specific value.
     *
     * @param $servers
     * @param $property
     * @param $value
     * @return static
     */
    protected function searchServer($servers, $property, $value)
    {
        return collect($servers)->filter(function ($server) use ($property, $value) {
            return $server->$property == $value;
        });
    }
}


1		<?php
2
3		namespace Acacha\ForgePublish\Commands\Traits;
4
5		/**
6		* Trait ItFetchesServers
7		*
8		* @package Acacha\ForgePublish\Commands
9		*/
10		trait ItFetchesServers
11		{
12		/**
13		* Fetch servers
14		*/
15	View Code Duplication	protected function fetchServers()
		0 ignored issues – show Duplication introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		$url = config('forge-publish.url') . config('forge-publish.user_servers_uri');
18		try {
19		$response = $this->http->get($url, [
		0 ignored issues – show Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report The property `http` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20		'headers' => [
21		'X-Requested-With' => 'XMLHttpRequest',
22		'Authorization' => 'Bearer ' . fp_env('ACACHA_FORGE_ACCESS_TOKEN')
23		]
24		]);
25		} catch (\Exception $e) {
26		$this->error('And error occurs connecting to the api url: ' . $url);
		0 ignored issues – show Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report It seems like `error()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27		dd($e);
28		$this->error('Status code: ' . $e->getResponse()->getStatusCode() . ' \| Reason : ' . $e->getResponse()->getReasonPhrase());
		0 ignored issues – show Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Exception` as the method `getResponse()` does only exist in the following sub-classes of `Exception`: `GuzzleHttp\Exception\BadResponseException`, `GuzzleHttp\Exception\ClientException`, `GuzzleHttp\Exception\ConnectException`, `GuzzleHttp\Exception\RequestException`, `GuzzleHttp\Exception\ServerException`, `GuzzleHttp\Exception\TooManyRedirectsException`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history... Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report It seems like `error()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29		return [];
30		}
31		return json_decode((string) $response->getBody());
32		}
33
34		/**
35		* Get forge id server from server name.
36		*
37		* @param $servers
38		* @param $server_name
39		* @return mixed
40		*/
41		protected function getForgeIdServer($servers, $server_name)
42		{
43		$found_server = $this->searchServer($servers, 'name', $server_name);
44		return $found_server->first() ? $found_server->first()->forge_id : null;
		0 ignored issues – show Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report It seems like `first()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45		}
46
47		/**
48		* Get forge name from forge id.
49		*
50		* @param $servers
51		* @param $server_id
52		* @return mixed
53		*/
54		protected function getForgeName($servers, $server_id)
55		{
56		$found_server = $this->searchServer($servers, 'forge_id', $server_id);
57		return $found_server->first() ? $found_server->first()->name : null;
		0 ignored issues – show Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report It seems like `first()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
58		}
59
60		/**
61		* Get server ip addres by forge server id.
62		*
63		* @param $servers
64		* @param $server_id
65		* @return mixed
66		*/
67		protected function serverIpAddress($servers, $server_id)
68		{
69		$found_server = $this->searchServer($servers, 'forge_id', $server_id);
70		return $found_server->first() ? $found_server->first()->ipAddress : null;
		0 ignored issues – show Bug introduced 2017-11-29 07:30 UTC by Report Bug Copy Issue Report It seems like `first()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
71		}
72
73		/**
74		* Search server by property with a specific value.
75		*
76		* @param $servers
77		* @param $property
78		* @param $value
79		* @return static
80		*/
81		protected function searchServer($servers, $property, $value)
82		{
83		return collect($servers)->filter(function ($server) use ($property, $value) {
84		return $server->$property == $value;
85		});
86		}
87		}
88

acacha / forge-publish

ItFetchesServers A last analyzed 2018-03-14 17:57 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like

ItFetchesServers A
last analyzed 2018-03-14 17:57 UTC