Acacha\ForgePublish\Commands\PublishSite

Complexity

Total Complexity

11

Size/Duplication

Total Lines	145
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	envVar()	0	4	1
A	argKey()	0	4	1
A	questionText()	0	4	1
A	before()	0	6	1
A	default()	0	11	3
A	value()	0	22	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 13 and the first side effect is on line 157.

namespace Acacha\ForgePublish\Commands;

use Acacha\ForgePublish\Commands\Traits\ItFetchesSites;
use GuzzleHttp\Client;

/**
 * Class PublishSite.
 *
 * @package Acacha\ForgePublish\Commands
 */
class PublishSite extends SaveEnvVariable
{
    use ItFetchesSites;

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'publish:site {site?}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Save AcachaForge site';

    /**
     * Sites.
     *
     * @var string
     */
    protected $sites;

    /**
     * Default value.
     *
     * @var string
     */
    protected $default;

    /**
     * Site names.
     *
     * @var array
     */
    protected $site_names;

    /**
     * Site already exists?.
     *
     * @var boolean
     */
    protected $site_already_exists = false;

    /**
     * Server names.
     *
     * @var Client
     */
    protected $http;

    /**
     * SaveEnvVariable constructor.
     *
     */
    public function __construct(Client $http)
    {
        parent::__construct();
        $this->http = $http;
    }

    /**
     * Env var to set.
     *
     * @return mixed
     */
    protected function envVar()
    {
        return 'ACACHA_FORGE_SITE';
    }

    /**
     * Argument key.
     *
     * @return mixed
     */
    protected function argKey()
    {
        return 'site';
    }

    /**
     * Question text.
     *
     * @return mixed
     */
    protected function questionText()
    {
        return 'Acacha forge site id?';
    }

    /**
     * Before hook.
     */
    protected function before()
    {
        $this->sites = $this->fetchSites(fp_env('ACACHA_FORGE_SERVER'));
        $this->site_names = collect($this->sites)->pluck('name')->toArray();
        $this->default = $this->default();
    }

    /**
     * Default proposed value when asking.
     *
     */
    protected function default()

Possible parse error: non-abstract method defined as abstract

    {
        $current_value = fp_env('ACACHA_FORGE_SITE');

The visibility should be declared for property $current_value.

        if ($current_value) {

It is generally advisable to only define one property per statement.

The visibility should be declared for property $current_value.

            $site_name = $this->getSiteName($this->sites, $current_value);
            if ($site_name) {

It is generally advisable to only define one property per statement.

The visibility should be declared for property $site_name.

                return $site_name;
            }
        }
        return fp_env('ACACHA_FORGE_DOMAIN');
    }

    /**
     * Value.
     */
    protected function value()
    {
        $default=null;

$default is not used, you could remove the assignment.

        $choices = $this->site_names ;
        if ($result = array_search($this->default, $this->site_names)) {
            $default = $result;
        } else {
            $newChoice = 'Create new Site using domain name: ' . fp_env('ACACHA_FORGE_DOMAIN');
            $choices = array_merge([$newChoice], $this->site_names);
            $default = array_search($newChoice, $this->site_names);
        }

        $site_name = $this->choice($this->questionText(), $choices, $default);
        $site_id = $this->getSiteId($this->sites, $site_name);
        if (! $site_id) {
            $this->call('publish:create_site');
            return fp_env('ACACHA_FORGE_SITE');
        } else {
            $this->info("Site ($site_name) already exists on Laravel Forge with site_id: $site_id");
            return $site_id;
        }
    }
}