Inspection of "Updated public folder" - acacha/adminlte-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fa9c16...d9a835 )

by Sergi Tur

created 2017-04-06 12:45 UTC

Status

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -27,22 +27,22 @@
 block discarded – undo
 
 if (!empty($_POST))
 {
-	foreach ( $_POST as $key => $value )
-	{
-		if ( ( !is_string($value) && !is_numeric($value) ) || !is_string($key) )
-			continue;
+    foreach ( $_POST as $key => $value )
+    {
+        if ( ( !is_string($value) && !is_numeric($value) ) || !is_string($key) )
+            continue;
 
-		if ( get_magic_quotes_gpc() )
-			$value = htmlspecialchars( stripslashes((string)$value) );
-		else
-			$value = htmlspecialchars( (string)$value );
+        if ( get_magic_quotes_gpc() )
+            $value = htmlspecialchars( stripslashes((string)$value) );
+        else
+            $value = htmlspecialchars( (string)$value );
 ?>
 		<tr>
 			<th style="vertical-align: top"><?php echo htmlspecialchars( (string)$key ); ?></th>
 			<td><pre class="samples"><?php echo $value; ?></pre></td>
 		</tr>
 	<?php
-	}
+    }
 }
 ?>
 	</table>

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -27,18 +27,18 @@
 block discarded – undo
 
 if (!empty($_POST))
 {
-	foreach ( $_POST as $key => $value )
+	foreach ($_POST as $key => $value)
 	{
-		if ( ( !is_string($value) && !is_numeric($value) ) || !is_string($key) )
+		if ((!is_string($value) && !is_numeric($value)) || !is_string($key))
 			continue;
 
-		if ( get_magic_quotes_gpc() )
-			$value = htmlspecialchars( stripslashes((string)$value) );
+		if (get_magic_quotes_gpc())
+			$value = htmlspecialchars(stripslashes((string) $value));
 		else
-			$value = htmlspecialchars( (string)$value );
+			$value = htmlspecialchars((string) $value);
 ?>
 		<tr>
-			<th style="vertical-align: top"><?php echo htmlspecialchars( (string)$key ); ?></th>
+			<th style="vertical-align: top"><?php echo htmlspecialchars((string) $key); ?></th>
 			<td><pre class="samples"><?php echo $value; ?></pre></td>
 		</tr>
 	<?php

Please login to merge, or discard this patch.

Braces +9 added lines, -7 removed lines patch added patch discarded remove patch

@@ -29,14 +29,16 @@
 block discarded – undo
 {
 	foreach ( $_POST as $key => $value )
 	{
-		if ( ( !is_string($value) && !is_numeric($value) ) || !is_string($key) )
-			continue;
+		if ( ( !is_string($value) && !is_numeric($value) ) || !is_string($key) ) {
+					continue;
+		}
 
-		if ( get_magic_quotes_gpc() )
-			$value = htmlspecialchars( stripslashes((string)$value) );
-		else
-			$value = htmlspecialchars( (string)$value );
-?>
+		if ( get_magic_quotes_gpc() ) {
+					$value = htmlspecialchars( stripslashes((string)$value) );
+		} else {
+					$value = htmlspecialchars( (string)$value );
+		}
+		?>
 		<tr>
 			<th style="vertical-align: top"><?php echo htmlspecialchars( (string)$key ); ?></th>
 			<td><pre class="samples"><?php echo $value; ?></pre></td>

Please login to merge, or discard this patch.

migrations/username_login/2014_10_12_200000_add_username_to_users_table.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
      */
     public function up()
     {
-        Schema::table('users', function (Blueprint $table) {
+        Schema::table('users', function(Blueprint $table) {
             $table->string('username')->unique()->nullable();
         });
     }
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
      */
     public function down()
     {
-        Schema::table('users', function (Blueprint $table) {
+        Schema::table('users', function(Blueprint $table) {
             $table->dropColumn('username');
         });
     }

Please login to merge, or discard this patch.

src/Providers/AdminLTETemplateServiceProvider.php 1 patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -26,25 +26,25 @@  discard block
 block discarded – undo
         }
 
         if ($this->app->runningInConsole()) {
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTE::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTEAlt::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTESidebar::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTESidebarAlt::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeAdminUserSeeder::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\AdminLTEAdmin::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\AdminLTEAdminAlt::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeView::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\AdminLTEMenu::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\AdminLTEMenuAlt::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeRoute::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeMenu::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeV::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeVC::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeMVC::class]);
-            $this->commands([\Acacha\AdminLTETemplateLaravel\Console\Username::class]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTE::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTEAlt::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTESidebar::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTESidebarAlt::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeAdminUserSeeder::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\AdminLTEAdmin::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\AdminLTEAdminAlt::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeView::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\AdminLTEMenu::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\AdminLTEMenuAlt::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeRoute::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeMenu::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeV::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeVC::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeMVC::class ]);
+            $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\Username::class ]);
         }
 
-        $this->app->bind('AdminLTE', function () {
+        $this->app->bind('AdminLTE', function() {
             return new \Acacha\AdminLTETemplateLaravel\AdminLTE();
         });
 
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
             $this->registerGuestUserProvider();
         }
         if (config('auth.providers.users.field', 'email') === 'username') {
-            $this->loadMigrationsFrom(ADMINLTETEMPLATE_PATH .'/database/migrations/username_login');
+            $this->loadMigrationsFrom(ADMINLTETEMPLATE_PATH.'/database/migrations/username_login');
         }
     }
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
         if (!$this->app->routesAreCached()) {
             $router = app('router');
 
-            $router->group(['namespace' => $this->getAppNamespace().'Http\Controllers'], function () {
+            $router->group([ 'namespace' => $this->getAppNamespace().'Http\Controllers' ], function() {
                 require __DIR__.'/../Http/routes.php';
             });
         }

Please login to merge, or discard this patch.

config/menu.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -10,23 +10,23 @@
 block discarded – undo
 //        ->url('http://www.google.com', 'Google');
 //});
 
-Menu::macro('adminlteSubmenu', function ($submenuName) {
-    return Menu::new()->prepend('<a href="#"><span> ' . $submenuName . '</span> <i class="fa fa-angle-left pull-right"></i></a>')
+Menu::macro('adminlteSubmenu', function($submenuName) {
+    return Menu::new()->prepend('<a href="#"><span> '.$submenuName.'</span> <i class="fa fa-angle-left pull-right"></i></a>')
         ->addParentClass('treeview')->addClass('treeview-menu');
 });
-Menu::macro('adminlteMenu', function () {
+Menu::macro('adminlteMenu', function() {
     return Menu::new()
         ->addClass('sidebar-menu');
 });
-Menu::macro('adminlteSeparator', function ($title) {
+Menu::macro('adminlteSeparator', function($title) {
     return Html::raw($title)->addParentClass('header');
 });
 
-Menu::macro('adminlteDefaultMenu', function ($content) {
-    return Html::raw('<i class="fa fa-link"></i><span>' . $content . '</span>')->html();
+Menu::macro('adminlteDefaultMenu', function($content) {
+    return Html::raw('<i class="fa fa-link"></i><span>'.$content.'</span>')->html();
 });
 
-Menu::macro('sidebar', function () {
+Menu::macro('sidebar', function() {
     return Menu::adminlteMenu()
         ->add(Html::raw('HEADER')->addParentClass('header'))
         ->action('HomeController@index', '<i class="fa fa-home"></i><span>Home</span>')

Please login to merge, or discard this patch.

		@@ -27,18 +27,18 @@
		block discarded – undo
27	27
28	28	if (!empty($_POST))
29	29	{
30		- foreach ( $_POST as $key => $value )
	30	+ foreach ($_POST as $key => $value)
31	31	{
32		- if ( ( !is_string($value) && !is_numeric($value) ) \|\| !is_string($key) )
	32	+ if ((!is_string($value) && !is_numeric($value)) \|\| !is_string($key))
33	33	continue;
34	34
35		- if ( get_magic_quotes_gpc() )
36		- $value = htmlspecialchars( stripslashes((string)$value) );
	35	+ if (get_magic_quotes_gpc())
	36	+ $value = htmlspecialchars(stripslashes((string) $value));
37	37	else
38		- $value = htmlspecialchars( (string)$value );
	38	+ $value = htmlspecialchars((string) $value);
39	39	?>
40	40	<tr>
41		- <th style="vertical-align: top"><?php echo htmlspecialchars( (string)$key ); ?></th>
	41	+ <th style="vertical-align: top"><?php echo htmlspecialchars((string) $key); ?></th>
42	42	<td><pre class="samples"><?php echo $value; ?></pre></td>
43	43	</tr>
44	44	<?php

		@@ -27,22 +27,22 @@
		block discarded – undo
27	27
28	28	if (!empty($_POST))
29	29	{
30		- foreach ( $_POST as $key => $value )
31		- {
32		- if ( ( !is_string($value) && !is_numeric($value) ) \|\| !is_string($key) )
33		- continue;
	30	+ foreach ( $_POST as $key => $value )
	31	+ {
	32	+ if ( ( !is_string($value) && !is_numeric($value) ) \|\| !is_string($key) )
	33	+ continue;
34	34
35		- if ( get_magic_quotes_gpc() )
36		- $value = htmlspecialchars( stripslashes((string)$value) );
37		- else
38		- $value = htmlspecialchars( (string)$value );
	35	+ if ( get_magic_quotes_gpc() )
	36	+ $value = htmlspecialchars( stripslashes((string)$value) );
	37	+ else
	38	+ $value = htmlspecialchars( (string)$value );
39	39	?>
40	40	<tr>
41	41	<th style="vertical-align: top"><?php echo htmlspecialchars( (string)$key ); ?></th>
42	42	<td><pre class="samples"><?php echo $value; ?></pre></td>
43	43	</tr>
44	44	<?php
45		- }
	45	+ }
46	46	}
47	47	?>
48	48	</table>

		@@ -29,14 +29,16 @@
		block discarded – undo
29	29	{
30	30	foreach ( $_POST as $key => $value )
31	31	{
32		- if ( ( !is_string($value) && !is_numeric($value) ) \|\| !is_string($key) )
33		- continue;
	32	+ if ( ( !is_string($value) && !is_numeric($value) ) \|\| !is_string($key) ) {
	33	+ continue;
	34	+ }
34	35
35		- if ( get_magic_quotes_gpc() )
36		- $value = htmlspecialchars( stripslashes((string)$value) );
37		- else
38		- $value = htmlspecialchars( (string)$value );
39		-?>
	36	+ if ( get_magic_quotes_gpc() ) {
	37	+ $value = htmlspecialchars( stripslashes((string)$value) );
	38	+ } else {
	39	+ $value = htmlspecialchars( (string)$value );
	40	+ }
	41	+ ?>
40	42	<tr>
41	43	<th style="vertical-align: top"><?php echo htmlspecialchars( (string)$key ); ?></th>
42	44	<td><pre class="samples"><?php echo $value; ?></pre></td>

		@@ -13,7 +13,7 @@ discard block
		block discarded – undo
13	13	*/
14	14	public function up()
15	15	{
16		- Schema::table('users', function (Blueprint $table) {
	16	+ Schema::table('users', function(Blueprint $table) {
17	17	$table->string('username')->unique()->nullable();
18	18	});
19	19	}
		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	*/
26	26	public function down()
27	27	{
28		- Schema::table('users', function (Blueprint $table) {
	28	+ Schema::table('users', function(Blueprint $table) {
29	29	$table->dropColumn('username');
30	30	});
31	31	}

		@@ -26,25 +26,25 @@ discard block
		block discarded – undo
26	26	}
27	27
28	28	if ($this->app->runningInConsole()) {
29		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTE::class]);
30		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTEAlt::class]);
31		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTESidebar::class]);
32		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTESidebarAlt::class]);
33		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeAdminUserSeeder::class]);
34		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\AdminLTEAdmin::class]);
35		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\AdminLTEAdminAlt::class]);
36		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeView::class]);
37		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\AdminLTEMenu::class]);
38		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\AdminLTEMenuAlt::class]);
39		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeRoute::class]);
40		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeMenu::class]);
41		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeV::class]);
42		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeVC::class]);
43		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\MakeMVC::class]);
44		- $this->commands([\Acacha\AdminLTETemplateLaravel\Console\Username::class]);
	29	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTE::class ]);
	30	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTEAlt::class ]);
	31	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTESidebar::class ]);
	32	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\PublishAdminLTESidebarAlt::class ]);
	33	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeAdminUserSeeder::class ]);
	34	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\AdminLTEAdmin::class ]);
	35	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\AdminLTEAdminAlt::class ]);
	36	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeView::class ]);
	37	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\AdminLTEMenu::class ]);
	38	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\AdminLTEMenuAlt::class ]);
	39	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeRoute::class ]);
	40	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeMenu::class ]);
	41	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeV::class ]);
	42	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeVC::class ]);
	43	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\MakeMVC::class ]);
	44	+ $this->commands([ \Acacha\AdminLTETemplateLaravel\Console\Username::class ]);
45	45	}
46	46
47		- $this->app->bind('AdminLTE', function () {
	47	+ $this->app->bind('AdminLTE', function() {
48	48	return new \Acacha\AdminLTETemplateLaravel\AdminLTE();
49	49	});
50	50
		@@ -56,7 +56,7 @@ discard block
		block discarded – undo
56	56	$this->registerGuestUserProvider();
57	57	}
58	58	if (config('auth.providers.users.field', 'email') === 'username') {
59		- $this->loadMigrationsFrom(ADMINLTETEMPLATE_PATH .'/database/migrations/username_login');
	59	+ $this->loadMigrationsFrom(ADMINLTETEMPLATE_PATH.'/database/migrations/username_login');
60	60	}
61	61	}
62	62
		@@ -110,7 +110,7 @@ discard block
		block discarded – undo
110	110	if (!$this->app->routesAreCached()) {
111	111	$router = app('router');
112	112
113		- $router->group(['namespace' => $this->getAppNamespace().'Http\Controllers'], function () {
	113	+ $router->group([ 'namespace' => $this->getAppNamespace().'Http\Controllers' ], function() {
114	114	require __DIR__.'/../Http/routes.php';
115	115	});
116	116	}

		@@ -10,23 +10,23 @@
		block discarded – undo
10	10	// ->url('http://www.google.com', 'Google');
11	11	//});
12	12
13		-Menu::macro('adminlteSubmenu', function ($submenuName) {
14		- return Menu::new()->prepend('<a href="#"><span> ' . $submenuName . '</span> <i class="fa fa-angle-left pull-right"></i></a>')
	13	+Menu::macro('adminlteSubmenu', function($submenuName) {
	14	+ return Menu::new()->prepend('<a href="#"><span> '.$submenuName.'</span> <i class="fa fa-angle-left pull-right"></i></a>')
15	15	->addParentClass('treeview')->addClass('treeview-menu');
16	16	});
17		-Menu::macro('adminlteMenu', function () {
	17	+Menu::macro('adminlteMenu', function() {
18	18	return Menu::new()
19	19	->addClass('sidebar-menu');
20	20	});
21		-Menu::macro('adminlteSeparator', function ($title) {
	21	+Menu::macro('adminlteSeparator', function($title) {
22	22	return Html::raw($title)->addParentClass('header');
23	23	});
24	24
25		-Menu::macro('adminlteDefaultMenu', function ($content) {
26		- return Html::raw('<i class="fa fa-link"></i><span>' . $content . '</span>')->html();
	25	+Menu::macro('adminlteDefaultMenu', function($content) {
	26	+ return Html::raw('<i class="fa fa-link"></i><span>'.$content.'</span>')->html();
27	27	});
28	28
29		-Menu::macro('sidebar', function () {
	29	+Menu::macro('sidebar', function() {
30	30	return Menu::adminlteMenu()
31	31	->add(Html::raw('HEADER')->addParentClass('header'))
32	32	->action('HomeController@index', '<i class="fa fa-home"></i><span>Home</span>')

acacha / adminlte-laravel

Push — master ( fa9c16...d9a835 )

Status

Category

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Braces +9 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch