Issues in Username.php - New Issues - Inspection of "Laravel7 (#431)" - acacha/adminlte-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a64245...e0b49d )

by Manel

created 2020-07-20 10:45 UTC

src/Console/Username.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Acacha\AdminLTETemplateLaravel\Console;

use Illuminate\Console\Command;
use Illuminate\Filesystem\Filesystem;

/**
 * Class Username.
 */
class Username extends Command
{
    use Installable;

    /**
     * The filesystem instance.
     *
     * @var \Illuminate\Filesystem\Filesystem
     */
    protected $files;

    /**
     * The name and signature of the console command.
     */
    protected $signature = 'adminlte:username {--f|force : Force overwrite of files}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Changes to login and register with username';

    /**
     * Force overwrite of files.
     *
     * @var bool
     */
    protected $force = false;

    /**
     * Create a new command instance.
     *
     * @param \Illuminate\Filesystem\Filesystem $files
     *
     */
    public function __construct(Filesystem $files)
    {
        parent::__construct();
        $this->files = $files;
    }

    /**
     * Execute the console command.
     */
    public function handle()
    {
        $this->processOptions();
        $this->publishAuthConfigFile();
        $this->publishUserClass();
        $this->runMigration();
    }

    /**
     * Install auth config file.
     */
    private function publishAuthConfigFile()
    {
        $this->install(\Acacha\AdminLTETemplateLaravel\Facades\AdminLTE::authConfig());
    }

    /**
     * Publish User class.
     */
    private function publishUserClass()
    {
        $this->install(\Acacha\AdminLTETemplateLaravel\Facades\AdminLTE::userClass());
    }

    /**
     * Run migration.
     */
    private function runMigration()
    {
        $this->info('Installing doctrine/dbal');
        passthru('composer require doctrine/dbal');
        $this->info('Running php artisan migrate');
        passthru('php artisan migrate');
    }

    /**
     * Process options before running command.
     */
    private function processOptions()
    {
        $this->force = $this->option('force');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }
}


1			<?php
2
3			namespace Acacha\AdminLTETemplateLaravel\Console;
4
5			use Illuminate\Console\Command;
6			use Illuminate\Filesystem\Filesystem;
7
8			/**
9			* Class Username.
10			*/
11			class Username extends Command
12			{
13			use Installable;
14
15			/**
16			* The filesystem instance.
17			*
18			* @var \Illuminate\Filesystem\Filesystem
19			*/
20			protected $files;
21
22			/**
23			* The name and signature of the console command.
24			*/
25			protected $signature = 'adminlte:username {--f\|force : Force overwrite of files}';
26
27			/**
28			* The console command description.
29			*
30			* @var string
31			*/
32			protected $description = 'Changes to login and register with username';
33
34			/**
35			* Force overwrite of files.
36			*
37			* @var bool
38			*/
39			protected $force = false;
40
41			/**
42			* Create a new command instance.
43			*
44			* @param \Illuminate\Filesystem\Filesystem $files
45			*
46			*/
47			public function __construct(Filesystem $files)
48			{
49			parent::__construct();
50			$this->files = $files;
51			}
52
53			/**
54			* Execute the console command.
55			*/
56			public function handle()
57			{
58			$this->processOptions();
59			$this->publishAuthConfigFile();
60			$this->publishUserClass();
61			$this->runMigration();
62			}
63
64			/**
65			* Install auth config file.
66			*/
67			private function publishAuthConfigFile()
68			{
69			$this->install(\Acacha\AdminLTETemplateLaravel\Facades\AdminLTE::authConfig());
70			}
71
72			/**
73			* Publish User class.
74			*/
75			private function publishUserClass()
76			{
77			$this->install(\Acacha\AdminLTETemplateLaravel\Facades\AdminLTE::userClass());
78			}
79
80			/**
81			* Run migration.
82			*/
83			private function runMigration()
84			{
85			$this->info('Installing doctrine/dbal');
86			passthru('composer require doctrine/dbal');
87			$this->info('Running php artisan migrate');
88			passthru('php artisan migrate');
89			}
90
91			/**
92			* Process options before running command.
93			*/
94			private function processOptions()
95			{
96			$this->force = $this->option('force');
			0 ignored issues – show Documentation Bug introduced 2018-09-04 10:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->option('force')` can also be of type `string` or `array`. However, the property `$force` is declared as type `boolean`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
97			}
98			}
99

acacha / adminlte-laravel

Push — master ( a64245...e0b49d )

src/Console/Username.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like