Issues in AdminLTEMenu.php - New Issues - Inspection of "Laravel7 (#431)" - acacha/adminlte-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a64245...e0b49d )

by Manel

created 2020-07-20 10:45 UTC

src/Console/AdminLTEMenu.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Acacha\AdminLTETemplateLaravel\Console;

use Acacha\AdminLTETemplateLaravel\Exceptions\SpatieMenuAlreadyExists;
use Acacha\AdminLTETemplateLaravel\Facades\AdminLTE;
use Illuminate\Console\Command;
use Illuminate\Filesystem\Filesystem;

/**
 * Class AdminLTEMenu.
 */
class AdminLTEMenu extends Command
{
    use Installable;

    /**
     * The filesystem instance.
     *
     * @var \Illuminate\Filesystem\Filesystem
     */
    protected $files;

    /**
     * The name and signature of the console command.
     */
    protected $signature = 'adminlte-laravel:menu {--f|force : Force overwrite of files}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Replaces sidebar view with a sidebar using spatie/laravel-menu menu';

    /**
     * Force overwrite of files.
     *
     * @var bool
     */
    protected $force = false;

    /**
     * Create a new command instance.
     *
     * @param \Illuminate\Filesystem\Filesystem $files
     *
     */
    public function __construct(Filesystem $files)
    {
        parent::__construct();
        $this->files = $files;
    }

    /**
     * Execute the console command.
     */
    public function handle()
    {
        $this->processOptions();
        $this->checkIfSpatieMenuAlreadyInstalled();
        $this->installSpatieMenu();
        $this->publishSpatieMenu();
        $this->publishSpatieMenuConfig();
    }

    /**
     * Check if spatie menu is already installed.
     *
     * @throws SpatieMenuAlreadyExists
     */
    protected function checkIfSpatieMenuAlreadyInstalled()
    {
        if ((app()->getProvider('Spatie\Menu\Laravel\MenuServiceProvider')) && ! $this->force) {
            throw new SpatieMenuAlreadyExists();
        }
        return;
    }

    /**
     * Install spatie/laravel-menu.
     */
    protected function installSpatieMenu()
    {
        passthru('composer require spatie/laravel-menu');
    }

    /**
     * Process options before running command.
     */
    protected function processOptions()
    {
        $this->force = $this->option('force');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Publish sidebar with spatie menu
     */
    protected function publishSpatieMenu()
    {
        $this->install(AdminLTE::spatieMenu());
    }

    /**
     * Publish spatie menu config
     */
    protected function publishSpatieMenuConfig()
    {
        $this->install(AdminLTE::menu());
    }
}


1			<?php
2
3			namespace Acacha\AdminLTETemplateLaravel\Console;
4
5			use Acacha\AdminLTETemplateLaravel\Exceptions\SpatieMenuAlreadyExists;
6			use Acacha\AdminLTETemplateLaravel\Facades\AdminLTE;
7			use Illuminate\Console\Command;
8			use Illuminate\Filesystem\Filesystem;
9
10			/**
11			* Class AdminLTEMenu.
12			*/
13			class AdminLTEMenu extends Command
14			{
15			use Installable;
16
17			/**
18			* The filesystem instance.
19			*
20			* @var \Illuminate\Filesystem\Filesystem
21			*/
22			protected $files;
23
24			/**
25			* The name and signature of the console command.
26			*/
27			protected $signature = 'adminlte-laravel:menu {--f\|force : Force overwrite of files}';
28
29			/**
30			* The console command description.
31			*
32			* @var string
33			*/
34			protected $description = 'Replaces sidebar view with a sidebar using spatie/laravel-menu menu';
35
36			/**
37			* Force overwrite of files.
38			*
39			* @var bool
40			*/
41			protected $force = false;
42
43			/**
44			* Create a new command instance.
45			*
46			* @param \Illuminate\Filesystem\Filesystem $files
47			*
48			*/
49			public function __construct(Filesystem $files)
50			{
51			parent::__construct();
52			$this->files = $files;
53			}
54
55			/**
56			* Execute the console command.
57			*/
58			public function handle()
59			{
60			$this->processOptions();
61			$this->checkIfSpatieMenuAlreadyInstalled();
62			$this->installSpatieMenu();
63			$this->publishSpatieMenu();
64			$this->publishSpatieMenuConfig();
65			}
66
67			/**
68			* Check if spatie menu is already installed.
69			*
70			* @throws SpatieMenuAlreadyExists
71			*/
72			protected function checkIfSpatieMenuAlreadyInstalled()
73			{
74			if ((app()->getProvider('Spatie\Menu\Laravel\MenuServiceProvider')) && ! $this->force) {
75			throw new SpatieMenuAlreadyExists();
76			}
77			return;
78			}
79
80			/**
81			* Install spatie/laravel-menu.
82			*/
83			protected function installSpatieMenu()
84			{
85			passthru('composer require spatie/laravel-menu');
86			}
87
88			/**
89			* Process options before running command.
90			*/
91			protected function processOptions()
92			{
93			$this->force = $this->option('force');
			0 ignored issues – show Documentation Bug introduced 2018-09-04 10:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->option('force')` can also be of type `string` or `array`. However, the property `$force` is declared as type `boolean`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
94			}
95
96			/**
97			* Publish sidebar with spatie menu
98			*/
99			protected function publishSpatieMenu()
100			{
101			$this->install(AdminLTE::spatieMenu());
102			}
103
104			/**
105			* Publish spatie menu config
106			*/
107			protected function publishSpatieMenuConfig()
108			{
109			$this->install(AdminLTE::menu());
110			}
111			}
112

acacha / adminlte-laravel

Push — master ( a64245...e0b49d )

src/Console/AdminLTEMenu.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like