Issues in Installable.php - All Issues - Inspection of "Now package routes can be disabled by config. This..." - acacha/adminlte-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fc3d6f...f7b1d9 )

by Sergi Tur

created 2018-03-13 16:58 UTC

src/Console/Installable.php (5 issues)

Labels

Bug 5

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Acacha\AdminLTETemplateLaravel\Console;

use League\Flysystem\Adapter\Local as LocalAdapter;
use League\Flysystem\Filesystem as Flysystem;
use League\Flysystem\MountManager;

/**
 * Class Installable.
 */
trait Installable
{
    /**
     * Install files from array.
     *
     * @param $files
     */
    private function install($files)
    {
        foreach ($files as $fileSrc => $fileDst) {
            if (file_exists($fileDst) && !$this->force && !$this->confirmOverwrite(basename($fileDst))) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                return;
            }
            if ($this->files->isFile($fileSrc)) {
                $this->publishFile($fileSrc, $fileDst);
            } elseif ($this->files->isDirectory($fileSrc)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->publishDirectory($fileSrc, $fileDst);
            } else {
                $this->error("Can't locate path: <{$fileSrc}>");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }
    }

    /**
     * @param $fileName
     * @param string $prompt
     *
     * @return bool
     */
    protected function confirmOverwrite($fileName, $prompt = '')
    {
        $prompt = (empty($prompt))
            ? $fileName.' already exists. Do you want to overwrite it? [y|N]'
            : $prompt;

        return $this->confirm($prompt, false);

    }

    /**
     * Create the directory to house the published files if needed.
     *
     * @param string $directory
     *
     * @return void
     */
    protected function createParentDirectory($directory)
    {
        if (!$this->files->isDirectory($directory)) {
            $this->files->makeDirectory($directory, 0755, true);
        }
    }

    /**
     * Publish the file to the given path.
     *
     * @param string $from
     * @param string $to
     *
     * @return void
     */
    protected function publishFile($from, $to)
    {
        $this->createParentDirectory(dirname($to));
        $this->files->copy($from, $to);
        $this->status($from, $to, 'File');
    }

    /**
     * Publish the directory to the given directory.
     *
     * @param string $from
     * @param string $to
     *
     * @return void
     */
    protected function publishDirectory($from, $to)
    {
        $manager = new MountManager([
            'from' => new Flysystem(new LocalAdapter($from)),
            'to'   => new Flysystem(new LocalAdapter($to)),
        ]);
        foreach ($manager->listContents('from://', true) as $file) {
            if ($file['type'] === 'file' && (!$manager->has('to://'.$file['path']) || $this->force)) {
                $manager->put('to://'.$file['path'], $manager->read('from://'.$file['path']));
            }
        }
        $this->status($from, $to, 'Directory');
    }

    /**
     * Write a status message to the console.
     *
     * @param string $from
     * @param string $to
     * @param string $type
     *
     * @return void
     */
    protected function status($from, $to, $type)
    {
        $from = str_replace(base_path(), '', realpath($from));
        $to = str_replace(base_path(), '', realpath($to));
        $this->line('<info>Copied '. $type. '</info> <comment>['. $from.
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ']</comment> <info>To</info> <comment>['.$to.']</comment>');
    }
}


1			<?php
2
3			namespace Acacha\AdminLTETemplateLaravel\Console;
4
5			use League\Flysystem\Adapter\Local as LocalAdapter;
6			use League\Flysystem\Filesystem as Flysystem;
7			use League\Flysystem\MountManager;
8
9			/**
10			* Class Installable.
11			*/
12			trait Installable
13			{
14			/**
15			* Install files from array.
16			*
17			* @param $files
18			*/
19			private function install($files)
20			{
21			foreach ($files as $fileSrc => $fileDst) {
22			if (file_exists($fileDst) && !$this->force && !$this->confirmOverwrite(basename($fileDst))) {
			0 ignored issues – show Bug introduced 2016-11-20 16:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `force` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			return;
24			}
25			if ($this->files->isFile($fileSrc)) {
26			$this->publishFile($fileSrc, $fileDst);
27			} elseif ($this->files->isDirectory($fileSrc)) {
			0 ignored issues – show Bug introduced 2016-11-20 16:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `files` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			$this->publishDirectory($fileSrc, $fileDst);
29			} else {
30			$this->error("Can't locate path: <{$fileSrc}>");
			0 ignored issues – show Bug introduced 2016-11-20 16:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `error()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			}
32			}
33			}
34
35			/**
36			* @param $fileName
37			* @param string $prompt
38			*
39			* @return bool
40			*/
41			protected function confirmOverwrite($fileName, $prompt = '')
42			{
43			$prompt = (empty($prompt))
44			? $fileName.' already exists. Do you want to overwrite it? [y\|N]'
45			: $prompt;
46
47			return $this->confirm($prompt, false);
			0 ignored issues – show Bug introduced 2016-11-20 16:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `confirm()` does not exist on `Acacha\AdminLTETemplateLaravel\Console\Installable`. Did you maybe mean `confirmOverwrite()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
48			}
49
50			/**
51			* Create the directory to house the published files if needed.
52			*
53			* @param string $directory
54			*
55			* @return void
56			*/
57			protected function createParentDirectory($directory)
58			{
59			if (!$this->files->isDirectory($directory)) {
60			$this->files->makeDirectory($directory, 0755, true);
61			}
62			}
63
64			/**
65			* Publish the file to the given path.
66			*
67			* @param string $from
68			* @param string $to
69			*
70			* @return void
71			*/
72			protected function publishFile($from, $to)
73			{
74			$this->createParentDirectory(dirname($to));
75			$this->files->copy($from, $to);
76			$this->status($from, $to, 'File');
77			}
78
79			/**
80			* Publish the directory to the given directory.
81			*
82			* @param string $from
83			* @param string $to
84			*
85			* @return void
86			*/
87			protected function publishDirectory($from, $to)
88			{
89			$manager = new MountManager([
90			'from' => new Flysystem(new LocalAdapter($from)),
91			'to' => new Flysystem(new LocalAdapter($to)),
92			]);
93			foreach ($manager->listContents('from://', true) as $file) {
94			if ($file['type'] === 'file' && (!$manager->has('to://'.$file['path']) \|\| $this->force)) {
95			$manager->put('to://'.$file['path'], $manager->read('from://'.$file['path']));
96			}
97			}
98			$this->status($from, $to, 'Directory');
99			}
100
101			/**
102			* Write a status message to the console.
103			*
104			* @param string $from
105			* @param string $to
106			* @param string $type
107			*
108			* @return void
109			*/
110			protected function status($from, $to, $type)
111			{
112			$from = str_replace(base_path(), '', realpath($from));
113			$to = str_replace(base_path(), '', realpath($to));
114			$this->line('<info>Copied '. $type. '</info> <comment>['. $from.
			0 ignored issues – show Bug introduced 2016-11-20 16:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `line()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
115			']</comment> <info>To</info> <comment>['.$to.']</comment>');
116			}
117			}
118

acacha / adminlte-laravel

Push — master ( fc3d6f...f7b1d9 )

src/Console/Installable.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like