Acacha\AdminLTETemplateLaravel\Console\HasUsername

Complexity

Total Complexity

3

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	username()	0	12	3

<?php


namespace Acacha\AdminLTETemplateLaravel\Console;

/**
 * Class HasUsername.
 *
 * @package Acacha\AdminLTETemplateLaravel\Console
 */
trait HasUsername
{
    /**
     * Obtains username.
     *
     * @return mixed|null|string
     */
    public function username()
    {
        if (($username = env('ADMIN_USERNAME', null)) != null) {
            return $username;
        }

        if (($username = git_user_name()) != null) {

It seems like you are loosely comparing $username = git_user_name() of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            return $username;
        }

        return "Admin";
    }
}