Acacha\AdminLTETemplateLaravel\Console\HasUsername::username()

Complexity

Conditions	3
Paths	3

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function username() {
        if (($username = env('ADMIN_USERNAME', null)) != null) return $username;

        if (($username = git_user_name()) != null) return $username;

It seems like you are loosely comparing $username = git_user_name() of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

        return "Admin";
    }
}