Paths - Code Metrics - Inspection of "Added Social command and refactoring" - acacha/adminlte-laravel-installer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0759a...dc0dc9 )

by Sergi Tur

created 2017-02-22 16:55 UTC

Paths A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	0
dl	0
loc	36
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getRealPath()	0	8	2
A	getUserHomePath()	0	12	3

<?php

namespace Acacha\AdminLTETemplateLaravel\Console\Traits;

/**
 * Class Paths.
 *
 * @package Acacha\AdminLTETemplateLaravel\Console\Traits
 */
trait Paths
{
    /**
     * Get the real path of a link or regular path if file is not a link.
     *
     * @param $file
     *
     * @return string
     */
    private function getRealPath($file)
    {
        if (is_link($file)) {
            return realpath($file);
        }

        return $file;
    }

    /**
     * Get user home path.
     *
     * @return string
     */
    public function getUserHomePath()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_SERVER['HOME'])) {
            return $_SERVER['HOME'];
        }

        if (PHP_OS == 'WINNT') {
            return getenv('USERPROFILE');
        } else {
            return getenv('HOME');
        }
    }
}

1			<?php
2
3			namespace Acacha\AdminLTETemplateLaravel\Console\Traits;
4
5			/**
6			* Class Paths.
7			*
8			* @package Acacha\AdminLTETemplateLaravel\Console\Traits
9			*/
10			trait Paths
11			{
12			/**
13			* Get the real path of a link or regular path if file is not a link.
14			*
15			* @param $file
16			*
17			* @return string
18			*/
19			private function getRealPath($file)
20			{
21			if (is_link($file)) {
22			return realpath($file);
23			}
24
25			return $file;
26			}
27
28			/**
29			* Get user home path.
30			*
31			* @return string
32			*/
33			public function getUserHomePath()
			0 ignored issues – show Coding Style introduced 2016-09-17 06:08 UTC by Report Bug Copy Issue Report `getUserHomePath` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
34			{
35			if (isset($_SERVER['HOME'])) {
36			return $_SERVER['HOME'];
37			}
38
39			if (PHP_OS == 'WINNT') {
40			return getenv('USERPROFILE');
41			} else {
42			return getenv('HOME');
43			}
44			}
45			}

acacha / adminlte-laravel-installer

Push — master ( e0759a...dc0dc9 )

Paths A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like