abzcoding / hget

util.go

package main

import (
	"net"
	"os"
	"github.com/mattn/go-isatty"
	"path/filepath"
	"errors"
	"strings"
	"net/url"
)

func FatalCheck(err error) {

exported function FatalCheck should have comment or be unexported

	if err != nil {
		Errorf("%v", err)
		panic(err)
	}
}

func FilterIPV4(ips []net.IP) []string {

exported function FilterIPV4 should have comment or be unexported

	var ret = make([]string, 0)
	for _, ip := range ips {
		if ip.To4() != nil {
			ret = append(ret, ip.String())
		}
	}
	return ret
}

func MkdirIfNotExist(folder string) error {

exported function MkdirIfNotExist should have comment or be unexported

	if _, err := os.Stat(folder); err != nil {
		if err = os.MkdirAll(folder, 0700); err != nil {
			return err
		}
	}
	return nil
}

func ExistDir(folder string) bool {

exported function ExistDir should have comment or be unexported

	_, err := os.Stat(folder)
	return err == nil
}

func DisplayProgressBar() bool {

exported function DisplayProgressBar should have comment or be unexported

	return isatty.IsTerminal(os.Stdout.Fd()) && displayProgress
}

func FolderOf(url string) string {

exported function FolderOf should have comment or be unexported

	safePath := filepath.Join(os.Getenv("HOME"), dataFolder)
	fullQualifyPath, err := filepath.Abs(filepath.Join(os.Getenv("HOME"), dataFolder, filepath.Base(url)))
	FatalCheck(err)

	//must ensure full qualify path is CHILD of safe path
	//to prevent directory traversal attack
	//using Rel function to get relative between parent and child
	//if relative join base == child, then child path MUST BE real child
	relative, err := filepath.Rel(safePath, fullQualifyPath)
	FatalCheck(err)

	if strings.Contains(relative, "..") {
		FatalCheck(errors.New("you may be a victim of directory traversal path attack\n"))

error strings should not be capitalized or end with punctuation or a newline

		return "" //return is redundant be cause in fatal check we have panic, but compiler does not able to check
	} else {

if block ends with a return statement, so drop this else and outdent its block

		return fullQualifyPath
	}
}

func TaskFromUrl(url string) string {

exported function TaskFromUrl should have comment or be unexported

func TaskFromUrl should be TaskFromURL

	//task is just download file name
	//so we get download file name on url
	filename := filepath.Base(url)
	return filename
}

func IsUrl(s string) bool {

exported function IsUrl should have comment or be unexported

func IsUrl should be IsURL

	_, err := url.Parse(s)
	return err == nil
}