main.JoinFile - Code Metrics - Inspection of "Update README.md" - abzcoding/hget - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ceb836...fae557 )

by Abouzar

created 2021-06-21 22:01 UTC

main.JoinFile B

↳ Parent: joiner.go

Complexity

Conditions

Size

Total Lines	30
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	18
nop	2
dl	0
loc	30
rs	8
c	0
b	0
f	0

package main

import (
	"github.com/fatih/color"
	"gopkg.in/cheggaaa/pb.v1"
	"io"
	"os"
	"sort"
)

func JoinFile(files []string, out string) error {

	//sort with file name or we will join files with wrong order
	sort.Strings(files)
	var bar *pb.ProgressBar

	if DisplayProgressBar() {
		Printf("Start joining \n")
		bar = pb.StartNew(len(files)).Prefix(color.CyanString("Joining"))
	}

	outf, err := os.OpenFile(out, os.O_CREATE|os.O_WRONLY, 0600)
	defer outf.Close()
	if err != nil {
		return err
	}

	for _, f := range files {
		if err = copy(f, outf); err != nil {
			return err
		}
		if DisplayProgressBar() {
			bar.Increment()
		}
	}

	if DisplayProgressBar() {
		bar.Finish()
	}

	return nil
}

//this function split just to use defer
func copy(from string, to io.Writer) error {
	f, err := os.OpenFile(from, os.O_RDONLY, 0600)
	defer f.Close()
	if err != nil {
		return err
	}
	io.Copy(to, f)
	return nil
}


1			package main
2
3			import (
4			"github.com/fatih/color"
5			"gopkg.in/cheggaaa/pb.v1"
6			"io"
7			"os"
8			"sort"
9			)
10
11			func JoinFile(files []string, out string) error {
			0 ignored issues – show introduced 2021-06-21 22:00 UTC by Report Bug Copy Issue Report exported function JoinFile should have comment or be unexported Loading history...
12			//sort with file name or we will join files with wrong order
13			sort.Strings(files)
14			var bar *pb.ProgressBar
15
16			if DisplayProgressBar() {
17			Printf("Start joining \n")
18			bar = pb.StartNew(len(files)).Prefix(color.CyanString("Joining"))
19			}
20
21			outf, err := os.OpenFile(out, os.O_CREATE\|os.O_WRONLY, 0600)
22			defer outf.Close()
23			if err != nil {
24			return err
25			}
26
27			for _, f := range files {
28			if err = copy(f, outf); err != nil {
29			return err
30			}
31			if DisplayProgressBar() {
32			bar.Increment()
33			}
34			}
35
36			if DisplayProgressBar() {
37			bar.Finish()
38			}
39
40			return nil
41			}
42
43			//this function split just to use defer
44			func copy(from string, to io.Writer) error {
45			f, err := os.OpenFile(from, os.O_RDONLY, 0600)
46			defer f.Close()
47			if err != nil {
48			return err
49			}
50			io.Copy(to, f)
51			return nil
52			}
53

abzcoding / hget

Push — master ( ceb836...fae557 )

main.JoinFile B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like