main.Execute - Code Metrics - Inspection of "feat: add some test cases and upgrade go version" - abzcoding/hget - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 52dc69...dab326 )

by Abouzar

created 2025-03-23 18:32 UTC

main.Execute D

↳ Parent: main.go

Complexity

Conditions

Size

Total Lines	66
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	54
nop	6
dl	0
loc	66
rs	4.8
c	0
b	0
f	0

How to fix Long Method Complexity

package main

import (
	"bufio"
	"flag"
	"io"
	"os"
	"os/signal"
	"runtime"
	"syscall"

	"github.com/imkira/go-task"
)

var displayProgress = true

func main() {
	// var err error
	var proxy, filePath, bwLimit, resumeTask string

	conn := flag.Int("n", runtime.NumCPU(), "number of connections")
	skiptls := flag.Bool("skip-tls", false, "skip certificate verification for https")
	flag.StringVar(&proxy, "proxy", "", "proxy for downloading, e.g. -proxy '127.0.0.1:12345' for socks5 or -proxy 'http://proxy.com:8080' for http proxy")
	flag.StringVar(&filePath, "file", "", "path to a file that contains one URL per line")
	flag.StringVar(&bwLimit, "rate", "", "bandwidth limit during download, e.g. -rate 10kB or -rate 10MiB")
	flag.StringVar(&resumeTask, "resume", "", "resume download task with given task name (or URL)")

	flag.Parse()
	args := flag.Args()

	// If the resume flag is provided, use that path (ignoring other arguments)
	if resumeTask != "" {
		state, err := Resume(resumeTask)
		FatalCheck(err)
		Execute(state.URL, state, *conn, *skiptls, proxy, bwLimit)
		return
	}

	// If no resume flag, then check for positional URL or file input
	if len(args) < 1 {
		if len(filePath) < 1 {
			Errorln("A URL or input file with URLs is required")
			usage()
			os.Exit(1)
		}
		// Create a serial group for processing multiple URLs in a file.
		g1 := task.NewSerialGroup()
		file, err := os.Open(filePath)
		if err != nil {
			FatalCheck(err)
		}
		defer file.Close()

		reader := bufio.NewReader(file)
		for {
			line, _, err := reader.ReadLine()
			if err == io.EOF {
				break
			}
			url := string(line)
			// Add the download task for each URL
			g1.AddChild(downloadTask(url, nil, *conn, *skiptls, proxy, bwLimit))
		}
		g1.Run(nil)
		return
	}

	// Otherwise, if a URL is provided as positional argument, treat it as a new download.
	downloadURL := args[0]
	// Check if a folder already exists for the task and remove if necessary.
	if ExistDir(FolderOf(downloadURL)) {
		Warnf("Downloading task already exists, remove it first \n")
		err := os.RemoveAll(FolderOf(downloadURL))
		FatalCheck(err)
	}
	Execute(downloadURL, nil, *conn, *skiptls, proxy, bwLimit)
}

func downloadTask(url string, state *State, conn int, skiptls bool, proxy string, bwLimit string) task.Task {
	run := func(t task.Task, ctx task.Context) {
		Execute(url, state, conn, skiptls, proxy, bwLimit)
	}
	return task.NewTaskWithFunc(run)
}

// Execute configures the HTTPDownloader and uses it to download the target.
func Execute(url string, state *State, conn int, skiptls bool, proxy string, bwLimit string) {
	// Capture OS interrupt signals
	signalChan := make(chan os.Signal, 1)
	signal.Notify(signalChan,
		syscall.SIGHUP,
		syscall.SIGINT,
		syscall.SIGTERM,
		syscall.SIGQUIT)

	var files = make([]string, 0)
	var parts = make([]Part, 0)
	var isInterrupted = false

	doneChan := make(chan bool, conn)
	fileChan := make(chan string, conn)
	errorChan := make(chan error, 1)
	stateChan := make(chan Part, 1)
	interruptChan := make(chan bool, conn)

	var downloader *HTTPDownloader
	if state == nil {
		downloader = NewHTTPDownloader(url, conn, skiptls, proxy, bwLimit)
	} else {
		downloader = &HTTPDownloader{
			url:       state.URL,
			file:      TaskFromURL(state.URL),
			par:       int64(len(state.Parts)),
			parts:     state.Parts,
			resumable: true,
		}
	}
	go downloader.Do(doneChan, fileChan, errorChan, interruptChan, stateChan)

	for {
		select {
		case <-signalChan:
			// Signal all active download routines to interrupt.
			isInterrupted = true
			for range conn {
				interruptChan <- true
			}
		case file := <-fileChan:
			files = append(files, file)
		case err := <-errorChan:
			Errorf("%v", err)
			panic(err)
		case part := <-stateChan:
			parts = append(parts, part)
		case <-doneChan:
			if isInterrupted {
				if downloader.resumable {
					Printf("Interrupted, saving state...\n")
					s := &State{URL: url, Parts: parts}
					if err := s.Save(); err != nil {
						Errorf("%v\n", err)
					}
				} else {
					Warnf("Interrupted, but the download is not resumable. Exiting silently.\n")
				}
			} else {
				err := JoinFile(files, TaskFromURL(url))
				FatalCheck(err)
				err = os.RemoveAll(FolderOf(url))
				FatalCheck(err)
			}
			return
		}
	}
}

func usage() {
	Printf(`Usage:
hget [options] URL
hget [options] --resume=TaskName

Options:
  -n int          number of connections (default number of CPUs)
  -skip-tls bool  skip certificate verification for https (default false)
  -proxy string   proxy address (e.g., '127.0.0.1:12345' for socks5 or 'http://proxy.com:8080')
  -file string    file path containing URLs (one per line)
  -rate string    bandwidth limit during download (e.g., 10kB, 10MiB)
  -resume string  resume a stopped download by providing its task name or URL
`)
}


1			package main
2
3			import (
4			"bufio"
5			"flag"
6			"io"
7			"os"
8			"os/signal"
9			"runtime"
10			"syscall"
11
12			"github.com/imkira/go-task"
13			)
14
15			var displayProgress = true
16
17			func main() {
18			// var err error
19			var proxy, filePath, bwLimit, resumeTask string
20
21			conn := flag.Int("n", runtime.NumCPU(), "number of connections")
22			skiptls := flag.Bool("skip-tls", false, "skip certificate verification for https")
23			flag.StringVar(&proxy, "proxy", "", "proxy for downloading, e.g. -proxy '127.0.0.1:12345' for socks5 or -proxy 'http://proxy.com:8080' for http proxy")
24			flag.StringVar(&filePath, "file", "", "path to a file that contains one URL per line")
25			flag.StringVar(&bwLimit, "rate", "", "bandwidth limit during download, e.g. -rate 10kB or -rate 10MiB")
26			flag.StringVar(&resumeTask, "resume", "", "resume download task with given task name (or URL)")
27
28			flag.Parse()
29			args := flag.Args()
30
31			// If the resume flag is provided, use that path (ignoring other arguments)
32			if resumeTask != "" {
33			state, err := Resume(resumeTask)
34			FatalCheck(err)
35			Execute(state.URL, state, conn, skiptls, proxy, bwLimit)
36			return
37			}
38
39			// If no resume flag, then check for positional URL or file input
40			if len(args) < 1 {
41			if len(filePath) < 1 {
42			Errorln("A URL or input file with URLs is required")
43			usage()
44			os.Exit(1)
45			}
46			// Create a serial group for processing multiple URLs in a file.
47			g1 := task.NewSerialGroup()
48			file, err := os.Open(filePath)
49			if err != nil {
50			FatalCheck(err)
51			}
52			defer file.Close()
53
54			reader := bufio.NewReader(file)
55			for {
56			line, _, err := reader.ReadLine()
57			if err == io.EOF {
58			break
59			}
60			url := string(line)
61			// Add the download task for each URL
62			g1.AddChild(downloadTask(url, nil, conn, skiptls, proxy, bwLimit))
63			}
64			g1.Run(nil)
65			return
66			}
67
68			// Otherwise, if a URL is provided as positional argument, treat it as a new download.
69			downloadURL := args[0]
70			// Check if a folder already exists for the task and remove if necessary.
71			if ExistDir(FolderOf(downloadURL)) {
72			Warnf("Downloading task already exists, remove it first \n")
73			err := os.RemoveAll(FolderOf(downloadURL))
74			FatalCheck(err)
75			}
76			Execute(downloadURL, nil, conn, skiptls, proxy, bwLimit)
77			}
78
79			func downloadTask(url string, state *State, conn int, skiptls bool, proxy string, bwLimit string) task.Task {
80			run := func(t task.Task, ctx task.Context) {
81			Execute(url, state, conn, skiptls, proxy, bwLimit)
82			}
83			return task.NewTaskWithFunc(run)
84			}
85
86			// Execute configures the HTTPDownloader and uses it to download the target.
87			func Execute(url string, state *State, conn int, skiptls bool, proxy string, bwLimit string) {
88			// Capture OS interrupt signals
89			signalChan := make(chan os.Signal, 1)
90			signal.Notify(signalChan,
91			syscall.SIGHUP,
92			syscall.SIGINT,
93			syscall.SIGTERM,
94			syscall.SIGQUIT)
95
96			var files = make([]string, 0)
97			var parts = make([]Part, 0)
98			var isInterrupted = false
99
100			doneChan := make(chan bool, conn)
101			fileChan := make(chan string, conn)
102			errorChan := make(chan error, 1)
103			stateChan := make(chan Part, 1)
104			interruptChan := make(chan bool, conn)
105
106			var downloader *HTTPDownloader
107			if state == nil {
108			downloader = NewHTTPDownloader(url, conn, skiptls, proxy, bwLimit)
109			} else {
110			downloader = &HTTPDownloader{
111			url: state.URL,
112			file: TaskFromURL(state.URL),
113			par: int64(len(state.Parts)),
114			parts: state.Parts,
115			resumable: true,
116			}
117			}
118			go downloader.Do(doneChan, fileChan, errorChan, interruptChan, stateChan)
119
120			for {
121			select {
122			case <-signalChan:
123			// Signal all active download routines to interrupt.
124			isInterrupted = true
125			for range conn {
126			interruptChan <- true
127			}
128			case file := <-fileChan:
129			files = append(files, file)
130			case err := <-errorChan:
131			Errorf("%v", err)
132			panic(err)
133			case part := <-stateChan:
134			parts = append(parts, part)
135			case <-doneChan:
136			if isInterrupted {
137			if downloader.resumable {
138			Printf("Interrupted, saving state...\n")
139			s := &State{URL: url, Parts: parts}
140			if err := s.Save(); err != nil {
141			Errorf("%v\n", err)
142			}
143			} else {
144			Warnf("Interrupted, but the download is not resumable. Exiting silently.\n")
145			}
146			} else {
147			err := JoinFile(files, TaskFromURL(url))
148			FatalCheck(err)
149			err = os.RemoveAll(FolderOf(url))
150			FatalCheck(err)
151			}
152			return
153			}
154			}
155			}
156
157			func usage() {
158			Printf(`Usage:
159			hget [options] URL
160			hget [options] --resume=TaskName
161
162			Options:
163			-n int number of connections (default number of CPUs)
164			-skip-tls bool skip certificate verification for https (default false)
165			-proxy string proxy address (e.g., '127.0.0.1:12345' for socks5 or 'http://proxy.com:8080')
166			-file string file path containing URLs (one per line)
167			-rate string bandwidth limit during download (e.g., 10kB, 10MiB)
168			-resume string resume a stopped download by providing its task name or URL
169			`)
170			}
171

abzcoding / hget

Push — master ( 52dc69...dab326 )

main.Execute D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like