tests.test_client.TestClient.send() - Code Metrics - Inspection of "reverted test_client because of the introduced iss..." - abzcoding/flask-sample - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0fd7f1...f885f2 )

by Abouzar

created 2018-09-20 20:56 UTC

tests.test_client.TestClient.send() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines	27
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	25
nop	5
dl	0
loc	27
rs	7.3333
c	0
b	0
f	0

from base64 import b64encode
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from werkzeug.exceptions import HTTPException
import json



class TestClient():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
  def __init__(self, app, username, password):
    self.app = app
    if username is None:
      self.auth = None
    else:
      self.auth = 'Basic ' + b64encode(
          (username + ':' + password).encode('utf-8')).decode('utf-8')

  def send(self, url, method='GET', data=None, headers={}):
# Bad:
# If array_param is modified inside the function, the next invocation will
# receive the modified object.
def some_function(array_param=[]):
    # ...

# Better: Create an array on each invocation
def some_function(array_param=None):
    array_param = array_param or []
    # ...
    headers = headers.copy()
    if self.auth is not None:
      headers['Authorization'] = self.auth
    headers['Content-Type'] = 'application/json'
    headers['Accept'] = 'application/json'
    if data:
      data = json.dumps(data)

    with self.app.test_request_context(
        url, method=method, data=data, headers=headers):
      try:
        rv = self.app.preprocess_request()

        if rv is None:
          rv = self.app.dispatch_request()

        rv = self.app.make_response(rv)

        rv = self.app.process_response(rv)

      except HTTPException as e:

        rv = self.app.handle_user_exception(e)


    try:
      json_data = json.loads(rv.data.decode('utf-8'))
    except AttributeError:
      json_data = None
    except json.decoder.JSONDecodeError:
      json_data = None
    return rv, json_data

  def get(self, url, headers={}):
# Bad:
# If array_param is modified inside the function, the next invocation will
# receive the modified object.
def some_function(array_param=[]):
    # ...

# Better: Create an array on each invocation
def some_function(array_param=None):
    array_param = array_param or []
    # ...
    return self.send(url, 'GET', headers=headers)

  def post(self, url, data, headers={}):
# Bad:
# If array_param is modified inside the function, the next invocation will
# receive the modified object.
def some_function(array_param=[]):
    # ...

# Better: Create an array on each invocation
def some_function(array_param=None):
    array_param = array_param or []
    # ...
    return self.send(url, 'POST', data, headers=headers)

  def put(self, url, data, headers={}):
# Bad:
# If array_param is modified inside the function, the next invocation will
# receive the modified object.
def some_function(array_param=[]):
    # ...

# Better: Create an array on each invocation
def some_function(array_param=None):
    array_param = array_param or []
    # ...
    return self.send(url, 'PUT', data, headers=headers)

  def delete(self, url, headers={}):
# Bad:
# If array_param is modified inside the function, the next invocation will
# receive the modified object.
def some_function(array_param=[]):
    # ...

# Better: Create an array on each invocation
def some_function(array_param=None):
    array_param = array_param or []
    # ...
    return self.send(url, 'DELETE', headers=headers)

  def head(self, url, headers={}):
# Bad:
# If array_param is modified inside the function, the next invocation will
# receive the modified object.
def some_function(array_param=[]):
    # ...

# Better: Create an array on each invocation
def some_function(array_param=None):
    array_param = array_param or []
    # ...
    return self.send(url, 'HEAD', headers=headers)


1			from base64 import b64encode
			0 ignored issues – show Coding Style introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from werkzeug.exceptions import HTTPException
3			import json
			0 ignored issues – show introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report standard import "import json" should be placed before "from werkzeug.exceptions import HTTPException" Loading history...
4
5
6			class TestClient():
			0 ignored issues – show Coding Style introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
7			def __init__(self, app, username, password):
8			self.app = app
9			if username is None:
10			self.auth = None
11			else:
12			self.auth = 'Basic ' + b64encode(
13			(username + ':' + password).encode('utf-8')).decode('utf-8')
14
15			def send(self, url, method='GET', data=None, headers={}):
			0 ignored issues – show Bug Best Practice introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The default value `{}` might cause unintended side-effects. Objects as default values are only created once in Python and not on each invocation of the function. If the default object is modified, this modification is carried over to the next invocation of the method. # Bad: # If array_param is modified inside the function, the next invocation will # receive the modified object. def some_function(array_param=[]): # ... # Better: Create an array on each invocation def some_function(array_param=None): array_param = array_param or [] # ... Loading history... Coding Style introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
16			headers = headers.copy()
17			if self.auth is not None:
18			headers['Authorization'] = self.auth
19			headers['Content-Type'] = 'application/json'
20			headers['Accept'] = 'application/json'
21			if data:
22			data = json.dumps(data)
23
24			with self.app.test_request_context(
25			url, method=method, data=data, headers=headers):
26			try:
27			rv = self.app.preprocess_request()
			0 ignored issues – show Coding Style Naming introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The name `rv` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
28			if rv is None:
29			rv = self.app.dispatch_request()
			0 ignored issues – show Coding Style Naming introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The name `rv` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
30			rv = self.app.make_response(rv)
			0 ignored issues – show Coding Style Naming introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The name `rv` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
31			rv = self.app.process_response(rv)
			0 ignored issues – show Coding Style Naming introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The name `rv` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
32			except HTTPException as e:
			0 ignored issues – show Coding Style Naming introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
33			rv = self.app.handle_user_exception(e)
			0 ignored issues – show Coding Style Naming introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The name `rv` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
34
35			try:
36			json_data = json.loads(rv.data.decode('utf-8'))
37			except AttributeError:
38			json_data = None
39			except json.decoder.JSONDecodeError:
40			json_data = None
41			return rv, json_data
42
43			def get(self, url, headers={}):
			0 ignored issues – show Bug Best Practice introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The default value `{}` might cause unintended side-effects. Objects as default values are only created once in Python and not on each invocation of the function. If the default object is modified, this modification is carried over to the next invocation of the method. # Bad: # If array_param is modified inside the function, the next invocation will # receive the modified object. def some_function(array_param=[]): # ... # Better: Create an array on each invocation def some_function(array_param=None): array_param = array_param or [] # ... Loading history... Coding Style introduced 2018-09-20 20:58 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
44			return self.send(url, 'GET', headers=headers)
45
46			def post(self, url, data, headers={}):
			0 ignored issues – show Bug Best Practice introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The default value `{}` might cause unintended side-effects. Objects as default values are only created once in Python and not on each invocation of the function. If the default object is modified, this modification is carried over to the next invocation of the method. # Bad: # If array_param is modified inside the function, the next invocation will # receive the modified object. def some_function(array_param=[]): # ... # Better: Create an array on each invocation def some_function(array_param=None): array_param = array_param or [] # ... Loading history... Coding Style introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
47			return self.send(url, 'POST', data, headers=headers)
48
49			def put(self, url, data, headers={}):
			0 ignored issues – show Bug Best Practice introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The default value `{}` might cause unintended side-effects. Objects as default values are only created once in Python and not on each invocation of the function. If the default object is modified, this modification is carried over to the next invocation of the method. # Bad: # If array_param is modified inside the function, the next invocation will # receive the modified object. def some_function(array_param=[]): # ... # Better: Create an array on each invocation def some_function(array_param=None): array_param = array_param or [] # ... Loading history... Coding Style introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
50			return self.send(url, 'PUT', data, headers=headers)
51
52			def delete(self, url, headers={}):
			0 ignored issues – show Bug Best Practice introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The default value `{}` might cause unintended side-effects. Objects as default values are only created once in Python and not on each invocation of the function. If the default object is modified, this modification is carried over to the next invocation of the method. # Bad: # If array_param is modified inside the function, the next invocation will # receive the modified object. def some_function(array_param=[]): # ... # Better: Create an array on each invocation def some_function(array_param=None): array_param = array_param or [] # ... Loading history... Coding Style introduced 2018-09-20 20:58 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
53			return self.send(url, 'DELETE', headers=headers)
54
55			def head(self, url, headers={}):
			0 ignored issues – show Bug Best Practice introduced 2018-09-18 14:19 UTC by Report Bug Copy Issue Report The default value `{}` might cause unintended side-effects. Objects as default values are only created once in Python and not on each invocation of the function. If the default object is modified, this modification is carried over to the next invocation of the method. # Bad: # If array_param is modified inside the function, the next invocation will # receive the modified object. def some_function(array_param=[]): # ... # Better: Create an array on each invocation def some_function(array_param=None): array_param = array_param or [] # ... Loading history... Coding Style introduced 2018-09-20 20:58 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
56			return self.send(url, 'HEAD', headers=headers)
57

abzcoding / flask-sample

Push — master ( 0fd7f1...f885f2 )

tests.test_client.TestClient.send() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like