PageViewed::setPage() - Code Metrics - Inspection of "Lead and isDraft related changes to pages" - abterphp/website - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( df08cc...276b2d )

by Peter

created 2019-07-27 07:44 UTC

PageViewed::setPage() A

↳ Parent: PageViewed

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	6
rs	10

<?php

declare(strict_types=1);

namespace AbterPhp\Website\Events;

use AbterPhp\Website\Domain\Entities\Page as Entity;

class PageViewed
{
    /** @var Entity */
    private $page;

    /** @var bool */
    private $isAllowed = false;

    /** @var string[] */
    private $userGroupIdentifiers = [];

    /**
     * PageViewed constructor.
     *
     * @param Entity $page
     * @param array   $userGroupIdentifiers
     */
    public function __construct(Entity $page, array $userGroupIdentifiers)
    {
        $this->setPage($page);

        $this->userGroupIdentifiers = $userGroupIdentifiers;
    }

    /**
     * @return Entity
     */
    public function getPage(): Entity
    {
        return $this->page;
    }

    /**
     * @return IView
filter:
    dependency_paths: ["lib/*"]
     */
    public function setPage(Entity $page): PageViewed
    {
        $this->page      = $page;
        $this->isAllowed = !$page->isDraft();

        return $this;

    }

    /**
     * @return bool
     */
    public function isAllowed(): bool
    {
        return $this->isAllowed;
    }

    /**
     * @param bool $isAllowed
     */
    public function setIsAllowed(bool $isAllowed): void
    {
        $this->isAllowed = $isAllowed;
    }

    /**
     * @return string[]
     */
    public function getUserGroupIdentifiers(): array
    {
        return $this->userGroupIdentifiers;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AbterPhp\Website\Events;
6
7			use AbterPhp\Website\Domain\Entities\Page as Entity;
8
9			class PageViewed
10			{
11			/** @var Entity */
12			private $page;
13
14			/** @var bool */
15			private $isAllowed = false;
16
17			/** @var string[] */
18			private $userGroupIdentifiers = [];
19
20			/**
21			* PageViewed constructor.
22			*
23			* @param Entity $page
24			* @param array $userGroupIdentifiers
25			*/
26			public function __construct(Entity $page, array $userGroupIdentifiers)
27			{
28			$this->setPage($page);
29
30			$this->userGroupIdentifiers = $userGroupIdentifiers;
31			}
32
33			/**
34			* @return Entity
35			*/
36			public function getPage(): Entity
37			{
38			return $this->page;
39			}
40
41			/**
42			* @return IView
			0 ignored issues – show Bug introduced 2019-07-27 07:47 UTC by Report Bug Copy Issue Report The type `AbterPhp\Website\Events\IView` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
43			*/
44			public function setPage(Entity $page): PageViewed
45			{
46			$this->page = $page;
47			$this->isAllowed = !$page->isDraft();
48
49			return $this;
			0 ignored issues – show Bug Best Practice introduced 2019-07-27 07:47 UTC by Report Bug Copy Issue Report The expression `return $this` returns the type `AbterPhp\Website\Events\PageViewed` which is incompatible with the documented return type `AbterPhp\Website\Events\IView`. Loading history...
50			}
51
52			/**
53			* @return bool
54			*/
55			public function isAllowed(): bool
56			{
57			return $this->isAllowed;
58			}
59
60			/**
61			* @param bool $isAllowed
62			*/
63			public function setIsAllowed(bool $isAllowed): void
64			{
65			$this->isAllowed = $isAllowed;
66			}
67
68			/**
69			* @return string[]
70			*/
71			public function getUserGroupIdentifiers(): array
72			{
73			return $this->userGroupIdentifiers;
74			}
75			}
76

abterphp / website

Push — master ( df08cc...276b2d )

PageViewed::setPage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like