Conditions | 1 |
Paths | 1 |
Total Lines | 193 |
Code Lines | 155 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
18 | public function successProvider(): array |
||
19 | { |
||
20 | return [ |
||
21 | 'param-unnamed-auto-null' => [ |
||
22 | 'foo = ?', |
||
23 | [null], |
||
24 | Expr::PARAM_ALL_AUTO, |
||
25 | 'foo = ?', |
||
26 | [[null, PDO::PARAM_NULL]], |
||
27 | ], |
||
28 | 'param-unnamed-auto-int' => ['foo = ?', [2], Expr::PARAM_ALL_AUTO, 'foo = ?', [[2, PDO::PARAM_INT]]], |
||
29 | 'param-unnamed-auto-false' => [ |
||
30 | 'foo = ?', |
||
31 | [false], |
||
32 | Expr::PARAM_ALL_AUTO, |
||
33 | 'foo = ?', |
||
34 | [[false, PDO::PARAM_BOOL]], |
||
35 | ], |
||
36 | 'param-unnamed-auto-true' => [ |
||
37 | 'foo = ?', |
||
38 | [true], |
||
39 | Expr::PARAM_ALL_AUTO, |
||
40 | 'foo = ?', |
||
41 | [[true, PDO::PARAM_BOOL]], |
||
42 | ], |
||
43 | 'param-unnamed-auto-str' => [ |
||
44 | 'foo = ?', |
||
45 | ['bar'], |
||
46 | Expr::PARAM_ALL_AUTO, |
||
47 | 'foo = ?', |
||
48 | [['bar', PDO::PARAM_STR]], |
||
49 | ], |
||
50 | 'param-unnamed-str' => [ |
||
51 | 'foo = ?', |
||
52 | [2], |
||
53 | Expr::PARAM_ALL_STRING, |
||
54 | 'foo = ?', |
||
55 | [[2, PDO::PARAM_STR]], |
||
56 | ], |
||
57 | 'param-unnamed-manual' => [ |
||
58 | 'foo = ?', |
||
59 | [[2, PDO::PARAM_BOOL]], |
||
60 | Expr::PARAM_ALL_MANUAL, |
||
61 | 'foo = ?', |
||
62 | [[2, PDO::PARAM_BOOL]], |
||
63 | ], |
||
64 | 'param-named-auto' => [ |
||
65 | 'foo = :foo', |
||
66 | ['foo' => 2], |
||
67 | Expr::PARAM_ALL_AUTO, |
||
68 | 'foo = :foo', |
||
69 | ['foo' => [2, PDO::PARAM_INT]], |
||
70 | ], |
||
71 | 'param-named-str' => [ |
||
72 | 'foo = :foo', |
||
73 | ['foo' => 2], |
||
74 | Expr::PARAM_ALL_STRING, |
||
75 | 'foo = :foo', |
||
76 | ['foo' => [2, PDO::PARAM_STR]], |
||
77 | ], |
||
78 | 'param-named-manual' => [ |
||
79 | 'foo = :foo', |
||
80 | ['foo' => [2, PDO::PARAM_BOOL]], |
||
81 | Expr::PARAM_ALL_MANUAL, |
||
82 | 'foo = :foo', |
||
83 | ['foo' => [2, PDO::PARAM_BOOL]], |
||
84 | ], |
||
85 | 'unnamed-extend-auto-simple' => [ |
||
86 | 'foo IN (?)', |
||
87 | [['bar', 'baz']], |
||
88 | Expr::PARAM_ALL_AUTO, |
||
89 | 'foo IN (?, ?)', |
||
90 | [['bar', PDO::PARAM_STR], ['baz', PDO::PARAM_STR]], |
||
91 | ], |
||
92 | 'unnamed-extend-auto-end' => [ |
||
93 | 'foo IN (?', |
||
94 | [['bar', 'baz']], |
||
95 | Expr::PARAM_ALL_AUTO, |
||
96 | 'foo IN (?, ?', |
||
97 | [['bar', PDO::PARAM_STR], ['baz', PDO::PARAM_STR]], |
||
98 | ], |
||
99 | 'unnamed-extend-auto-beginning' => [ |
||
100 | '?)', |
||
101 | [['bar', 'baz']], |
||
102 | Expr::PARAM_ALL_AUTO, |
||
103 | '?, ?)', |
||
104 | [['bar', PDO::PARAM_STR], ['baz', PDO::PARAM_STR]], |
||
105 | ], |
||
106 | 'unnamed-extend-auto-complex' => [ |
||
107 | 'foo IN (?) AND bar = ? AND baz IN (?)', |
||
108 | [['bar', 'baz'], 'quix', [17, 34]], |
||
109 | Expr::PARAM_ALL_AUTO, |
||
110 | 'foo IN (?, ?) AND bar = ? AND baz IN (?, ?)', |
||
111 | [ |
||
112 | ['bar', PDO::PARAM_STR], |
||
113 | ['baz', PDO::PARAM_STR], |
||
114 | ['quix', PDO::PARAM_STR], |
||
115 | [17, PDO::PARAM_INT], |
||
116 | [34, PDO::PARAM_INT], |
||
117 | ], |
||
118 | ], |
||
119 | 'unnamed-extend-manual-complex' => [ |
||
120 | 'foo IN (?) AND bar = ? AND baz IN (?)', |
||
121 | [ |
||
122 | [['bar', PDO::PARAM_STR], ['baz', PDO::PARAM_STR]], |
||
123 | ['quix', PDO::PARAM_STR], |
||
124 | [[17, PDO::PARAM_INT], [34, PDO::PARAM_STR]], |
||
125 | ], |
||
126 | Expr::PARAM_ALL_MANUAL, |
||
127 | 'foo IN (?, ?) AND bar = ? AND baz IN (?, ?)', |
||
128 | [ |
||
129 | ['bar', PDO::PARAM_STR], |
||
130 | ['baz', PDO::PARAM_STR], |
||
131 | ['quix', PDO::PARAM_STR], |
||
132 | [17, PDO::PARAM_INT], |
||
133 | [34, PDO::PARAM_STR], |
||
134 | ], |
||
135 | ], |
||
136 | 'unnamed-extend-str-complex' => [ |
||
137 | 'foo IN (?) AND bar = ? AND baz IN (?)', |
||
138 | [['bar', 'baz'], 'quix', [17, 34]], |
||
139 | Expr::PARAM_ALL_STRING, |
||
140 | 'foo IN (?, ?) AND bar = ? AND baz IN (?, ?)', |
||
141 | [ |
||
142 | ['bar', PDO::PARAM_STR], |
||
143 | ['baz', PDO::PARAM_STR], |
||
144 | ['quix', PDO::PARAM_STR], |
||
145 | [17, PDO::PARAM_STR], |
||
146 | [34, PDO::PARAM_STR], |
||
147 | ], |
||
148 | ], |
||
149 | 'named-extend-auto-simple' => [ |
||
150 | 'foo IN (:foo)', |
||
151 | ['foo' => ['bar', 'baz']], |
||
152 | Expr::PARAM_ALL_AUTO, |
||
153 | 'foo IN (:foo_0, :foo_1)', |
||
154 | ['foo_0' => ['bar', PDO::PARAM_STR], 'foo_1' => ['baz', PDO::PARAM_STR]], |
||
155 | ], |
||
156 | 'named-extend-auto-end' => [ |
||
157 | 'foo IN (:foo', |
||
158 | ['foo' => ['bar', 'baz']], |
||
159 | Expr::PARAM_ALL_AUTO, |
||
160 | 'foo IN (:foo_0, :foo_1', |
||
161 | ['foo_0' => ['bar', PDO::PARAM_STR], 'foo_1' => ['baz', PDO::PARAM_STR]], |
||
162 | ], |
||
163 | 'named-extend-auto-beginning' => [ |
||
164 | ':foo)', |
||
165 | ['foo' => ['bar', 'baz']], |
||
166 | Expr::PARAM_ALL_AUTO, |
||
167 | ':foo_0, :foo_1)', |
||
168 | ['foo_0' => ['bar', PDO::PARAM_STR], 'foo_1' => ['baz', PDO::PARAM_STR]], |
||
169 | ], |
||
170 | 'named-extend-auto-complex' => [ |
||
171 | 'foo IN (:foo) AND bar = :bar AND baz IN (:baz)', |
||
172 | ['foo' => ['bar', 'baz'], 'bar' => 'quix', 'baz' => [17, 34]], |
||
173 | Expr::PARAM_ALL_AUTO, |
||
174 | 'foo IN (:foo_0, :foo_1) AND bar = :bar AND baz IN (:baz_0, :baz_1)', |
||
175 | [ |
||
176 | 'foo_0' => ['bar', PDO::PARAM_STR], |
||
177 | 'foo_1' => ['baz', PDO::PARAM_STR], |
||
178 | 'bar' => ['quix', PDO::PARAM_STR], |
||
179 | 'baz_0' => [17, PDO::PARAM_INT], |
||
180 | 'baz_1' => [34, PDO::PARAM_INT], |
||
181 | ], |
||
182 | ], |
||
183 | 'named-extend-manual-complex' => [ |
||
184 | 'foo IN (:foo) AND bar = :bar AND baz IN (:baz)', |
||
185 | [ |
||
186 | 'foo' => [['bar', PDO::PARAM_STR], ['baz', PDO::PARAM_STR]], |
||
187 | 'bar' => ['quix', PDO::PARAM_STR], |
||
188 | 'baz' => [[17, PDO::PARAM_INT], [34, PDO::PARAM_STR]], |
||
189 | ], |
||
190 | Expr::PARAM_ALL_MANUAL, |
||
191 | 'foo IN (:foo_0, :foo_1) AND bar = :bar AND baz IN (:baz_0, :baz_1)', |
||
192 | [ |
||
193 | 'foo_0' => ['bar', PDO::PARAM_STR], |
||
194 | 'foo_1' => ['baz', PDO::PARAM_STR], |
||
195 | 'bar' => ['quix', PDO::PARAM_STR], |
||
196 | 'baz_0' => [17, PDO::PARAM_INT], |
||
197 | 'baz_1' => [34, PDO::PARAM_STR], |
||
198 | ], |
||
199 | ], |
||
200 | 'named-extend-str-complex' => [ |
||
201 | 'foo IN (:foo) AND bar = :bar AND baz IN (:baz)', |
||
202 | ['foo' => ['bar', 'baz'], 'bar' => 'quix', 'baz' => [17, 34]], |
||
203 | Expr::PARAM_ALL_STRING, |
||
204 | 'foo IN (:foo_0, :foo_1) AND bar = :bar AND baz IN (:baz_0, :baz_1)', |
||
205 | [ |
||
206 | 'foo_0' => ['bar', PDO::PARAM_STR], |
||
207 | 'foo_1' => ['baz', PDO::PARAM_STR], |
||
208 | 'bar' => ['quix', PDO::PARAM_STR], |
||
209 | 'baz_0' => [17, PDO::PARAM_STR], |
||
210 | 'baz_1' => [34, PDO::PARAM_STR], |
||
211 | ], |
||
274 |