AbterPhp\Framework\Databases\Migrations\BaseMigration

Complexity

Total Complexity

5

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	load()	0	3	1
A	__construct()	0	5	1
A	up()	0	5	1
A	down()	0	5	1
A	getCreationDate()	0	3	1

<?php

declare(strict_types=1);

namespace AbterPhp\Framework\Databases\Migrations;

use AbterPhp\Framework\Filesystem\FileFinder;
use DateTime;
use Opulence\Databases\IConnection;
use Opulence\Databases\Migrations\Migration;

class BaseMigration extends Migration
{
    const FILENAME = 'foo-bar';

    const UP   = 'up';
    const DOWN = 'down';

    /** @var FileFinder */
    protected $fileFinder;

    /**
     * Init constructor.
     *
     * @param IConnection $connection
     * @param string      $migrationsPath
     * @param string      $driver
     */
    public function __construct(IConnection $connection, FileFinder $fileFinder)
    {
        parent::__construct($connection);

        $this->fileFinder = $fileFinder;
    }

    /**
     * Gets the creation date, which is used for ordering
     *
     * @return DateTime The date this migration was created
     */
    public static function getCreationDate(): DateTime
    {
        return new DateTime();
    }

    /**
     * Executes the query that rolls back the migration
     */
    public function down(): void
    {
        $sql       = $this->load(static::FILENAME, static::DOWN);
        $statement = $this->connection->prepare($sql);
        $statement->execute();
    }

    /**
     * Executes the query that commits the migration
     */
    public function up(): void
    {
        $sql       = $this->load(static::FILENAME, static::UP);
        $statement = $this->connection->prepare($sql);
        $statement->execute();
    }

    /**
     * @param string $filename
     * @param string $direction
     *
     * @return string
     */
    protected function load(string $filename, string $direction): string
    {
        return $this->fileFinder->read(sprintf('%s/%s', $direction, $filename));

The expression return $this->fileFinder->read(sprintf('%s/%s', $direction, $filename)) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}