Config::get() - Code Metrics - Inspection of "Template builder improvements" - abterphp/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 760c61...42e827 )

by Peter

created 2019-07-26 19:55 UTC

Config::get() A

↳ Parent: Config

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	3
rs	10

<?php

declare(strict_types=1);

namespace AbterPhp\Framework\Config;

use AbterPhp\Framework\Constant\Env;
use Opulence\Environments\Environment;

class Config
{
    /**
     * @return bool
     */
    public function isStaging(): bool
    {
        return Environment::getVar(Env::ENV_NAME) === Environment::STAGING;
    }

    /**
     * @return bool
     */
    public function isTesting(): bool
    {
        return Environment::getVar(Env::ENV_NAME) === Environment::TESTING;
    }

    /**
     * @return bool
     */
    public function isDevelopment(): bool
    {
        return Environment::getVar(Env::ENV_NAME) === Environment::DEVELOPMENT;
    }

    /**
     * @return bool
     */
    public function isProduction(): bool
    {
        return Environment::getVar(Env::ENV_NAME) === Environment::PRODUCTION;
    }

    /**
     * @param string $envName
     * @param mixed  $expected
     * @param mixed  $default
     *
     * @return bool
     */
    public function is(string $envName, $expected, $default = null): bool
    {
        return $this->get($envName, $default) === $expected;
    }

    /**
     * @param string $envName
     * @param mixed  $default
     *
     * @return string
     */
    public function get(string $envName, $default = null): string
    {
        return Environment::getVar($envName, $default);

    }

    /**
     * @param string $envName
     * @param mixed  $value
     *
     * @return string
     */
    public function set(string $envName, string $value): Provider
    {
        Environment::setVar($envName, $value);
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AbterPhp\Framework\Config;
6
7			use AbterPhp\Framework\Constant\Env;
8			use Opulence\Environments\Environment;
9
10			class Config
11			{
12			/**
13			* @return bool
14			*/
15			public function isStaging(): bool
16			{
17			return Environment::getVar(Env::ENV_NAME) === Environment::STAGING;
18			}
19
20			/**
21			* @return bool
22			*/
23			public function isTesting(): bool
24			{
25			return Environment::getVar(Env::ENV_NAME) === Environment::TESTING;
26			}
27
28			/**
29			* @return bool
30			*/
31			public function isDevelopment(): bool
32			{
33			return Environment::getVar(Env::ENV_NAME) === Environment::DEVELOPMENT;
34			}
35
36			/**
37			* @return bool
38			*/
39			public function isProduction(): bool
40			{
41			return Environment::getVar(Env::ENV_NAME) === Environment::PRODUCTION;
42			}
43
44			/**
45			* @param string $envName
46			* @param mixed $expected
47			* @param mixed $default
48			*
49			* @return bool
50			*/
51			public function is(string $envName, $expected, $default = null): bool
52			{
53			return $this->get($envName, $default) === $expected;
54			}
55
56			/**
57			* @param string $envName
58			* @param mixed $default
59			*
60			* @return string
61			*/
62			public function get(string $envName, $default = null): string
63			{
64			return Environment::getVar($envName, $default);
			0 ignored issues – show Bug Best Practice introduced 2019-07-26 19:57 UTC by Report Bug Copy Issue Report The expression `return Opulence\Environm...Var($envName, $default)` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
65			}
66
67			/**
68			* @param string $envName
69			* @param mixed $value
70			*
71			* @return string
72			*/
73			public function set(string $envName, string $value): Provider
74			{
75			Environment::setVar($envName, $value);
			0 ignored issues – show Bug Best Practice introduced 2019-07-26 19:57 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `AbterPhp\Framework\Config\Provider`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
76			}
77			}
78

abterphp / framework

Push — master ( 760c61...42e827 )

Config::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like