| Conditions | 1 |
| Paths | 1 |
| Total Lines | 123 |
| Code Lines | 71 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 41 | public function createValidatorProvider(): array |
||
| 42 | { |
||
| 43 | return [ |
||
| 44 | 'empty-data' => [ |
||
| 45 | [], |
||
| 46 | 0, |
||
| 47 | false, |
||
| 48 | ], |
||
| 49 | 'valid-data' => [ |
||
| 50 | [ |
||
| 51 | 'from_name' => 'foo', |
||
| 52 | 'from_email' => '[email protected]', |
||
| 53 | 'subject' => 'bar', |
||
| 54 | 'body' => 'baz', |
||
| 55 | ], |
||
| 56 | 0, |
||
| 57 | true, |
||
| 58 | ], |
||
| 59 | 'valid-data-missing-all-not-required' => [ |
||
| 60 | [ |
||
| 61 | 'from_name' => 'foo', |
||
| 62 | 'from_email' => '[email protected]', |
||
| 63 | 'subject' => 'bar', |
||
| 64 | 'body' => 'baz', |
||
| 65 | ], |
||
| 66 | 0, |
||
| 67 | true, |
||
| 68 | ], |
||
| 69 | 'invalid-name-missing' => [ |
||
| 70 | [ |
||
| 71 | 'from_email' => '[email protected]', |
||
| 72 | 'subject' => 'bar', |
||
| 73 | 'body' => 'baz', |
||
| 74 | ], |
||
| 75 | 0, |
||
| 76 | false, |
||
| 77 | ], |
||
| 78 | 'invalid-name-empty' => [ |
||
| 79 | [ |
||
| 80 | 'from_name' => '', |
||
| 81 | 'from_email' => '[email protected]', |
||
| 82 | 'subject' => 'bar', |
||
| 83 | 'body' => 'baz', |
||
| 84 | ], |
||
| 85 | 0, |
||
| 86 | false, |
||
| 87 | ], |
||
| 88 | 'invalid-email-missing' => [ |
||
| 89 | [ |
||
| 90 | 'from_name' => 'foo', |
||
| 91 | 'subject' => 'bar', |
||
| 92 | 'body' => 'baz', |
||
| 93 | ], |
||
| 94 | 0, |
||
| 95 | false, |
||
| 96 | ], |
||
| 97 | 'invalid-email-empty' => [ |
||
| 98 | [ |
||
| 99 | 'from_name' => 'foo', |
||
| 100 | 'from_email' => '', |
||
| 101 | 'subject' => 'bar', |
||
| 102 | 'body' => 'baz', |
||
| 103 | ], |
||
| 104 | 0, |
||
| 105 | false, |
||
| 106 | ], |
||
| 107 | 'invalid-email-not-valid-email' => [ |
||
| 108 | [ |
||
| 109 | 'from_name' => 'foo', |
||
| 110 | 'from_email' => 'jane@@example.com', |
||
| 111 | 'subject' => 'bar', |
||
| 112 | 'body' => 'baz', |
||
| 113 | ], |
||
| 114 | 0, |
||
| 115 | false, |
||
| 116 | ], |
||
| 117 | 'invalid-subject-missing' => [ |
||
| 118 | [ |
||
| 119 | 'from_name' => 'foo', |
||
| 120 | 'from_email' => '[email protected]', |
||
| 121 | 'body' => 'baz', |
||
| 122 | ], |
||
| 123 | 0, |
||
| 124 | false, |
||
| 125 | ], |
||
| 126 | 'invalid-subject-empty' => [ |
||
| 127 | [ |
||
| 128 | 'from_name' => 'foo', |
||
| 129 | 'from_email' => '[email protected]', |
||
| 130 | 'subject' => '', |
||
| 131 | 'body' => 'baz', |
||
| 132 | ], |
||
| 133 | 0, |
||
| 134 | false, |
||
| 135 | ], |
||
| 136 | 'invalid-body-missing' => [ |
||
| 137 | [ |
||
| 138 | 'from_name' => 'foo', |
||
| 139 | 'from_email' => '[email protected]', |
||
| 140 | 'subject' => 'bar', |
||
| 141 | ], |
||
| 142 | 0, |
||
| 143 | false, |
||
| 144 | ], |
||
| 145 | 'invalid-body-empty' => [ |
||
| 146 | [ |
||
| 147 | 'from_name' => 'foo', |
||
| 148 | 'from_email' => '[email protected]', |
||
| 149 | 'subject' => 'bar', |
||
| 150 | 'body' => '', |
||
| 151 | ], |
||
| 152 | 0, |
||
| 153 | false, |
||
| 154 | ], |
||
| 155 | 'invalid-body-too-long' => [ |
||
| 156 | [ |
||
| 157 | 'from_name' => 'foo', |
||
| 158 | 'from_email' => '[email protected]', |
||
| 159 | 'subject' => 'bar', |
||
| 160 | 'body' => 'baz', |
||
| 161 | ], |
||
| 162 | 2, |
||
| 163 | false, |
||
| 164 | ], |
||
| 186 |