AbterPhp\Contact\Orm\FormRepo

Complexity

Total Complexity

2

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getByIdentifier()	0	4	1
A	getPage()	0	4	1

<?php

declare(strict_types=1);

namespace AbterPhp\Contact\Orm;

use AbterPhp\Contact\Domain\Entities\Form as Entity;
use AbterPhp\Contact\Orm\DataMappers\FormSqlDataMapper; // @phan-suppress-current-line PhanUnreferencedUseNormal
use AbterPhp\Framework\Orm\IGridRepo;
use Opulence\Orm\Repositories\Repository;

class FormRepo extends Repository implements IGridRepo
{
    /**
     * @param int      $limitFrom
     * @param int      $pageSize
     * @param string[] $orders
     * @param array    $conditions
     * @param array    $params
     *
     * @return Entity[]
     * @throws \Opulence\Orm\OrmException
     */
    public function getPage(int $limitFrom, int $pageSize, array $orders, array $conditions, array $params): array
    {
        /** @see FormSqlDataMapper::getPage() */
        return $this->getFromDataMapper('getPage', [$limitFrom, $pageSize, $orders, $conditions, $params]);

The expression return $this->getFromDataMapper('getPage', array($limitFrom, $pageSize, $orders, $conditions, $params)) could return the type object which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param string $identifier
     *
     * @return Entity|null
     * @throws \Opulence\Orm\OrmException
     */
    public function getByIdentifier(string $identifier): ?Entity
    {
        /** @see FormSqlDataMapper::getPage() */
        return $this->getFromDataMapper('getByIdentifier', [$identifier]);

The expression return $this->getFromDataMapper('getByIdentifier', array($identifier)) could return the type array<mixed,object> which is incompatible with the type-hinted return AbterPhp\Contact\Domain\Entities\Form|null. Consider adding an additional type-check to rule them out.

    }
}