AbterPhp\Admin\Http\Controllers\Api\Editor::fileUpload()

Complexity

Conditions	4
Paths	6

Size

Total Lines	32
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	0

<?php
    public function fileUpload(): Response
    {
        $authHeader     = $this->request->getHeaders()->get('authorization');
        $actualClientId = strpos($authHeader, ' ') ? explode(' ', $authHeader)[1] : '';

It seems like $authHeader can also be of type null; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

It seems like $authHeader can also be of type null; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

        $expectedClientId = Environment::getVar(Env::EDITOR_CLIENT_ID);
        if ($actualClientId != $expectedClientId) {
            return $this->sendJson(ResponseHeaders::HTTP_FORBIDDEN);
        }

        $image = $this->request->getFiles()->get('image');
        if ($image->hasErrors()) {
            return $this->sendJson(ResponseHeaders::HTTP_INTERNAL_SERVER_ERROR);
        }

        $pathInfo  = pathinfo($image->getTempFilename());
        $baseName  = mb_substr(basename($image->getPathname()), 3);
        $extension = $pathInfo['extension'] ?? '';
        $filename  = sprintf('%s.%s', $baseName, $extension);

        $basePath = Environment::getVar(Env::EDITOR_BASE_PATH);
        $path     = Environment::getVar(Env::DIR_MEDIA) . $basePath;
        $url      = sprintf(
            '%s/%s/%s',
            rtrim(Environment::getVar(Env::MEDIA_BASE_URL), DIRECTORY_SEPARATOR),

It seems like Opulence\Environments\Environment::getVar(AbterPhp\Admin\Constant\Env::MEDIA_BASE_URL) can also be of type null; however, parameter $string of rtrim() does only seem to accept string, maybe add an additional type check?

            trim($basePath, DIRECTORY_SEPARATOR),

It seems like $basePath can also be of type null; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

            $filename
        );

        $image->move($path, $filename);

        return $this->sendJson(ResponseHeaders::HTTP_OK, ['url' => $url]);
    }